Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip defaults tests when targeting AuraDS #211

Merged
merged 1 commit into from Nov 1, 2022

Conversation

adamnsch
Copy link
Contributor

@adamnsch adamnsch commented Nov 1, 2022

Since the "neo4j" user lacks auth there.

Thank you for your contribution to the Graph Data Science Client project.

Before submitting this PR, please read Contributing to the Neo4j Ecosystem.

Make sure:

  • You signed the Neo4j CLA (Contributor License Agreement) so that we are allowed to ship your code in our library
  • Your contribution is covered by tests

@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for neo4j-graph-data-science-client canceled.

Name Link
🔨 Latest commit 2977cb3
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-graph-data-science-client/deploys/6360d0e1d3cf5500097f945d

@adamnsch
Copy link
Contributor Author

adamnsch commented Nov 1, 2022

@FlorentinD Is this a good workaround? Or would it be fine if we set for user neo4j instead?

Since the "neo4j" user lacks auth there.
@FlorentinD
Copy link
Contributor

setting it to neo4j might not work for the other non-aura versions 🤔

@adamnsch
Copy link
Contributor Author

adamnsch commented Nov 1, 2022

setting it to neo4j might not work for the other non-aura versions thinking

good point

@FlorentinD
Copy link
Contributor

just verified, that locally i would get User '' not authorized to set default for user 'neo4j' otherwise

@adamnsch adamnsch merged commit 3d6ac92 into neo4j:main Nov 1, 2022
@adamnsch adamnsch deleted the skip-defaults-tests-on-aura branch November 1, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants