Renderer alwaysEscapeNames ignored when withPrettyPrint is true

[ikwattro]

Version: 2022.8.1

Given the following statement

var start = Cypher.node("Person").named("person");
var statement = Cypher.match(start)
        .returning(start.property("name"), start.property("born"))
        .limit(10)
        .build();

The following configuration for the Renderer produces correctly escaped label names

var config = Configuration.newConfig().alwaysEscapeNames(true).build();

However, once the configuration is combined with withPrettyPrint having true, the label names are not escaped.

var config = Configuration.newConfig().alwaysEscapeNames(true).withPrettyPrint(true).build();

Reproducable failing test :

    @Test
    void fetch_escaping_with_pretty_print() {
        var start = Cypher.node("Person").named("person");
        var statement = Cypher.match(start)
                .returning(start.property("name"), start.property("born"))
                .limit(10)
                .build();

        var config = Configuration.newConfig().alwaysEscapeNames(true).withPrettyPrint(true).build();
        var generatedQuery = Renderer.getRenderer(config).render(statement);
        Assertions.assertTrue(generatedQuery.contains("MATCH (person:`Person`)"));
    }

---

I see from the code it is intended probably ?

public Builder withPrettyPrint(boolean prettyPrint) {
			this.prettyPrint = prettyPrint;
			if (this.prettyPrint) {
				return this.alwaysEscapeNames(false);
			}
			return this;
		}

However you can bypass it if you switch the method calls order

var configuration = Configuration.newConfig().withPrettyPrint(true).alwaysEscapeNames(true).build();

[michael-simons]

That is on purpose.

[michael-simons]

Added this to the docs.