Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter Select not searching after upgrade from 2.2.5 to 2.3.1 #563

Closed
luzidl opened this issue Aug 14, 2023 · 12 comments
Closed

Parameter Select not searching after upgrade from 2.2.5 to 2.3.1 #563

luzidl opened this issue Aug 14, 2023 · 12 comments
Labels
awaiting feedback bug Something isn't working

Comments

@luzidl
Copy link

luzidl commented Aug 14, 2023

After upgrading a couple of Dashboards from 2.2.5 to 2.3.1 parameter select seems to not take input that is stored as number in the database. Cut and paste of an accountID (data type: number, eg. 55716) provided a result in NeoDash 2.2.5, but did not find it in 2.3.1. Searching by typing the same account ID number does not work either. (See graphics attached below):

  • NeoDash version: 2.2.5 --> 2.3.1

  • Neo4j Database version: 4.4. 3 (Enterprise).

  • Steps to reproduce

  • Migrate a DB (4.4.3) from NeoDash 2.2.5 to 2.3.1 using a parameter select visualization on a node property that is a data type number and try to search a number in both.

  • Expected: Number is found immediately if pasted or partially if it it typed.

NeoDash 2.2.5:
image

NeoDash 2.3.1:
image

@luzidl luzidl added the bug Something isn't working label Aug 14, 2023
@BennuFire
Copy link
Collaborator

Hi @luzidl ,

This should be already fixed on the version 2.3.2 that we are expecting to release today 😀

@BennuFire
Copy link
Collaborator

@luzidl
Copy link
Author

luzidl commented Aug 14, 2023

Cool, thanks for the feedback! I did not see any open bug, thus I opened it. Looking forward to the fix.

@BennuFire
Copy link
Collaborator

I just released 2.3.2. Can you confirm this is solved for you now?

@luzidl
Copy link
Author

luzidl commented Aug 15, 2023

Nope, it is still not working. Same as before, no results found when pasting a number or typing a number.

@luzidl
Copy link
Author

luzidl commented Sep 11, 2023

@BennuFire any thoughts when this will be fixed? :-) It is an essential functionality in my AML&Fraud Demo. Thx in advaned!

@gcthys
Copy link

gcthys commented Sep 11, 2023

Hi @luzidl,

This bug worried me, so I tried to replicatie it on my dashboard. I took a random property of a random node with type "integer" and it seems to work fine:

image

Are you sure you didn't inadvertently change something in the settings? (just trying to think along...)

Guido

@BennuFire
Copy link
Collaborator

@luzidl I'm still trying to replicate the issue with no success. Can you share you dashboard json?

@luzidl
Copy link
Author

luzidl commented Sep 21, 2023

For sure @BennuFire, will send it via email in a moment.

@BennuFire
Copy link
Collaborator

Fixed on 2.3.5

@luzidl
Copy link
Author

luzidl commented Sep 25, 2023

@BennuFire, not entirely as I can see. I can not find the accountIds, but the queries are not finding anything. It seems, that parameter is not set correctly. I also tried to convert it explicitly to a number format and to a String format, but nothing works. Queries do not return any data. See screenshot below:
Bildschirmfoto 2023-09-25 um 11 16 10

@BennuFire
Copy link
Collaborator

You are completely right @luzidl , I fixed the dropdown display but missed the propagation. It's fixed here #641 . I think we will do another release later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants