Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for gds.alpha.triangles #201

Merged
merged 1 commit into from Oct 21, 2022

Conversation

FlorentinD
Copy link
Contributor

Thank you for your contribution to the Graph Data Science Client project.

Before submitting this PR, please read Contributing to the Neo4j Ecosystem.

Make sure:

  • You signed the Neo4j CLA (Contributor License Agreement) so that we are allowed to ship your code in our library
  • Your contribution is covered by tests

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for neo4j-graph-data-science-client canceled.

Name Link
🔨 Latest commit a750e44
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-graph-data-science-client/deploys/63525e583cca90000a041d64

@FlorentinD
Copy link
Contributor Author

The solution seems not ideal, but ideally this procedure would not exists on the server side.

@FlorentinD
Copy link
Contributor Author

Copy link
Contributor

@s1ck s1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

Copy link
Contributor

@adamnsch adamnsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove this as an ignored endpoint in test_coverage.py too

Co-authored-by: Adam Schill Collberg <adam.schill.collberg@protonmail.com>
@FlorentinD FlorentinD merged commit 2e378bd into neo4j:main Oct 21, 2022
@FlorentinD FlorentinD deleted the support-triangles branch October 21, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants