Support multiple dataframe input to CE construct #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
adamnsch
force-pushed
the
multidf-ce-construct
branch
2 times, most recently
from
290e004
to
1ddd475
Compare
brs96
force-pushed
the
multidf-ce-construct
branch
from
1ddd475
to
7baa590
Compare
Mats-SX
force-pushed
the
multidf-ce-construct
branch
2 times, most recently
from
84405aa
to
bcf0703
Compare
brs96
force-pushed
the
multidf-ce-construct
branch
8 times, most recently
from
3f4dbe3
to
cb4141f
Compare
Mats-SX
changed the title
Mats-SX
changed the title
brs96
force-pushed
the
multidf-ce-construct
branch
from
a68c2a1
to
d7ae229
Compare
|
The test failure is an unrelated test that is also failing on main, which @DarthMax is working to resolve. |
Mats-SX
reviewed
Dec 20, 2022
Mats-SX
reviewed
Dec 20, 2022
Mats-SX
reviewed
Dec 20, 2022
Co-authored-by: Adam Schill Collberg <adam.schill.collberg@protonmail.com> Co-authored-by: Mats Rydberg <mats@neo4j.org>
Co-authored-by: Mats Rydberg <mats@neo4j.org>
Co-authored-by: Mats Rydberg <mats@neo4j.org>
Co-authored-by: Mats Rydberg <mats@neo4j.org>
Mats-SX
force-pushed
the
multidf-ce-construct
branch
from
a23862c
to
de70def
Compare
|
Rebased to get the fix for the failing test |
adamnsch
commented
Dec 21, 2022
Comment on lines
+140
to
+141
| aligned_node_dfs = self.adjust_node_df(node_dfs, graph_schema) | ||
| aligned_rel_dfs = self.adjust_rel_df(relationship_dfs, graph_schema) |
There was a problem hiding this comment.
Suggested change
| aligned_node_dfs = self.adjust_node_df(node_dfs, graph_schema) | |
| aligned_rel_dfs = self.adjust_rel_df(relationship_dfs, graph_schema) | |
| aligned_node_dfs = self.adjust_node_dfs(node_dfs, graph_schema) | |
| aligned_rel_dfs = self.adjust_rel_dfs(relationship_dfs, graph_schema) |
Nitpick: forgot to change these names..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Graph Data Science Client project.
Before submitting this PR, please read Contributing to the Neo4j Ecosystem.
Make sure: