Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using other directives on a type decorated with @key #3541

Closed
Liam-Doodson opened this issue Jun 22, 2023 · 4 comments · Fixed by #3542 or #3552
Closed

Error when using other directives on a type decorated with @key #3541

Liam-Doodson opened this issue Jun 22, 2023 · 4 comments · Fixed by #3542 or #3552
Assignees
Labels
bug report Something isn't working confirmed Confirmed bug high priority
Projects

Comments

@Liam-Doodson
Copy link
Contributor

Liam-Doodson commented Jun 22, 2023

Type definitions

extend schema @link(url: "https://specs.apollo.dev/federation/v2.0", import: ["@key", "@shareable"])

type Movie @exclude(operations: [CREATE, DELETE, UPDATE]) @shareable @key(fields: "title") {
    title: String!
    actors: [Actor!]! @relationship(type: "ACTED_IN", direction: IN)
}

type Actor @exclude(operations: [CREATE, DELETE, UPDATE]) {
    name: String!
}

Test data

No response

Steps to reproduce

const typeDefs = `
    extend schema @link(url: "https://specs.apollo.dev/federation/v2.0", import: ["@key", "@shareable"])

    type Movie @exclude(operations: [CREATE, DELETE, UPDATE]) @shareable @key(fields: "title") {
        title: String!
        actors: [Actor!]! @relationship(type: "ACTED_IN", direction: IN)
    }

    type Actor @exclude(operations: [CREATE, DELETE, UPDATE]) {
        name: String!
    }
`;

const neoSchema = new Neo4jGraphQL({
    typeDefs,
});

await neoSchema.getSubgraphSchema();

What happened

The following error: Neo4jGraphQLSchemaValidationError: @key unrecognized arguments: operations

Expected behaviour

No error

Version

3.20.0

Database version

N/A

Relevant log output

No response

@Liam-Doodson Liam-Doodson added the bug report Something isn't working label Jun 22, 2023
@Liam-Doodson Liam-Doodson self-assigned this Jun 22, 2023
@neo4j-team-graphql
Copy link
Collaborator

Many thanks for raising this bug report @Liam-Doodson. 🐛 We will now attempt to reproduce the bug based on the steps you have provided.

Please ensure that you've provided the necessary information for a minimal reproduction, including but not limited to:

  • Type definitions
  • Resolvers
  • Query and/or Mutation (or multiple) needed to reproduce

If you have a support agreement with Neo4j, please link this GitHub issue to a new or existing Zendesk ticket.

Thanks again! 🙏

@neo4j-team-graphql neo4j-team-graphql added this to Bug reports in Bug Triage Jun 22, 2023
@neo4j-team-graphql
Copy link
Collaborator

Many thanks for raising this bug report @Liam-Doodson. 🐛 We will now attempt to reproduce the bug based on the steps you have provided.

Please ensure that you've provided the necessary information for a minimal reproduction, including but not limited to:

  • Type definitions
  • Resolvers
  • Query and/or Mutation (or multiple) needed to reproduce

If you have a support agreement with Neo4j, please link this GitHub issue to a new or existing Zendesk ticket.

Thanks again! 🙏

@Liam-Doodson Liam-Doodson moved this from Bug reports to Confirmed in Bug Triage Jun 22, 2023
@neo4j-team-graphql neo4j-team-graphql added the confirmed Confirmed bug label Jun 22, 2023
@neo4j-team-graphql
Copy link
Collaborator

We've been able to confirm this bug using the steps to reproduce that you provided - many thanks @Liam-Doodson! 🙏 We will now prioritise the bug and address it appropriately.

@Liam-Doodson Liam-Doodson moved this from Confirmed to High priority in Bug Triage Jun 22, 2023
@neo4j-team-graphql
Copy link
Collaborator

This bug report has been assigned high priority to fix. If you wish to contribute a fix, please branch from master and submit your PR with the base set to master. Thanks!

@Liam-Doodson Liam-Doodson moved this from High priority to In progress in Bug Triage Jun 22, 2023
@Liam-Doodson Liam-Doodson moved this from In progress to In review in Bug Triage Jun 22, 2023
@Liam-Doodson Liam-Doodson moved this from In review to Done (current month) in Bug Triage Jun 27, 2023
@darrellwarde darrellwarde moved this from Done (current month) to Closed in Bug Triage Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Something isn't working confirmed Confirmed bug high priority
Projects
2 participants