-
Notifications
You must be signed in to change notification settings - Fork 2.3k
/
SetPasswordCommandTest.java
282 lines (243 loc) · 11 KB
/
SetPasswordCommandTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
/*
* Copyright (c) 2002-2016 "Neo Technology,"
* Network Engine for Objects in Lund AB [http://neotechnology.com]
*
* This file is part of Neo4j.
*
* Neo4j is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package org.neo4j.commandline.admin.security;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.RuleChain;
import java.io.File;
import java.io.IOException;
import java.nio.file.Path;
import org.neo4j.commandline.admin.AdminTool;
import org.neo4j.commandline.admin.CommandFailed;
import org.neo4j.commandline.admin.CommandLocator;
import org.neo4j.commandline.admin.IncorrectUsage;
import org.neo4j.commandline.admin.OutsideWorld;
import org.neo4j.kernel.api.security.exception.InvalidArgumentsException;
import org.neo4j.logging.NullLogProvider;
import org.neo4j.server.security.auth.Credential;
import org.neo4j.server.security.auth.FileUserRepository;
import org.neo4j.server.security.auth.User;
import org.neo4j.test.rule.TargetDirectory;
import static org.hamcrest.CoreMatchers.hasItem;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.not;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.fail;
import static org.mockito.Matchers.anyString;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
public class SetPasswordCommandTest
{
private TargetDirectory.TestDirectory testDir = TargetDirectory.testDirForTest( getClass() );
private static String password_change_required = "password_change_required";
@Rule
public RuleChain ruleChain = RuleChain.outerRule( testDir );
@Test
public void shouldFailWithNoArguments() throws Exception
{
SetPasswordCommand setPasswordCommand = new SetPasswordCommand( testDir.directory( "home" ).toPath(),
testDir.directory( "conf" ).toPath() );
String[] arguments = {};
try
{
setPasswordCommand.execute( arguments );
fail( "Should have thrown an exception." );
}
catch ( IncorrectUsage e )
{
assertThat( e.getMessage(), containsString( "password" ) );
}
}
@Test
public void shouldFailOnOnlyOneArgument() throws Exception
{
SetPasswordCommand setPasswordCommand = new SetPasswordCommand( testDir.directory( "home" ).toPath(),
testDir.directory( "conf" ).toPath() );
String[] arguments = {"neo4j"};
try
{
setPasswordCommand.execute( arguments );
fail( "Should have thrown an exception." );
}
catch ( IncorrectUsage e )
{
assertThat( e.getMessage(), containsString( "password" ) );
}
}
@Test
public void shouldFailWitNonExistingUser() throws Exception
{
SetPasswordCommand setPasswordCommand = new SetPasswordCommand( testDir.directory( "home" ).toPath(),
testDir.directory( "conf" ).toPath() );
String[] arguments = {"nosuchuser", "whatever"};
try
{
setPasswordCommand.execute( arguments );
fail( "Should have thrown an exception." );
}
catch ( CommandFailed e )
{
assertThat( e.getMessage(), containsString( "does not exist" ) );
}
}
@Test
public void shouldRunSetPasswordCommandWithExistinguser() throws Throwable
{
// Given - new user that requires password change
File graphDir = testDir.graphDbDir();
createTestUser("neo4j", "neo4j");
assertUserRequiresPasswordChange( "neo4j" );
// When - the admin command sets the password
File confDir = new File( graphDir, "conf" );
SetPasswordCommand setPasswordCommand = new SetPasswordCommand( graphDir.toPath(), confDir.toPath() );
setPasswordCommand.execute( new String[]{"neo4j", "abc"} );
// Then - the new user no longer requires a password change
assertUserDoesNotRequirePasswordChange( "neo4j" );
}
@Test
public void shouldRunSetPasswordCommandWithoutExistingUser() throws Throwable
{
// Given - no user
File graphDir = testDir.graphDbDir();
// When - the admin command sets the password
File confDir = new File( graphDir, "conf" );
SetPasswordCommand setPasswordCommand = new SetPasswordCommand( graphDir.toPath(), confDir.toPath() );
setPasswordCommand.execute( new String[]{"neo4j", "abc", "--create"} );
// Then - the new user no longer requires a password change
assertUserDoesNotRequirePasswordChange( "neo4j" );
}
@Test
public void shouldFailToRunSetPasswordCommandWithoutExistingUser() throws Throwable
{
// Given - no user
File graphDir = testDir.graphDbDir();
// When - the admin command sets the password
try
{
File confDir = new File( graphDir, "conf" );
SetPasswordCommand setPasswordCommand = new SetPasswordCommand( graphDir.toPath(), confDir.toPath() );
setPasswordCommand.execute( new String[]{"neo4j", "abc"} );
}
catch ( CommandFailed e )
{
// Then we get an error
assertThat( e.getMessage(), containsString( "does not exist" ) );
}
}
@Test
public void shouldRunAdminToolWithSetPasswordCommandAndNoArgs() throws Throwable
{
// Given a user that requires password change
createTestUser("neo4j", "neo4j");
assertUserRequiresPasswordChange( "neo4j" );
// When running the neo4j-admin tool with incorrect parameters
Path homeDir = testDir.graphDbDir().toPath();
Path configDir = testDir.directory( "conf" ).toPath();
OutsideWorld out = mock( OutsideWorld.class );
AdminTool tool = new AdminTool( CommandLocator.fromServiceLocator(), out, true );
tool.execute( homeDir, configDir, "set-password" );
// Then we get error output and user still requires password change
verify( out, times( 0 ) ).stdOutLine( anyString() );
verify( out ).stdErrLine( "neo4j-admin set-password --create <username> <password>" );
verify( out ).stdErrLine( " Sets the password for the specified user and removes the password change " );
verify( out ).stdErrLine( " requirement" );
verify( out ).stdErrLine( "Missing arguments: expected username and password" );
assertUserRequiresPasswordChange( "neo4j" );
}
@Test
public void shouldRunAdminToolWithSetPasswordCommandAndArgsButNoUser() throws Throwable
{
// Given no existing user
// When running the neo4j-admin tool without --create parameter
Path homeDir = testDir.graphDbDir().toPath();
Path configDir = testDir.directory( "conf" ).toPath();
OutsideWorld out = mock( OutsideWorld.class );
AdminTool tool = new AdminTool( CommandLocator.fromServiceLocator(), out, true );
tool.execute( homeDir, configDir, "set-password", "neo4j", "abc" );
// Then we get error output and user still requires password change
verify( out, times( 0 ) ).stdOutLine( anyString() );
verify( out ).stdErrLine( "command failed: Failed to set password for 'neo4j': User 'neo4j' does not exist" );
}
@Test
public void shouldRunAdminToolWithSetPasswordCommandAndExistingUser() throws Throwable
{
// Given a user that requires password change
createTestUser("neo4j", "neo4j");
assertUserRequiresPasswordChange( "neo4j" );
// When running the neo4j-admin tool with correct parameters
Path homeDir = testDir.graphDbDir().toPath();
Path configDir = testDir.directory( "conf" ).toPath();
OutsideWorld out = mock( OutsideWorld.class );
AdminTool tool = new AdminTool( CommandLocator.fromServiceLocator(), out, true );
tool.execute( homeDir, configDir, "set-password", "neo4j", "abc" );
// Then we get no error output and the user no longer requires password change
verify( out, times( 0 ) ).stdOutLine( anyString() );
verify( out, times( 0 ) ).stdErrLine( anyString() );
verify( out ).exit(0);
assertUserDoesNotRequirePasswordChange( "neo4j" );
}
@Test
public void shouldRunAdminToolWithSetPasswordCommandAndNoExistingUser() throws Throwable
{
// Given no previously existing user
// When running the neo4j-admin tool with correct parameters
Path homeDir = testDir.graphDbDir().toPath();
Path configDir = testDir.directory( "conf" ).toPath();
OutsideWorld out = mock( OutsideWorld.class );
AdminTool tool = new AdminTool( CommandLocator.fromServiceLocator(), out, true );
tool.execute( homeDir, configDir, "set-password", "--create=true", "neo4j", "abc" );
// Then we get no error output and the user no longer requires password change
verify( out, times( 0 ) ).stdOutLine( anyString() );
verify( out, times( 0 ) ).stdOutLine( anyString() );
verify( out, times( 0 ) ).stdErrLine( anyString() );
verify( out ).exit(0);
assertUserDoesNotRequirePasswordChange( "neo4j" );
}
private File authFile()
{
return new File( new File( new File( testDir.graphDbDir(), "data" ), "dbms" ), "auth.db" );
}
private User createTestUser(String username, String password) throws IOException, InvalidArgumentsException
{
FileUserRepository users = new FileUserRepository( authFile().toPath(), NullLogProvider.getInstance() );
User user = new User.Builder( username, Credential.forPassword( password ) ).withRequiredPasswordChange( true )
.build();
users.create( user );
return user;
}
private User getUser(String username) throws Throwable
{
FileUserRepository afterUsers = new FileUserRepository( authFile().toPath(), NullLogProvider.getInstance() );
afterUsers.start(); // load users from disk
return afterUsers.getUserByName( username );
}
private void assertUserRequiresPasswordChange(String username) throws Throwable
{
User user = getUser( username );
assertThat( "User should require password change", user.getFlags(), hasItem( password_change_required ) );
}
private void assertUserDoesNotRequirePasswordChange(String username) throws Throwable
{
User user = getUser( username );
assertThat( "User should not require password change", user.getFlags(),
not( hasItem( password_change_required ) ) );
}
}