-
Notifications
You must be signed in to change notification settings - Fork 2.3k
/
CallClauseTest.scala
290 lines (250 loc) · 12.9 KB
/
CallClauseTest.scala
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
/*
* Copyright (c) 2002-2016 "Neo Technology,"
* Network Engine for Objects in Lund AB [http://neotechnology.com]
*
* This file is part of Neo4j.
*
* Neo4j is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package org.neo4j.cypher.internal.compiler.v3_1.ast
import org.neo4j.cypher.internal.compiler.v3_1.spi.{FieldSignature, ProcedureReadOnlyAccess, ProcedureSignature, QualifiedProcedureName}
import org.neo4j.cypher.internal.frontend.v3_1.ast._
import org.neo4j.cypher.internal.frontend.v3_1.symbols._
import org.neo4j.cypher.internal.frontend.v3_1.test_helpers.CypherFunSuite
import org.neo4j.cypher.internal.frontend.v3_1.{SemanticCheckResult, SemanticState}
class CallClauseTest extends CypherFunSuite with AstConstructionTestSupport {
val ns = ProcedureNamespace(List("my", "proc"))(pos)
val name = ProcedureName("foo")(pos)
val qualifiedName = QualifiedProcedureName(ns.parts, name.name)
test("should resolve CALL my.proc.foo") {
val unresolved = UnresolvedCall(ns, name, None, None)(pos)
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = Some(IndexedSeq(FieldSignature("x", CTInteger), FieldSignature("y", CTList(CTNode))))
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(Parameter("a", CTAny)(pos))
val callResults = Seq(ProcedureResultItem(varFor("x"))(pos), ProcedureResultItem(varFor("y"))(pos))
val resolved = ResolvedCall(_ => signature)(unresolved)
resolved should equal(
ResolvedCall(
signature,
callArguments,
callResults,
declaredArguments = false,
declaredResults = false
)(pos)
)
QualifiedProcedureName(unresolved) should equal(resolved.qualifiedName)
resolved.callResultTypes should equal(Seq("x" -> CTInteger, "y" -> CTList(CTNode)))
resolved.callResultIndices should equal(Seq(0 -> "x", 1 -> "y"))
}
test("should resolve void CALL my.proc.foo") {
val unresolved = UnresolvedCall(ns, name, None, None)(pos)
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = None
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(Parameter("a", CTAny)(pos))
val callResults = Seq.empty
val resolved = ResolvedCall(_ => signature)(unresolved)
resolved should equal(
ResolvedCall(
signature,
callArguments,
callResults,
declaredArguments = false,
declaredResults = false
)(pos)
)
QualifiedProcedureName(unresolved) should equal(resolved.qualifiedName)
resolved.callResultTypes should equal(Seq.empty)
resolved.callResultIndices should equal(Seq.empty)
}
test("should resolve CALL my.proc.foo YIELD x, y") {
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = Some(IndexedSeq(FieldSignature("x", CTInteger), FieldSignature("y", CTList(CTNode))))
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(Parameter("a", CTAny)(pos))
val callResults = Seq(ProcedureResultItem(varFor("x"))(pos), ProcedureResultItem(varFor("y"))(pos))
val unresolved = UnresolvedCall(ns, name, None, Some(callResults))(pos)
val resolved = ResolvedCall(_ => signature)(unresolved)
resolved should equal(
ResolvedCall(
signature,
callArguments,
callResults,
declaredArguments = false,
declaredResults = true
)(pos)
)
QualifiedProcedureName(unresolved) should equal(resolved.qualifiedName)
resolved.callResultTypes should equal(Seq("x" -> CTInteger, "y" -> CTList(CTNode)))
resolved.callResultIndices should equal(Seq(0 -> "x", 1 -> "y"))
}
test("should resolve CALL my.proc.foo(a)") {
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = Some(IndexedSeq(FieldSignature("x", CTInteger), FieldSignature("y", CTList(CTNode))))
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(Parameter("a", CTAny)(pos))
val callResults = Seq(ProcedureResultItem(varFor("x"))(pos), ProcedureResultItem(varFor("y"))(pos))
val unresolved = UnresolvedCall(ns, name, Some(callArguments), None)(pos)
val resolved = ResolvedCall(_ => signature)(unresolved)
resolved should equal(
ResolvedCall(
signature,
callArguments,
callResults,
declaredArguments = true,
declaredResults = false
)(pos)
)
QualifiedProcedureName(unresolved) should equal(resolved.qualifiedName)
resolved.callResultTypes should equal(Seq("x" -> CTInteger, "y" -> CTList(CTNode)))
resolved.callResultIndices should equal(Seq(0 -> "x", 1 -> "y"))
}
test("should resolve void CALL my.proc.foo(a)") {
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = None
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(Parameter("a", CTAny)(pos))
val callResults = Seq.empty
val unresolved = UnresolvedCall(ns, name, Some(callArguments), None)(pos)
val resolved = ResolvedCall(_ => signature)(unresolved)
resolved should equal(
ResolvedCall(
signature,
callArguments,
callResults,
declaredArguments = true,
declaredResults = false
)(pos)
)
QualifiedProcedureName(unresolved) should equal(resolved.qualifiedName)
resolved.callResultTypes should equal(Seq.empty)
resolved.callResultIndices should equal(Seq.empty)
}
test("should resolve CALL my.proc.foo(a) YIELD x, y AS z") {
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = Some(IndexedSeq(FieldSignature("x", CTInteger), FieldSignature("y", CTList(CTNode))))
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(Parameter("a", CTAny)(pos))
val callResults = Seq(
ProcedureResultItem(varFor("x"))(pos),
ProcedureResultItem(ProcedureOutput("y")(pos), varFor("z"))(pos)
)
val unresolved = UnresolvedCall(ns, name, Some(callArguments), Some(callResults))(pos)
val resolved = ResolvedCall(_ => signature)(unresolved)
resolved should equal(
ResolvedCall(
signature,
callArguments,
callResults,
declaredArguments = true,
declaredResults = true
)(pos)
)
resolved.callResultTypes should equal(Seq("x" -> CTInteger, "z" -> CTList(CTNode)))
resolved.callResultIndices should equal(Seq(0 -> "x", 1 -> "z"))
}
test("pretends to be based on user-declared arguments and results upon request") {
val signature = ProcedureSignature(qualifiedName, IndexedSeq.empty, Some(IndexedSeq.empty), None, ProcedureReadOnlyAccess(Array.empty))
val call = ResolvedCall(signature, null, null, declaredArguments = false, declaredResults = false)(pos)
call.withFakedFullDeclarations.declaredArguments should be(true)
call.withFakedFullDeclarations.declaredResults should be(true)
}
test("adds coercion of arguments to signature types upon request") {
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = Some(IndexedSeq(FieldSignature("x", CTInteger), FieldSignature("y", CTList(CTNode))))
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(Parameter("a", CTAny)(pos))
val callResults = Seq(
ProcedureResultItem(varFor("x"))(pos),
ProcedureResultItem(ProcedureOutput("y")(pos), varFor("z"))(pos)
)
val unresolved = UnresolvedCall(ns, name, Some(callArguments), Some(callResults))(pos)
val resolved = ResolvedCall(_ => signature)(unresolved)
val coerced = resolved.coerceArguments
coerced should equal(
ResolvedCall(
signature,
Seq(CoerceTo(Parameter("a", CTAny)(pos), CTInteger)),
callResults,
declaredArguments = true,
declaredResults = true
)(pos)
)
coerced.callResultTypes should equal(Seq("x" -> CTInteger, "z" -> CTList(CTNode)))
coerced.callResultIndices should equal(Seq(0 -> "x", 1 -> "z"))
}
test("should verify number of arguments during semantic checking of resolved calls") {
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = Some(IndexedSeq(FieldSignature("x", CTInteger), FieldSignature("y", CTList(CTNode))))
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq.empty
val callResults = Seq(
ProcedureResultItem(varFor("x"))(pos),
ProcedureResultItem(ProcedureOutput("y")(pos), varFor("z"))(pos)
)
val unresolved = UnresolvedCall(ns, name, Some(callArguments), Some(callResults))(pos)
val resolved = ResolvedCall(_ => signature)(unresolved)
errorTexts(resolved.semanticCheck(SemanticState.clean)).toList should equal(List(
"Procedure call does not provide the required number of arguments (1) (line 1, column 0 (offset: 0))"
))
}
test("should verify that result variables are unique during semantic checking of resolved calls") {
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = Some(IndexedSeq(FieldSignature("x", CTInteger), FieldSignature("y", CTList(CTNode))))
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(Parameter("a", CTAny)(pos))
val callResults = Seq(
ProcedureResultItem(varFor("x"))(pos),
ProcedureResultItem(ProcedureOutput("y")(pos), varFor("x"))(pos)
)
val unresolved = UnresolvedCall(ns, name, Some(callArguments), Some(callResults))(pos)
val resolved = ResolvedCall(_ => signature)(unresolved)
errorTexts(resolved.semanticCheck(SemanticState.clean)) should equal(Seq(
"Variable `x` already declared (line 1, column 0 (offset: 0))"
))
}
test("should verify that output field names are correct during semantic checking of resolved calls") {
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = Some(IndexedSeq(FieldSignature("x", CTInteger), FieldSignature("y", CTList(CTNode))))
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(Parameter("a", CTAny)(pos))
val callResults = Seq(
ProcedureResultItem(varFor("x"))(pos),
ProcedureResultItem(ProcedureOutput("p")(pos), varFor("y"))(pos)
)
val unresolved = UnresolvedCall(ns, name, Some(callArguments), Some(callResults))(pos)
val resolved = ResolvedCall(_ => signature)(unresolved)
errorTexts(resolved.semanticCheck(SemanticState.clean)) should equal(Seq(
"Unknown procedure output: `p` (line 1, column 0 (offset: 0))"
))
}
test("should verify result types during semantic checking of resolved calls") {
val signatureInputs = IndexedSeq(FieldSignature("a", CTInteger))
val signatureOutputs = Some(IndexedSeq(FieldSignature("x", CTInteger), FieldSignature("y", CTList(CTNode))))
val signature = ProcedureSignature(qualifiedName, signatureInputs, signatureOutputs, None, ProcedureReadOnlyAccess(Array.empty))
val callArguments = Seq(StringLiteral("nope")(pos))
val callResults = Seq(
ProcedureResultItem(varFor("x"))(pos),
ProcedureResultItem(ProcedureOutput("y")(pos), varFor("z"))(pos)
)
val unresolved = UnresolvedCall(ns, name, Some(callArguments), Some(callResults))(pos)
val resolved = ResolvedCall(_ => signature)(unresolved)
errorTexts(resolved.semanticCheck(SemanticState.clean)) should equal(Seq(
"Type mismatch: expected Integer but was String (line 1, column 0 (offset: 0))"
))
}
private def errorTexts(result: SemanticCheckResult) =
result.errors.map { e => s"${e.msg} (${e.position})" }
}