-
Notifications
You must be signed in to change notification settings - Fork 2.3k
/
UniquenessConstraintValidationIT.java
404 lines (337 loc) · 15.1 KB
/
UniquenessConstraintValidationIT.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
/*
* Copyright (c) 2002-2018 "Neo Technology,"
* Network Engine for Objects in Lund AB [http://neotechnology.com]
*
* This file is part of Neo4j.
*
* Neo4j is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package org.neo4j.kernel.impl.api.integrationtest;
import org.junit.Test;
import org.neo4j.internal.kernel.api.TokenNameLookup;
import org.neo4j.internal.kernel.api.TokenWrite;
import org.neo4j.internal.kernel.api.exceptions.KernelException;
import org.neo4j.kernel.api.ReadOperations;
import org.neo4j.kernel.api.SchemaWriteOperations;
import org.neo4j.kernel.api.Statement;
import org.neo4j.kernel.api.StatementTokenNameLookup;
import org.neo4j.kernel.api.exceptions.schema.UniquePropertyValueValidationException;
import org.neo4j.kernel.api.schema.SchemaDescriptorFactory;
import org.neo4j.kernel.api.schema.index.SchemaIndexDescriptor;
import org.neo4j.kernel.api.security.AnonymousContext;
import org.neo4j.values.storable.Values;
import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.Matchers.equalTo;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.fail;
import static org.neo4j.collection.primitive.PrimitiveLongCollections.count;
import static org.neo4j.internal.kernel.api.IndexQuery.exact;
import static org.neo4j.kernel.api.schema.SchemaDescriptorFactory.forLabel;
public class UniquenessConstraintValidationIT extends KernelIntegrationTest
{
@Test
public void shouldEnforceOnSetProperty() throws Exception
{
// given
constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
long node = createLabeledNode( statement, "Label1" );
try
{
int propertyKeyId = statement.tokenWriteOperations().propertyKeyGetOrCreateForName( "key1" );
statement.dataWriteOperations().nodeSetProperty( node, propertyKeyId, Values.of( "value1" ) );
fail( "should have thrown exception" );
}
// then
catch ( UniquePropertyValueValidationException e )
{
assertThat( e.getUserMessage( tokenLookup( statement ) ), containsString( "`key1` = 'value1'" ) );
}
commit();
}
@Test
public void roundingErrorsFromLongToDoubleShouldNotPreventTxFromCommitting() throws Exception
{
// Given
// a node with a constrained label and a long value
long propertyValue = 285414114323346805L;
long firstNode = constrainedNode( "label1", "key1", propertyValue );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
long node = createLabeledNode( statement, "label1" );
assertNotEquals( firstNode, node );
// When
// a new node with the same constraint is added, with a value not equal but which would be mapped to the same double
propertyValue++;
// note how propertyValue is definitely not equal to propertyValue++ but they do equal if they are cast to double
int propertyKeyId = statement.tokenWriteOperations().propertyKeyGetOrCreateForName( "key1" );
statement.dataWriteOperations().nodeSetProperty( node, propertyKeyId, Values.of( propertyValue ) );
// Then
// the commit should still succeed
commit();
}
@Test
public void shouldEnforceUniquenessConstraintOnAddLabelForNumberPropertyOnNodeNotFromTransaction() throws Exception
{
// given
constrainedNode( "Label1", "key1", 1 );
// when
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
long node = createNode( statement, "key1", 1 );
commit();
statement = statementInNewTransaction( AnonymousContext.writeToken() );
try
{
int label = statement.tokenWriteOperations().labelGetOrCreateForName( "Label1" );
statement.dataWriteOperations().nodeAddLabel( node, label );
fail( "should have thrown exception" );
}
// then
catch ( UniquePropertyValueValidationException e )
{
assertThat( e.getUserMessage( tokenLookup( statement ) ), containsString( "`key1` = 1" ) );
}
commit();
}
@Test
public void shouldEnforceUniquenessConstraintOnAddLabelForStringProperty() throws Exception
{
// given
constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
long node = createNode( statement, "key1", "value1" );
try
{
int label = statement.tokenWriteOperations().labelGetOrCreateForName( "Label1" );
statement.dataWriteOperations().nodeAddLabel( node, label );
fail( "should have thrown exception" );
}
// then
catch ( UniquePropertyValueValidationException e )
{
assertThat( e.getUserMessage( tokenLookup( statement ) ), containsString( "`key1` = 'value1'" ) );
}
commit();
}
@Test
public void shouldAllowRemoveAndAddConflictingDataInOneTransaction_DeleteNode() throws Exception
{
// given
long node = constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
statement.dataWriteOperations().nodeDelete( node );
createLabeledNode( statement, "Label1", "key1", "value1" );
commit();
}
@Test
public void shouldAllowRemoveAndAddConflictingDataInOneTransaction_RemoveLabel() throws Exception
{
// given
long node = constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
int label = statement.tokenWriteOperations().labelGetOrCreateForName( "Label1" );
statement.dataWriteOperations().nodeRemoveLabel( node, label );
createLabeledNode( statement, "Label1", "key1", "value1" );
commit();
}
@Test
public void shouldAllowRemoveAndAddConflictingDataInOneTransaction_RemoveProperty() throws Exception
{
// given
long node = constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
int key = statement.readOperations().propertyKeyGetForName( "key1" );
statement.dataWriteOperations().nodeRemoveProperty( node, key );
createLabeledNode( statement, "Label1", "key1", "value1" );
commit();
}
@Test
public void shouldAllowRemoveAndAddConflictingDataInOneTransaction_ChangeProperty() throws Exception
{
// given
long node = constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
int propertyKeyId = statement.tokenWriteOperations().propertyKeyGetOrCreateForName( "key1" );
statement.dataWriteOperations().nodeSetProperty( node, propertyKeyId, Values.of( "value2" ) );
createLabeledNode( statement, "Label1", "key1", "value1" );
commit();
}
@Test
public void shouldPreventConflictingDataInSameTransaction() throws Exception
{
// given
constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
createLabeledNode( statement, "Label1", "key1", "value2" );
try
{
createLabeledNode( statement, "Label1", "key1", "value2" );
fail( "expected exception" );
}
// then
catch ( UniquePropertyValueValidationException e )
{
assertThat( e.getUserMessage( tokenLookup( statement ) ), containsString( "`key1` = 'value2'" ) );
}
commit();
}
@Test
public void shouldAllowNoopPropertyUpdate() throws KernelException
{
// given
long node = constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
int key = statement.tokenWriteOperations().propertyKeyGetOrCreateForName( "key1" );
statement.dataWriteOperations().nodeSetProperty( node, key, Values.of( "value1" ) );
// then should not throw exception
commit();
}
@Test
public void shouldAllowNoopLabelUpdate() throws KernelException
{
// given
long node = constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
int label = statement.tokenWriteOperations().labelGetOrCreateForName( "Label1" );
statement.dataWriteOperations().nodeAddLabel( node, label );
// then should not throw exception
commit();
}
@Test
public void shouldAllowCreationOfNonConflictingData() throws Exception
{
// given
constrainedNode( "Label1", "key1", "value1" );
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
// when
createNode( statement, "key1", "value1" );
createLabeledNode( statement, "Label2", "key1", "value1" );
createLabeledNode( statement, "Label1", "key1", "value2" );
createLabeledNode( statement, "Label1", "key2", "value1" );
commit();
// then
statement = statementInNewTransaction( AnonymousContext.writeToken() );
assertEquals( "number of nodes", 5, count( statement.readOperations().nodesGetAll() ) );
rollback();
}
@Test
public void unrelatedNodesWithSamePropertyShouldNotInterfereWithUniquenessCheck() throws Exception
{
// given
createConstraint( "Person", "id" );
long ourNode;
{
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
ourNode = createLabeledNode( statement, "Person", "id", 1 );
createLabeledNode( statement, "Item", "id", 2 );
commit();
}
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
ReadOperations readOps = statement.readOperations();
int person = readOps.labelGetForName( "Person" );
int propId = readOps.propertyKeyGetForName( "id" );
SchemaIndexDescriptor idx = readOps.indexGetForSchema( SchemaDescriptorFactory.forLabel( person, propId ) );
// when
createLabeledNode( statement, "Item", "id", 2 );
// then I should find the original node
assertThat( readOps.nodeGetFromUniqueIndexSeek( idx, exact( propId, Values.of( 1 ) ) ), equalTo( ourNode ) );
commit();
}
@Test
public void addingUniqueNodeWithUnrelatedValueShouldNotAffectLookup() throws Exception
{
// given
createConstraint( "Person", "id" );
long ourNode;
{
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
ourNode = createLabeledNode( statement, "Person", "id", 1 );
commit();
}
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
ReadOperations readOps = statement.readOperations();
int person = readOps.labelGetForName( "Person" );
int propId = readOps.propertyKeyGetForName( "id" );
SchemaIndexDescriptor idx = readOps.indexGetForSchema( SchemaDescriptorFactory.forLabel( person, propId ) );
// when
createLabeledNode( statement, "Person", "id", 2 );
// then I should find the original node
assertThat( readOps.nodeGetFromUniqueIndexSeek( idx, exact( propId, Values.of( 1 ) ) ), equalTo( ourNode ));
commit();
}
private TokenNameLookup tokenLookup( Statement statement )
{
return new StatementTokenNameLookup( statement.readOperations() );
}
private long createLabeledNode( Statement statement, String label ) throws KernelException
{
long node = statement.dataWriteOperations().nodeCreate();
int labelId = statement.tokenWriteOperations().labelGetOrCreateForName( label );
statement.dataWriteOperations().nodeAddLabel( node, labelId );
return node;
}
private long createNode( Statement statement, String key, Object value ) throws KernelException
{
long node = statement.dataWriteOperations().nodeCreate();
int propertyKeyId = statement.tokenWriteOperations().propertyKeyGetOrCreateForName( key );
statement.dataWriteOperations().nodeSetProperty( node, propertyKeyId, Values.of( value ) );
return node;
}
private long createLabeledNode( Statement statement, String label, String key, Object value )
throws KernelException
{
long node = createLabeledNode( statement, label );
int propertyKeyId = statement.tokenWriteOperations().propertyKeyGetOrCreateForName( key );
statement.dataWriteOperations().nodeSetProperty( node, propertyKeyId, Values.of( value ) );
return node;
}
private long constrainedNode( String labelName, String propertyKey, Object propertyValue )
throws KernelException
{
long node;
{
Statement statement = statementInNewTransaction( AnonymousContext.writeToken() );
int label = statement.tokenWriteOperations().labelGetOrCreateForName( labelName );
node = statement.dataWriteOperations().nodeCreate();
statement.dataWriteOperations().nodeAddLabel( node, label );
int key = statement.tokenWriteOperations().propertyKeyGetOrCreateForName( propertyKey );
statement.dataWriteOperations().nodeSetProperty( node, key, Values.of( propertyValue ) );
commit();
}
createConstraint( labelName, propertyKey );
return node;
}
private void createConstraint( String label, String propertyKey ) throws KernelException
{
int labelId;
int propertyKeyId;
TokenWrite tokenWrite = tokenWriteInNewTransaction();
labelId = tokenWrite.labelGetOrCreateForName( label );
propertyKeyId = tokenWrite.propertyKeyGetOrCreateForName( propertyKey );
commit();
SchemaWriteOperations schemaWriteOperations = schemaWriteOperationsInNewTransaction();
schemaWriteOperations.uniquePropertyConstraintCreate( forLabel( labelId, propertyKeyId ) );
commit();
}
}