Skip to content

Commit

Permalink
PR comment: Various cleanups
Browse files Browse the repository at this point in the history
  • Loading branch information
burqen committed Jul 27, 2018
1 parent c67153d commit 01e0002
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
Expand Up @@ -206,7 +206,6 @@ public void shouldUpdateWithAllValues() throws Exception
updateAndCommit( updates ); updateAndCommit( updates );


// then // then
System.out.println( "Expected number of keys: " + valueSet1.size() );
int propertyKeyId = descriptor.schema().getPropertyId(); int propertyKeyId = descriptor.schema().getPropertyId();
for ( NodeAndValue entry : valueSet1 ) for ( NodeAndValue entry : valueSet1 )
{ {
Expand Down
Expand Up @@ -580,12 +580,12 @@ public String providerName()
"This improves read and write performance for non-composite indexed numbers. " + "This improves read and write performance for non-composite indexed numbers. " +
"lucene+native-2.0: Store strings in a native index and remaining value types like lucene+native-1.0. " + "lucene+native-2.0: Store strings in a native index and remaining value types like lucene+native-1.0. " +
"This improves write performance for non-composite indexed strings. " + "This improves write performance for non-composite indexed strings. " +
"This version of the native string index has a value limit of 4046 bytes, such that byte-representation " + "This version of the native string index has a value limit of 4047 bytes, such that byte-representation " +
"of a string to index cannot be larger than that limit, or the transaction trying to index such a value will fail. " + "of a string to index cannot be larger than that limit, or the transaction trying to index such a value will fail. " +
"This version of the native string index also has reduced performance for CONTAINS and ENDS WITH queries, " + "This version of the native string index also has reduced performance for CONTAINS and ENDS WITH queries, " +
"due to resorting to index scan+filter internally. " + "due to resorting to index scan+filter internally. " +
"native-gbptree-1.0: Store all value, including composite value, in native index. " + "native-gbptree-1.0: Store all value, including composite value, in native index. " +
"Just like lucene+native-2.0 there is a value size limit of 4047B. For composite indexes this limit is for all of the values in " + "Just like lucene+native-2.0 there is a value size limit of 4047 bytes. For composite indexes this limit is for all of the values in " +
"the indexed key combined. The same limitations for CONTAINS and ENDS WITH queries as for lucene+native-2.0 also applies" + "the indexed key combined. The same limitations for CONTAINS and ENDS WITH queries as for lucene+native-2.0 also applies" +
"to native-gbptree-1.0." + "to native-gbptree-1.0." +
"Native indexes generally has these benefits over Lucene:\n" + "Native indexes generally has these benefits over Lucene:\n" +
Expand Down
Expand Up @@ -30,9 +30,9 @@ class CompositeGenericKey extends NativeIndexKey<CompositeGenericKey>
{ {
private GenericKeyState[] states; private GenericKeyState[] states;


CompositeGenericKey( int length ) CompositeGenericKey( int slots )
{ {
states = new GenericKeyState[length]; states = new GenericKeyState[slots];
for ( int i = 0; i < states.length; i++ ) for ( int i = 0; i < states.length; i++ )
{ {
states[i] = new GenericKeyState(); states[i] = new GenericKeyState();
Expand Down

0 comments on commit 01e0002

Please sign in to comment.