FileMoveAction fixup

Favour PageCacheRule > manual PageCache configuration
Explicit check and IOException instead of assert in production
Removed assert from VoidPipelineWrapper

enterprise/causal-clustering/src/main/java/org/neo4j/causalclustering/handlers/VoidPipelineWrapperFactory.java

@@ -67,6 +67,9 @@ public PipelineWrapper forClient( Config config, Dependencies dependencies, LogP
 
     private static void verifyNoEncryption( Config config, Setting<String> policyName )
     {
-        assert config.get( policyName ) == null : "Unexpected SSL policy " + policyName;
+        if ( config.get( policyName ) != null )
+        {
+            throw new IllegalArgumentException( "Unexpected SSL policy " + policyName );
+        }
     }
 }

enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/scenarios/ClusterCommercialSettingsIT.java

@@ -47,7 +47,7 @@ public void cannotCreateClusterWithSslPolicyForNonCommercialUse()
         }
         catch ( Exception e )
         {
-            AssertionError cause = (AssertionError) e.getCause();
+            IllegalArgumentException cause = (IllegalArgumentException) e.getCause();
             Assert.assertThat( cause.getMessage(), containsString( CausalClusteringSettings.ssl_policy.name() ) );
         }
     }

enterprise/com/src/main/java/org/neo4j/com/storecopy/FileMoveAction.java

@@ -92,7 +92,10 @@ static FileMoveAction moveViaFileSystem( File sourceFile, File sourceDirectory )
             public void move( File toDir, CopyOption... copyOptions ) throws IOException
             {
                 copyViaFileSystem( sourceFile, sourceDirectory ).move( toDir, copyOptions );
-                assert sourceFile.delete() : sourceFile;
+                if ( !sourceFile.delete() )
+                {
+                    throw new IOException( "Unable to delete source file after copying " + sourceFile );
+                }
             }
 
             @Override

enterprise/com/src/test/java/org/neo4j/com/storecopy/FileMoveActionTest.java

@@ -33,8 +33,7 @@
 import org.neo4j.io.fs.FileSystemAbstraction;
 import org.neo4j.io.pagecache.PageCache;
 import org.neo4j.io.pagecache.PagedFile;
-import org.neo4j.kernel.configuration.Config;
-import org.neo4j.kernel.impl.pagecache.ConfigurableStandalonePageCacheFactory;
+import org.neo4j.test.rule.PageCacheRule;
 import org.neo4j.test.rule.TestDirectory;
 
 import static org.junit.Assert.assertFalse;
@@ -45,14 +44,16 @@ public class FileMoveActionTest
     @Rule
     public final TestDirectory testDirectory = TestDirectory.testDirectory();
 
+    @Rule
+    public final PageCacheRule pageCacheRule = new PageCacheRule();
+
     private FileSystemAbstraction fileSystemAbstraction = new DefaultFileSystemAbstraction();
-    private Config config = Config.defaults();
 
     @Test
     public void pageCacheFilesMovedDoNotLeaveOriginal() throws IOException
     {
         // given
-        PageCache pageCache = aPageCache();
+        PageCache pageCache = pageCacheRule.getPageCache( fileSystemAbstraction );
 
         // and
         File pageCacheFile = testDirectory.file( "page-cache-file" );
@@ -118,9 +119,4 @@ public void nonPageCacheFilesCopiedLeaveOriginal() throws IOException
         assertTrue( targetFile.exists() );
         assertTrue( sourceFile.exists() );
     }
-
-    private PageCache aPageCache()
-    {
-        return ConfigurableStandalonePageCacheFactory.createPageCache( fileSystemAbstraction, config );
-    }
 }