Small unused declaration cleanup

Remove unused classes, parameters in kernel and ha modules

community/kernel/src/main/java/org/neo4j/kernel/api/schema/index/IndexDescriptor.java

@@ -20,7 +20,6 @@
 package org.neo4j.kernel.api.schema.index;
 
 import java.util.Optional;
-import java.util.function.Predicate;
 
 import org.neo4j.internal.kernel.api.IndexOrder;
 import org.neo4j.internal.kernel.api.IndexReference;
@@ -202,37 +201,4 @@ public enum Type
         GENERAL,
         UNIQUE
     }
-
-    public enum Filter implements Predicate<IndexDescriptor>
-    {
-        GENERAL
-                {
-                    @Override
-                    public boolean test( IndexDescriptor index )
-                    {
-                        return index.type == Type.GENERAL;
-                    }
-                },
-        UNIQUE
-                {
-                    @Override
-                    public boolean test( IndexDescriptor index )
-                    {
-                        return index.type == Type.UNIQUE;
-                    }
-                },
-        ANY
-                {
-                    @Override
-                    public boolean test( IndexDescriptor index )
-                    {
-                        return true;
-                    }
-                }
-    }
-
-    public interface Supplier
-    {
-        IndexDescriptor getIndexDescriptor();
-    }
 }

community/kernel/src/main/java/org/neo4j/kernel/impl/coreapi/ExplicitIndexProxy.java

@@ -247,11 +247,6 @@ void remove( ExplicitIndexWrite operations, String name, long id, String key )
         long id( PropertyContainer entity );
     }
 
-    public interface Lookup
-    {
-        GraphDatabaseService getGraphDatabaseService();
-    }
-
     protected final String name;
     protected final Type<T> type;
     protected final Supplier<KernelTransaction> txBridge;

community/kernel/src/main/java/org/neo4j/kernel/impl/storageengine/impl/recordstorage/RecordStorageEngine.java

@@ -199,7 +199,7 @@ public RecordStorageEngine(
             schemaStorage = new SchemaStorage( neoStores.getSchemaStore() );
 
             NeoStoreIndexStoreView neoStoreIndexStoreView = new NeoStoreIndexStoreView( lockService, neoStores );
-            Boolean readOnly = config.get( GraphDatabaseSettings.read_only ) && operationalMode == OperationalMode.single;
+            boolean readOnly = config.get( GraphDatabaseSettings.read_only ) && operationalMode == OperationalMode.single;
             monitors.addMonitorListener( new LoggingMonitor( logProvider.getLog( NativeLabelScanStore.class ) ) );
             labelScanStore = new NativeLabelScanStore( pageCache, storeDir, fs, new FullLabelStream( neoStoreIndexStoreView ),
                     readOnly, monitors, recoveryCleanupWorkCollector );

community/kernel/src/main/java/org/neo4j/kernel/impl/store/NodeStore.java

@@ -42,6 +42,9 @@
  */
 public class NodeStore extends CommonAbstractStore<NodeRecord,NoStoreHeader>
 {
+    public static final String TYPE_DESCRIPTOR = "NodeStore";
+    private final DynamicArrayStore dynamicLabelStore;
+
     public static Long readOwnerFromDynamicLabelsRecord( DynamicRecord record )
     {
         byte[] data = record.getData();
@@ -63,15 +66,6 @@ public RecordCursor<DynamicRecord> newLabelCursor()
                 RecordLoad.NORMAL );
     }
 
-    public abstract static class Configuration
-        extends CommonAbstractStore.Configuration
-    {
-    }
-
-    public static final String TYPE_DESCRIPTOR = "NodeStore";
-
-    private final DynamicArrayStore dynamicLabelStore;
-
     public NodeStore(
             File fileName,
             Config config,

community/kernel/src/main/java/org/neo4j/kernel/internal/EmbeddedGraphDatabase.java

@@ -53,16 +53,6 @@
  */
 public class EmbeddedGraphDatabase extends GraphDatabaseFacade
 {
-    /**
-     * Internal constructor used by {@link org.neo4j.graphdb.factory.GraphDatabaseFactory}
-     */
-    public EmbeddedGraphDatabase( String storeDir,
-                                  Map<String, String> params,
-                                  GraphDatabaseFacadeFactory.Dependencies dependencies )
-    {
-        this( new File( storeDir ), params, dependencies );
-    }
-
     /**
      * Internal constructor used by {@link org.neo4j.graphdb.factory.GraphDatabaseFactory}
      */

enterprise/ha/src/main/java/org/neo4j/kernel/ha/cluster/DefaultMasterImplSPI.java

@@ -32,7 +32,6 @@
 import org.neo4j.com.storecopy.StoreWriter;
 import org.neo4j.internal.kernel.api.exceptions.TransactionFailureException;
 import org.neo4j.io.fs.FileSystemAbstraction;
-import org.neo4j.io.pagecache.PageCache;
 import org.neo4j.kernel.NeoStoreDataSource;
 import org.neo4j.kernel.ha.TransactionChecksumLookup;
 import org.neo4j.kernel.ha.com.master.MasterImpl;
@@ -74,7 +73,6 @@ public class DefaultMasterImplSPI implements MasterImpl.SPI
     private final File storeDir;
     private final ResponsePacker responsePacker;
     private final Monitors monitors;
-    private final PageCache pageCache;
 
     private final TransactionCommitProcess transactionCommitProcess;
     private final CheckPointer checkPointer;
@@ -91,7 +89,6 @@ public DefaultMasterImplSPI( final GraphDatabaseAPI graphDb,
                                  TransactionIdStore transactionIdStore,
                                  LogicalTransactionStore logicalTransactionStore,
                                  NeoStoreDataSource neoStoreDataSource,
-                                 PageCache pageCache,
                                  StoreCopyCheckPointMutex mutex,
                                  LogProvider logProvider )
     {
@@ -109,7 +106,6 @@ public DefaultMasterImplSPI( final GraphDatabaseAPI graphDb,
         this.txChecksumLookup = new TransactionChecksumLookup( transactionIdStore, logicalTransactionStore );
         this.responsePacker = new ResponsePacker( logicalTransactionStore, transactionIdStore, graphDb::storeId );
         this.monitors = monitors;
-        this.pageCache = pageCache;
         monitors.addMonitorListener( new LoggingStoreCopyServerMonitor( logProvider.getLog( StoreCopyServer.class ) ),
                 StoreCopyServer.class.getName() );
     }

enterprise/ha/src/main/java/org/neo4j/kernel/ha/factory/HighlyAvailableEditionModule.java

@@ -432,7 +432,6 @@ public void elected( String role, InstanceId instanceId, URI electedMember )
                         platformModule.dependencies.resolveDependency( TransactionIdStore.class ),
                         platformModule.dependencies.resolveDependency( LogicalTransactionStore.class ),
                         platformModule.dependencies.resolveDependency( NeoStoreDataSource.class ),
-                        platformModule.dependencies.resolveDependency( PageCache.class ),
                         platformModule.storeCopyCheckPointMutex,
                         logging.getInternalLogProvider() );
 

enterprise/ha/src/test/java/org/neo4j/kernel/ha/cluster/DefaultMasterImplSPITest.java

@@ -29,7 +29,6 @@
 import org.neo4j.com.storecopy.StoreWriter;
 import org.neo4j.helpers.collection.Iterators;
 import org.neo4j.io.fs.FileSystemAbstraction;
-import org.neo4j.io.pagecache.PageCache;
 import org.neo4j.kernel.NeoStoreDataSource;
 import org.neo4j.kernel.impl.api.TransactionCommitProcess;
 import org.neo4j.kernel.impl.core.LabelTokenHolder;
@@ -67,7 +66,7 @@ public void flushStoreFilesWithCorrectCheckpointTriggerName() throws IOException
                 mock( PropertyKeyTokenHolder.class ), mock( RelationshipTypeTokenHolder.class ),
                 mock( IdGeneratorFactory.class ), mock( TransactionCommitProcess.class ), checkPointer,
                 mock( TransactionIdStore.class ), mock( LogicalTransactionStore.class ),
-                dataSource, mock( PageCache.class ), new StoreCopyCheckPointMutex(), NullLogProvider.getInstance() );
+                dataSource, new StoreCopyCheckPointMutex(), NullLogProvider.getInstance() );
 
         master.flushStoresAndStreamStoreFiles( mock( StoreWriter.class ) );