Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Made batch inserter directly use lucene for legacy indexes
Currently it uses lucene through a thin wrapper around lucene's IndexWriter called ObsoleteLuceneIndexWriter. This is not needed since legacy indexes can't use partitioned lucene index infrastructure. Previously batch inserter used thin wrapper around lucene's IndexWriter that was able to track number of documents in the index and throw meaningful exceptions when 2B limit was reached. Previously used lucene version 3.6.2 did not track this limit and failed during query execution with cryptic exceptions. Currently such manual tracking functionality is not needed because updated lucene version 5.3.1 tracks 2B limit on it's own. This commit makes batch inserter use lucene APIs directly for legacy indexes which are not partitioned index aware. ObsoleteLuceneIndexWriter class is removed and it's test that models a commit-close race on IndexWriter is rewritten using AbstractLuceneIndex.
- Loading branch information
1 parent
e480e9b
commit 159f24c
Showing
8 changed files
with
96 additions
and
230 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 0 additions & 30 deletions
30
community/lucene-index/src/main/java/org/neo4j/kernel/api/impl/index/IndexWriterFactory.java
This file was deleted.
Oops, something went wrong.
136 changes: 0 additions & 136 deletions
136
...lucene-index/src/main/java/org/neo4j/kernel/api/impl/index/ObsoleteLuceneIndexWriter.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.