Set store high id in end instead of apply in HighIdTransactionApp…

…lier

Problem was that the se high id was set in `apply` (which is now
called at the end of a tx application batch) and the data applied
wasn't effectively available to transactions applied in the same
batch. E.g., populating an index (created in the same batch) would
have missed all the new nodes added by transactions preciding it in
the batch.

community/kernel/src/main/java/org/neo4j/kernel/impl/transaction/command/HighIdTransactionApplier.java

@@ -135,9 +135,9 @@ public boolean visitSchemaRuleCommand( SchemaRuleCommand command ) throws IOExce
     }
 
     @Override
-    public void apply()
+    public void end() throws Exception
     {
-        super.apply();
+        super.end();
         // Notifies the stores about the recovered ids and will bump those high ids atomically if
         // they surpass the current high ids
         for ( Map.Entry<CommonAbstractStore,HighId> highId : highIds.entrySet() )

community/kernel/src/test/java/org/neo4j/kernel/impl/transaction/command/HighIdTransactionApplierTest.java

@@ -22,12 +22,14 @@
 import org.junit.Rule;
 import org.junit.Test;
 
+import org.neo4j.kernel.impl.api.TransactionToApply;
 import org.neo4j.kernel.impl.store.NeoStores;
 import org.neo4j.kernel.impl.store.PropertyType;
 import org.neo4j.test.NeoStoresRule;
 
 import static org.junit.Assert.assertEquals;
 
+import static org.mockito.Mockito.mock;
 import static org.neo4j.kernel.impl.transaction.command.CommandHandler.EMPTY;
 
 public class HighIdTransactionApplierTest
@@ -42,6 +44,7 @@ public void shouldUpdateHighIdsOnExternalTransaction() throws Exception
         NeoStores neoStores = neoStoresRule.open();
         HighIdTransactionApplier tracker = new HighIdTransactionApplier( EMPTY, neoStores );
 
+        tracker.begin( mock( TransactionToApply.class ) );
         // WHEN
         // Nodes
         tracker.visitNodeCommand( Commands.createNode( 10, 2, 3 ) );
@@ -75,6 +78,8 @@ public void shouldUpdateHighIdsOnExternalTransaction() throws Exception
         tracker.visitPropertyCommand( Commands.createProperty( 10, PropertyType.STRING, 0, 6, 7 ) );
         tracker.visitPropertyCommand( Commands.createProperty( 20, PropertyType.ARRAY, 1, 8, 9 ) );
 
+        tracker.end();
+
         tracker.apply();
         tracker.close();