Rename label to type

In RelationshipGroupCursor we call it type but in the
RelationshipTraversalCursor we call it label, let's be consistent and
call it `type` everywhere

community/cypher/interpreted-runtime/src/main/scala/org/neo4j/cypher/internal/runtime/interpreted/TransactionBoundQueryContext.scala

@@ -735,7 +735,7 @@ sealed class TransactionBoundQueryContext(val transactionalContext: Transactiona
       val cursor = relationshipScanCursor
       reads().singleRelationship(id, cursor)
       if (cursor.next())
-        Some(fromRelationshipProxy(entityAccessor.newRelationshipProxy(id, cursor.sourceNodeReference(), cursor.label(),
+        Some(fromRelationshipProxy(entityAccessor.newRelationshipProxy(id, cursor.sourceNodeReference(), cursor.`type`(),
                                                                        cursor.targetNodeReference())))
       else
         None
@@ -748,7 +748,7 @@ sealed class TransactionBoundQueryContext(val transactionalContext: Transactiona
         override protected def fetchNext(): RelationshipValue = {
           if (relCursor.next())
             fromRelationshipProxy(entityAccessor.newRelationshipProxy(relCursor.relationshipReference(),
-                                                                      relCursor.sourceNodeReference(), relCursor.label(),
+                                                                      relCursor.sourceNodeReference(), relCursor.`type`(),
                                                                       relCursor.targetNodeReference()))
           else null
         }

community/kernel-api/src/main/java/org/neo4j/internal/kernel/api/RelationshipDataAccessor.java

@@ -27,7 +27,7 @@ public interface RelationshipDataAccessor
     long relationshipReference(); // not sure relationships will have independent references,
     // so exposing this might be leakage.
 
-    int label();
+    int type();
 
     boolean hasProperties();
 

community/kernel-api/src/main/java/org/neo4j/internal/kernel/api/helpers/Nodes.java

@@ -190,7 +190,7 @@ public static int countOutgoing( NodeCursor nodeCursor, CursorFactory cursors, i
                 nodeCursor.allRelationships( traversal );
                 while ( traversal.next() )
                 {
-                    if ( traversal.sourceNodeReference() == nodeCursor.nodeReference() && traversal.label() == type )
+                    if ( traversal.sourceNodeReference() == nodeCursor.nodeReference() && traversal.type() == type )
                     {
                         count++;
                     }
@@ -236,7 +236,7 @@ public static int countIncoming( NodeCursor nodeCursor, CursorFactory cursors, i
                 nodeCursor.allRelationships( traversal );
                 while ( traversal.next() )
                 {
-                    if ( traversal.targetNodeReference() == nodeCursor.nodeReference() && traversal.label() == type )
+                    if ( traversal.targetNodeReference() == nodeCursor.nodeReference() && traversal.type() == type )
                     {
                         count++;
                     }
@@ -280,7 +280,7 @@ public static int countAll( NodeCursor nodeCursor, CursorFactory cursors, int ty
                 nodeCursor.allRelationships( traversal );
                 while ( traversal.next() )
                 {
-                    if ( traversal.label() == type )
+                    if ( traversal.type() == type )
                     {
                         count++;
                     }

community/kernel-api/src/main/java/org/neo4j/internal/kernel/api/helpers/RelationshipDenseSelectionCursor.java

@@ -44,7 +44,7 @@ public long relationshipReference()
     @Override
     public int type()
     {
-        return relationshipCursor.label();
+        return relationshipCursor.type();
     }
 
     @Override

community/kernel-api/src/main/java/org/neo4j/internal/kernel/api/helpers/RelationshipDenseSelectionIterator.java

@@ -64,7 +64,7 @@ public R next()
         }
         R current = factory.relationship( next,
                                           relationshipCursor.sourceNodeReference(),
-                                          relationshipCursor.label(),
+                                          relationshipCursor.type(),
                                           relationshipCursor.targetNodeReference() );
 
         if ( !fetchNext() )

community/kernel-api/src/main/java/org/neo4j/internal/kernel/api/helpers/RelationshipSparseSelection.java

@@ -147,7 +147,7 @@ private boolean correctDirection()
 
     private boolean correctType()
     {
-        return types == null || ArrayUtils.contains( types, cursor.label() );
+        return types == null || ArrayUtils.contains( types, cursor.type() );
     }
 
     public void close()

community/kernel-api/src/main/java/org/neo4j/internal/kernel/api/helpers/RelationshipSparseSelectionCursor.java

@@ -44,7 +44,7 @@ public long relationshipReference()
     @Override
     public int type()
     {
-        return cursor.label();
+        return cursor.type();
     }
 
     @Override

community/kernel-api/src/main/java/org/neo4j/internal/kernel/api/helpers/RelationshipSparseSelectionIterator.java

@@ -65,7 +65,7 @@ public R next()
         }
         R current = factory.relationship( next,
                                           cursor.sourceNodeReference(),
-                                          cursor.label(),
+                                          cursor.type(),
                                           cursor.targetNodeReference() );
 
         if ( !fetchNext() )

community/kernel-api/src/test/java/org/neo4j/internal/kernel/api/RelationshipScanCursorTestBase.java

@@ -150,7 +150,7 @@ public void shouldAccessRelationshipLabels()
             read.allRelationshipsScan( relationships );
             while ( relationships.next() )
             {
-                counts.compute( relationships.label(), ( k, v ) -> v == null ? 1 : v + 1 );
+                counts.compute( relationships.type(), ( k, v ) -> v == null ? 1 : v + 1 );
             }
         }
 

community/kernel-api/src/test/java/org/neo4j/internal/kernel/api/RelationshipTestSupport.java

@@ -153,7 +153,7 @@ static void assertCount(
 
         while ( relationship.next() )
         {
-            assertEquals( "same type", expectedType, relationship.label() );
+            assertEquals( "same type", expectedType, relationship.type() );
             count++;
         }
 
@@ -239,7 +239,7 @@ else if ( r.sourceNodeReference() == r.originNodeReference() )
             d = Direction.INCOMING;
         }
 
-        return computeKey( transaction.token().relationshipTypeName( r.label() ), d );
+        return computeKey( transaction.token().relationshipTypeName( r.type() ), d );
     }
 
     static String computeKey( String type, Direction direction )

community/kernel-api/src/test/java/org/neo4j/internal/kernel/api/RelationshipTransactionStateTestBase.java

@@ -80,7 +80,7 @@ public void shouldSeeSingleRelationshipInTransaction() throws Exception
                 tx.dataRead().singleRelationship( r, relationship );
                 assertTrue( "should find relationship", relationship.next() );
 
-                assertEquals( label, relationship.label() );
+                assertEquals( label, relationship.type() );
                 assertEquals( n1, relationship.sourceNodeReference() );
                 assertEquals( n2, relationship.targetNodeReference() );
                 assertEquals( r, relationship.relationshipReference() );
@@ -1285,7 +1285,7 @@ private void assertCountRelationships(
         while ( relationship.next() )
         {
             assertEquals( sourceNode, relationship.sourceNodeReference() );
-            assertEquals( type, relationship.label() );
+            assertEquals( type, relationship.type() );
             assertEquals( targetNode, relationship.targetNodeReference() );
             count++;
         }

community/kernel-api/src/test/java/org/neo4j/internal/kernel/api/RelationshipTraversalCursorTestBase.java

@@ -122,23 +122,23 @@ public void shouldTraverseRelationshipsOfGivenType()
                     {
                         assertEquals( "node #" + node.nodeReference() +
                                         " relationship should have same label as group", group.type(),
-                                relationship.label() );
+                                relationship.type() );
                         degree.outgoing++;
                     }
                     group.incoming( relationship );
                     while ( relationship.next() )
                     {
                         assertEquals( "node #" + node.nodeReference() +
                                         "relationship should have same label as group", group.type(),
-                                relationship.label() );
+                                relationship.type() );
                         degree.incoming++;
                     }
                     group.loops( relationship );
                     while ( relationship.next() )
                     {
                         assertEquals( "node #" + node.nodeReference() +
                                         "relationship should have same label as group", group.type(),
-                                relationship.label() );
+                                relationship.type() );
                         degree.loop++;
                     }
 
@@ -191,7 +191,7 @@ public void shouldFollowSpecificRelationship()
             assertEquals( "neighbouring node", end, relationship.neighbourNodeReference() );
 
             assertEquals( "relationship should have same label as group", group.type(),
-                    relationship.label() );
+                    relationship.type() );
 
             assertFalse( "only a single relationship", relationship.next() );
 
@@ -218,7 +218,7 @@ public void shouldFollowSpecificRelationship()
             assertEquals( "neighbouring node", start, relationship.neighbourNodeReference() );
 
             assertEquals( "relationship should have same label as group", group.type(),
-                    relationship.label() );
+                    relationship.type() );
 
             assertFalse( "only a single relationship", relationship.next() );
 

community/kernel-api/src/test/java/org/neo4j/internal/kernel/api/helpers/StubRelationshipCursor.java

@@ -66,7 +66,7 @@ public long relationshipReference()
     }
 
     @Override
-    public int label()
+    public int type()
     {
         return store.get( chainId ).get( offset ).type;
     }

community/kernel/src/main/java/org/neo4j/kernel/impl/core/NodeProxy.java

@@ -757,7 +757,7 @@ public Iterable<RelationshipType> getRelationshipTypes()
             List<RelationshipType> types = new ArrayList<>();
             while ( relationships.next() )
             {
-                types.add( RelationshipType.withName( tokenRead.relationshipTypeName( relationships.label() ) ) );
+                types.add( RelationshipType.withName( tokenRead.relationshipTypeName( relationships.type() ) ) );
             }
 
             return types;

community/kernel/src/main/java/org/neo4j/kernel/impl/factory/GraphDatabaseFacade.java

@@ -476,7 +476,7 @@ protected Relationship fetchNextOrNull()
                         return newRelationshipProxy(
                                 cursor.relationshipReference(),
                                 cursor.sourceNodeReference(),
-                                cursor.label(),
+                                cursor.type(),
                                 cursor.targetNodeReference() );
                     }
                     else

community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/DefaultRelationshipScanCursor.java

@@ -131,7 +131,7 @@ else if ( hasChanges && txs.relationshipIsDeletedInThisTx( next ) )
 
     private boolean isWantedLabelAndInUse()
     {
-        return (label == -1 || label() == label) && inUse();
+        return (label == -1 || type() == label) && inUse();
     }
 
     private boolean containsRelationship( TransactionState txs )

community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/RelationshipCursor.java

@@ -49,7 +49,7 @@ public long relationshipReference()
     }
 
     @Override
-    public int label()
+    public int type()
     {
         return getType();
     }

community/kernel/src/test/java/org/neo4j/kernel/impl/newapi/OperationsLockTest.java

@@ -431,6 +431,6 @@ private void setStoreRelationship( long relationshipId, long sourceNode, long ta
         when( relationshipCursor.relationshipReference() ).thenReturn( relationshipId );
         when( relationshipCursor.sourceNodeReference() ).thenReturn( sourceNode );
         when( relationshipCursor.targetNodeReference() ).thenReturn( targetNode );
-        when( relationshipCursor.label() ).thenReturn( relationshipLabel );
+        when( relationshipCursor.type() ).thenReturn( relationshipLabel );
     }
 }