Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename raft log pruning setting to be consistent with kernel.
The raft log pruning naming was the inverse of how it was named in the kernel settings. This lead to logs to always be pruned rather than never being pruned.
- Loading branch information
Max Sumrall
committed
May 23, 2016
1 parent
dd8bb6e
commit 2904903
Showing
4 changed files
with
56 additions
and
33 deletions.
There are no files selected for viewing
54 changes: 54 additions & 0 deletions
54
...rc/test/java/org/neo4j/kernel/impl/transaction/log/pruning/ThresholdConfigParserTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Original file line | Diff line number | Diff line change |
---|---|---|---|
@@ -0,0 +1,54 @@ | |||
/* | |||
* Copyright (c) 2002-2016 "Neo Technology," | |||
* Network Engine for Objects in Lund AB [http://neotechnology.com] | |||
* | |||
* This file is part of Neo4j. | |||
* | |||
* Neo4j is free software: you can redistribute it and/or modify | |||
* it under the terms of the GNU General Public License as published by | |||
* the Free Software Foundation, either version 3 of the License, or | |||
* (at your option) any later version. | |||
* | |||
* This program is distributed in the hope that it will be useful, | |||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | |||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |||
* GNU General Public License for more details. | |||
* | |||
* You should have received a copy of the GNU General Public License | |||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
*/ | |||
package org.neo4j.kernel.impl.transaction.log.pruning; | |||
|
|||
import org.junit.Test; | |||
|
|||
import static org.junit.Assert.assertEquals; | |||
import static org.junit.Assert.fail; | |||
import static org.neo4j.kernel.impl.transaction.log.pruning.ThresholdConfigParser.ThresholdConfigValue; | |||
import static org.neo4j.kernel.impl.transaction.log.pruning.ThresholdConfigParser.ThresholdConfigValue.NO_PRUNING; | |||
import static org.neo4j.kernel.impl.transaction.log.pruning.ThresholdConfigParser.parse; | |||
|
|||
public class ThresholdConfigParserTest | |||
{ | |||
@Test | |||
public void parseTrue() throws Exception | |||
{ | |||
ThresholdConfigValue aTrue = parse( "true" ); | |||
assertEquals( NO_PRUNING.type, aTrue.type ); | |||
assertEquals( NO_PRUNING.value, aTrue.value ); | |||
} | |||
|
|||
@Test | |||
public void parseFalse() throws Exception | |||
{ | |||
ThresholdConfigValue aFalse = parse( "false" ); | |||
assertEquals( "entries", aFalse.type ); | |||
assertEquals( 1, aFalse.value ); | |||
} | |||
|
|||
@Test(expected=IllegalArgumentException.class) | |||
public void parseGarbage() throws Exception | |||
{ | |||
parse( "davide" ); | |||
fail("Expected IllegalArgumentException"); | |||
} | |||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 0 additions & 31 deletions
31
...-edge/src/test/java/org/neo4j/coreedge/raft/log/segmented/SegmentedRaftLogPrunerTest.java
This file was deleted.
Oops, something went wrong.