More primitive RelationshipCursor.hasChanges implementation

neo4j · Mar 1, 2018 · 496f1ba · 496f1ba
1 parent e476d09
commit 496f1ba
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/RelationshipCursor.java b/community/kernel/src/main/java/org/neo4j/kernel/impl/newapi/RelationshipCursor.java
@@ -28,7 +28,8 @@
 abstract class RelationshipCursor extends RelationshipRecord implements RelationshipDataAccessor, RelationshipVisitor<RuntimeException>
 {
     Read read;
-    private HasChanges hasChanges = HasChanges.MAYBE;
+    private boolean hasChanges;
+    private boolean checkHasChanges;
 
     RelationshipCursor()
     {
@@ -38,7 +39,7 @@ abstract class RelationshipCursor extends RelationshipRecord implements Relation
     protected void init( Read read )
     {
         this.read = read;
-        this.hasChanges = HasChanges.MAYBE;
+        this.checkHasChanges = true;
     }
 
     @Override
@@ -103,22 +104,17 @@ public long propertiesReference()
      */
     protected boolean hasChanges()
     {
-        if ( hasChanges == HasChanges.MAYBE )
+        if ( checkHasChanges )
         {
-            boolean changes = read.hasTxStateWithChanges();
+            hasChanges = read.hasTxStateWithChanges();
-            if ( changes )
+            if ( hasChanges )
             {
                 collectAddedTxStateSnapshot();
-                hasChanges = HasChanges.YES;
             }
-            else
+            checkHasChanges = false;
-            {
-                hasChanges = HasChanges.NO;
-            }
-            return changes;
         }
 
-        return hasChanges == HasChanges.YES;
+        return hasChanges;
     }
 
     // Load transaction state using RelationshipVisitor