Skip to content

Commit

Permalink
summary() should never be longer than a line.
Browse files Browse the repository at this point in the history
  • Loading branch information
srbaker committed Oct 24, 2016
1 parent aea196c commit 524264c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 11 deletions.
Expand Up @@ -63,10 +63,7 @@ public void print( Consumer<String> output )
String arguments = command.arguments().map( ( s ) -> " " + s ).orElse( "" ); String arguments = command.arguments().map( ( s ) -> " " + s ).orElse( "" );
output.accept( format( "%s %s%s", scriptName, command.name(), arguments ) ); output.accept( format( "%s %s%s", scriptName, command.name(), arguments ) );
output.accept( "" ); output.accept( "" );
for ( String line : splitLongLine( command.summary(), 80 ) ) output.accept( " " + command.summary() );
{
output.accept( " " + line );
}
output.accept( "" ); output.accept( "" );
} }
} }
Expand Down
Expand Up @@ -49,7 +49,7 @@ public void shouldPrintUsageForAllCommands()
new StubProvider( "restore", new StubProvider( "restore",
Optional.of( "---from <backup-directory> --database=<database-name> [--force]" ), Optional.of( "---from <backup-directory> --database=<database-name> [--force]" ),
"Restores a database backed up using the neo4j-backup tool." ), "Restores a database backed up using the neo4j-backup tool." ),
new StubProvider( "bam", Optional.empty(), "Some description" ) new StubProvider( "bam", Optional.empty(), "A summary" )
}; };
final Usage usage = new Usage( "neo4j-admin", new CannedLocator( commands ) ); final Usage usage = new Usage( "neo4j-admin", new CannedLocator( commands ) );
usage.print( out ); usage.print( out );
Expand All @@ -64,21 +64,21 @@ public void shouldPrintUsageForAllCommands()
ordered.verify( out ).accept( "" ); ordered.verify( out ).accept( "" );
ordered.verify( out ).accept( "neo4j-admin bam" ); ordered.verify( out ).accept( "neo4j-admin bam" );
ordered.verify( out ).accept( "" ); ordered.verify( out ).accept( "" );
ordered.verify( out ).accept( " Some description" ); ordered.verify( out ).accept( " A summary" );
ordered.verify( out ).accept( "" ); ordered.verify( out ).accept( "" );
ordered.verifyNoMoreInteractions(); ordered.verifyNoMoreInteractions();
} }


private static class StubProvider extends AdminCommand.Provider private static class StubProvider extends AdminCommand.Provider
{ {
private final Optional<String> arguments; private final Optional<String> arguments;
private final String description; private final String summary;


public StubProvider( String name, Optional<String> arguments, String description ) public StubProvider( String name, Optional<String> arguments, String summary )
{ {
super( name ); super( name );
this.arguments = arguments; this.arguments = arguments;
this.description = description; this.summary = summary;
} }


@Override @Override
Expand All @@ -90,13 +90,13 @@ public Optional<String> arguments()
@Override @Override
public String description() public String description()
{ {
return description; return "";
} }


@Override @Override
public String summary() public String summary()
{ {
return description; return summary;
} }


@Override @Override
Expand Down

0 comments on commit 524264c

Please sign in to comment.