Skip to content

Commit

Permalink
change requestScheme to protocol
Browse files Browse the repository at this point in the history
  • Loading branch information
praveenag committed Mar 2, 2017
1 parent 937d653 commit 56f6676
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
Expand Up @@ -56,7 +56,7 @@ public String asConnectionDetails()
} }


@Override @Override
public String requestScheme() public String protocol()
{ {
return "bolt"; return "bolt";
} }
Expand Down
Expand Up @@ -52,7 +52,7 @@ public ClientConnectionInfo withUsername( String username )
* *
* @return the scheme used for connecting to the server, or {@code null} if no scheme is available. * @return the scheme used for connecting to the server, or {@code null} if no scheme is available.
*/ */
public String requestScheme() public String protocol()
{ {
return null; return null;
} }
Expand Down Expand Up @@ -108,9 +108,9 @@ public String asConnectionDetails()
} }


@Override @Override
public String requestScheme() public String protocol()
{ {
return source.requestScheme(); return source.protocol();
} }


@Override @Override
Expand Down
Expand Up @@ -26,19 +26,19 @@
*/ */
public class HttpConnectionInfo extends ClientConnectionInfo public class HttpConnectionInfo extends ClientConnectionInfo
{ {
private final String scheme; private final String protocol;
private final InetSocketAddress clientAddress; private final InetSocketAddress clientAddress;
private final InetSocketAddress serverAddress; private final InetSocketAddress serverAddress;
private final String requestPath; private final String requestPath;


public HttpConnectionInfo( public HttpConnectionInfo(
String scheme, String protocol,
@SuppressWarnings( "unused" ) String userAgent, // useful for achieving parity with BoltConnectionInfo @SuppressWarnings( "unused" ) String userAgent, // useful for achieving parity with BoltConnectionInfo
InetSocketAddress clientAddress, InetSocketAddress clientAddress,
InetSocketAddress serverAddress, InetSocketAddress serverAddress,
String requestPath ) String requestPath )
{ {
this.scheme = scheme; this.protocol = protocol;
this.clientAddress = clientAddress; this.clientAddress = clientAddress;
this.serverAddress = serverAddress; this.serverAddress = serverAddress;
this.requestPath = requestPath; this.requestPath = requestPath;
Expand All @@ -47,13 +47,13 @@ public HttpConnectionInfo(
@Override @Override
public String asConnectionDetails() public String asConnectionDetails()
{ {
return String.join( "\t", "server-session", scheme, clientAddress.getHostString(), requestPath ); return String.join( "\t", "server-session", protocol, clientAddress.getHostString(), requestPath );
} }


@Override @Override
public String requestScheme() public String protocol()
{ {
return scheme; return protocol;
} }


@Override @Override
Expand All @@ -67,7 +67,7 @@ public String requestURI()
{ {
return serverAddress == null ? requestPath : String.format( return serverAddress == null ? requestPath : String.format(
"%s://%s:%d%s", "%s://%s:%d%s",
scheme, protocol,
serverAddress.getHostString(), serverAddress.getHostString(),
serverAddress.getPort(), serverAddress.getPort(),
requestPath ); requestPath );
Expand Down
Expand Up @@ -56,7 +56,7 @@ public class QueryStatusResult
@Deprecated @Deprecated
public final String connectionDetails; public final String connectionDetails;
/** @since Neo4j 3.2 */ /** @since Neo4j 3.2 */
public final String requestScheme; public final String protocol;
/** @since Neo4j 3.2 */ /** @since Neo4j 3.2 */
public final String clientAddress; public final String clientAddress;
/** @since Neo4j 3.2 */ /** @since Neo4j 3.2 */
Expand Down Expand Up @@ -92,7 +92,7 @@ private QueryStatusResult( QuerySnapshot query ) throws InvalidArgumentsExceptio
this.elapsedTime = formatInterval( elapsedTimeMillis ); this.elapsedTime = formatInterval( elapsedTimeMillis );
ClientConnectionInfo clientConnection = query.clientConnection(); ClientConnectionInfo clientConnection = query.clientConnection();
this.connectionDetails = clientConnection.asConnectionDetails(); this.connectionDetails = clientConnection.asConnectionDetails();
this.requestScheme = clientConnection.requestScheme(); this.protocol = clientConnection.protocol();
this.clientAddress = clientConnection.clientAddress(); this.clientAddress = clientConnection.clientAddress();
this.requestUri = clientConnection.requestURI(); this.requestUri = clientConnection.requestURI();
this.metaData = query.transactionAnnotationData(); this.metaData = query.transactionAnnotationData();
Expand Down
Expand Up @@ -212,7 +212,7 @@ public void shouldContainSpecificConnectionDetails() throws Exception
Map<String,Object> data = getQueryListing( "CALL dbms.listQueries" ); Map<String,Object> data = getQueryListing( "CALL dbms.listQueries" );


// then // then
assertThat( data, hasKey( "requestScheme" ) ); assertThat( data, hasKey( "protocol" ) );
assertThat( data, hasKey( "clientAddress" ) ); assertThat( data, hasKey( "clientAddress" ) );
assertThat( data, hasKey( "requestUri" ) ); assertThat( data, hasKey( "requestUri" ) );
} }
Expand Down

0 comments on commit 56f6676

Please sign in to comment.