Renamed direct value implementation to Direct*

community/values/src/main/java/org/neo4j/values/BooleanValue.java → community/values/src/main/java/org/neo4j/values/DirectBoolean.java

@@ -25,11 +25,11 @@
  * This does not extend AbstractProperty since the JVM can take advantage of the 4 byte initial field alignment if
  * we don't extend a class that has fields.
  */
-final class BooleanValue extends ScalarValue implements ValueGroup.VBoolean
+final class DirectBoolean extends DirectScalar implements ValueGroup.VBoolean
 {
     private final boolean bool;
 
-    BooleanValue( boolean bool )
+    DirectBoolean( boolean bool )
     {
         this.bool = bool;
     }

community/values/src/main/java/org/neo4j/values/BooleanArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectBooleanArray.java

@@ -23,11 +23,11 @@
 
 import static java.lang.String.format;
 
-class BooleanArrayValue extends ArrayValue implements ValueGroup.VBooleanArray
+final class DirectBooleanArray extends ArrayValue implements ValueGroup.VBooleanArray
 {
     private final boolean[] value;
 
-    BooleanArrayValue( boolean[] value )
+    DirectBooleanArray( boolean[] value )
     {
         assert value != null;
         this.value = value;
@@ -119,7 +119,7 @@ public int hashCode()
 
     static boolean equals( boolean[] value, Value other )
     {
-        return other instanceof BooleanArrayValue && Arrays.equals( value, ((BooleanArrayValue) other).value );
+        return other instanceof DirectBooleanArray && Arrays.equals( value, ((DirectBooleanArray) other).value );
     }
 
     static int hash( boolean[] value )

community/values/src/main/java/org/neo4j/values/ByteValue.java → community/values/src/main/java/org/neo4j/values/DirectByte.java

@@ -25,11 +25,11 @@
  * This does not extend AbstractProperty since the JVM can take advantage of the 4 byte initial field alignment if
  * we don't extend a class that has fields.
  */
-final class ByteValue extends IntegralNumberValue
+final class DirectByte extends DirectIntegralNumber
 {
     private final byte value;
 
-    ByteValue( byte value )
+    DirectByte( byte value )
     {
         this.value = value;
     }

community/values/src/main/java/org/neo4j/values/ByteArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectByteArray.java

@@ -23,11 +23,11 @@
 
 import static java.lang.String.format;
 
-class ByteArrayValue extends IntegralArrayValue
+final class DirectByteArray extends DirectIntegralArray
 {
     private final byte[] value;
 
-    ByteArrayValue( byte[] value )
+    DirectByteArray( byte[] value )
     {
         assert value != null;
         this.value = value;

community/values/src/main/java/org/neo4j/values/CharValue.java → community/values/src/main/java/org/neo4j/values/DirectChar.java

@@ -21,11 +21,11 @@
 
 import static java.lang.String.format;
 
-final class CharValue extends ScalarValue implements ValueGroup.VText
+final class DirectChar extends DirectScalar implements ValueGroup.VText
 {
     final char value;
 
-    CharValue( char value )
+    DirectChar( char value )
     {
         this.value = value;
     }

community/values/src/main/java/org/neo4j/values/CharArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectCharArray.java

@@ -23,11 +23,11 @@
 
 import static java.lang.String.format;
 
-class CharArrayValue extends ArrayValue
+final class DirectCharArray extends ArrayValue
 {
     final char[] value;
 
-    CharArrayValue( char[] value )
+    DirectCharArray( char[] value )
     {
         assert value != null;
         this.value = value;

community/values/src/main/java/org/neo4j/values/DoubleValue.java → community/values/src/main/java/org/neo4j/values/DirectDouble.java

@@ -21,11 +21,11 @@
 
 import static java.lang.String.format;
 
-final class DoubleValue extends FloatingPointNumberValue
+final class DirectDouble extends DirectFloatingPointNumber
 {
     private final double value;
 
-    DoubleValue( double value )
+    DirectDouble( double value )
     {
         this.value = value;
     }

community/values/src/main/java/org/neo4j/values/DoubleArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectDoubleArray.java

@@ -23,11 +23,11 @@
 
 import static java.lang.String.format;
 
-class DoubleArrayValue extends FloatingPointArrayValue
+final class DirectDoubleArray extends DirectFloatingPointArray
 {
     private final double[] value;
 
-    DoubleArrayValue( double[] value )
+    DirectDoubleArray( double[] value )
     {
         assert value != null;
         this.value = value;

community/values/src/main/java/org/neo4j/values/FloatValue.java → community/values/src/main/java/org/neo4j/values/DirectFloat.java

@@ -21,11 +21,11 @@
 
 import static java.lang.String.format;
 
-final class FloatValue extends FloatingPointNumberValue
+final class DirectFloat extends DirectFloatingPointNumber
 {
     private final float value;
 
-    FloatValue( float value )
+    DirectFloat( float value )
     {
         this.value = value;
     }

community/values/src/main/java/org/neo4j/values/FloatArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectFloatArray.java

@@ -23,11 +23,11 @@
 
 import static java.lang.String.format;
 
-class FloatArrayValue extends FloatingPointArrayValue
+final class DirectFloatArray extends DirectFloatingPointArray
 {
     private final float[] value;
 
-    FloatArrayValue( float[] value )
+    DirectFloatArray( float[] value )
     {
         assert value != null;
         this.value = value;

community/values/src/main/java/org/neo4j/values/FloatingPointArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectFloatingPointArray.java

@@ -19,7 +19,7 @@
  */
 package org.neo4j.values;
 
-abstract class FloatingPointArrayValue extends ArrayValue implements ValueGroup.VFloatingPointArray
+abstract class DirectFloatingPointArray extends ArrayValue implements ValueGroup.VFloatingPointArray
 {
     public abstract double doubleValue( int index );
 

community/values/src/main/java/org/neo4j/values/FloatingPointNumberValue.java → community/values/src/main/java/org/neo4j/values/DirectFloatingPointNumber.java

@@ -19,7 +19,7 @@
  */
 package org.neo4j.values;
 
-abstract class FloatingPointNumberValue extends ScalarValue implements ValueGroup.VFloatingPoint
+abstract class DirectFloatingPointNumber extends DirectScalar implements ValueGroup.VFloatingPoint
 {
     @Override
     public final int hashCode()
@@ -36,14 +36,14 @@ public boolean equals( Object other )
     @Override
     public final boolean equals( Value other )
     {
-        if ( other instanceof FloatingPointNumberValue )
+        if ( other instanceof DirectFloatingPointNumber )
         {
-            FloatingPointNumberValue that = (FloatingPointNumberValue) other;
+            DirectFloatingPointNumber that = (DirectFloatingPointNumber) other;
             return this.doubleValue() == that.doubleValue();
         }
-        else if ( other instanceof IntegralNumberValue )
+        else if ( other instanceof DirectIntegralNumber )
         {
-            IntegralNumberValue that = (IntegralNumberValue) other;
+            DirectIntegralNumber that = (DirectIntegralNumber) other;
             return NumberValues.numbersEqual( this.doubleValue(), that.longValue() );
         }
         else

community/values/src/main/java/org/neo4j/values/IntValue.java → community/values/src/main/java/org/neo4j/values/DirectInt.java

@@ -21,11 +21,11 @@
 
 import static java.lang.String.format;
 
-final class IntValue extends IntegralNumberValue
+final class DirectInt extends DirectIntegralNumber
 {
     private final int value;
 
-    IntValue( int value )
+    DirectInt( int value )
     {
         this.value = value;
     }

community/values/src/main/java/org/neo4j/values/IntArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectIntArray.java

@@ -23,11 +23,11 @@
 
 import static java.lang.String.format;
 
-class IntArrayValue extends IntegralArrayValue
+final class DirectIntArray extends DirectIntegralArray
 {
     private final int[] value;
 
-    IntArrayValue( int[] value )
+    DirectIntArray( int[] value )
     {
         assert value != null;
         this.value = value;

community/values/src/main/java/org/neo4j/values/IntegralArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectIntegralArray.java

@@ -19,7 +19,7 @@
  */
 package org.neo4j.values;
 
-abstract class IntegralArrayValue extends ArrayValue implements ValueGroup.VIntegerArray
+abstract class DirectIntegralArray extends ArrayValue implements ValueGroup.VIntegerArray
 {
     @Override
     boolean equals( boolean[] x )

community/values/src/main/java/org/neo4j/values/IntegralNumberValue.java → community/values/src/main/java/org/neo4j/values/DirectIntegralNumber.java

@@ -19,7 +19,7 @@
  */
 package org.neo4j.values;
 
-abstract class IntegralNumberValue extends ScalarValue implements ValueGroup.VInteger
+abstract class DirectIntegralNumber extends DirectScalar implements ValueGroup.VInteger
 {
     @Override
     public final int hashCode()
@@ -36,14 +36,14 @@ public boolean equals( Object other )
     @Override
     public final boolean equals( Value other )
     {
-        if ( other instanceof IntegralNumberValue )
+        if ( other instanceof DirectIntegralNumber )
         {
-            IntegralNumberValue that = (IntegralNumberValue) other;
+            DirectIntegralNumber that = (DirectIntegralNumber) other;
             return this.longValue() == that.longValue();
         }
-        else if ( other instanceof FloatingPointNumberValue )
+        else if ( other instanceof DirectFloatingPointNumber )
         {
-            FloatingPointNumberValue that = (FloatingPointNumberValue) other;
+            DirectFloatingPointNumber that = (DirectFloatingPointNumber) other;
             return NumberValues.numbersEqual( that.doubleValue(), this.longValue() );
         }
         else

community/values/src/main/java/org/neo4j/values/LongValue.java → community/values/src/main/java/org/neo4j/values/DirectLong.java

@@ -21,11 +21,11 @@
 
 import static java.lang.String.format;
 
-final class LongValue extends IntegralNumberValue
+final class DirectLong extends DirectIntegralNumber
 {
     private final long value;
 
-    LongValue( long value )
+    DirectLong( long value )
     {
         this.value = value;
     }

community/values/src/main/java/org/neo4j/values/LongArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectLongArray.java

@@ -23,11 +23,11 @@
 
 import static java.lang.String.format;
 
-class LongArrayValue extends IntegralArrayValue
+final class DirectLongArray extends DirectIntegralArray
 {
     private final long[] value;
 
-    LongArrayValue( long[] value )
+    DirectLongArray( long[] value )
     {
         assert value != null;
         this.value = value;

community/values/src/main/java/org/neo4j/values/ScalarValue.java → community/values/src/main/java/org/neo4j/values/DirectScalar.java

@@ -19,7 +19,7 @@
  */
 package org.neo4j.values;
 
-abstract class ScalarValue extends Value
+abstract class DirectScalar extends Value
 {
     @Override
     boolean equals( byte[] x )

community/values/src/main/java/org/neo4j/values/ShortValue.java → community/values/src/main/java/org/neo4j/values/DirectShort.java

@@ -25,11 +25,11 @@
  * This does not extend AbstractProperty since the JVM can take advantage of the 4 byte initial field alignment if
  * we don't extend a class that has fields.
  */
-final class ShortValue extends IntegralNumberValue
+final class DirectShort extends DirectIntegralNumber
 {
     private final short value;
 
-    ShortValue( short value )
+    DirectShort( short value )
     {
         this.value = value;
     }

community/values/src/main/java/org/neo4j/values/ShortArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectShortArray.java

@@ -23,11 +23,11 @@
 
 import static java.lang.String.format;
 
-class ShortArrayValue extends IntegralArrayValue
+final class DirectShortArray extends DirectIntegralArray
 {
     private final short[] value;
 
-    ShortArrayValue( short[] value )
+    DirectShortArray( short[] value )
     {
         assert value != null;
         this.value = value;

community/values/src/main/java/org/neo4j/values/StringValue.java → community/values/src/main/java/org/neo4j/values/DirectString.java

@@ -21,11 +21,11 @@
 
 import static java.lang.String.format;
 
-final class StringValue extends ScalarValue implements ValueGroup.VText
+final class DirectString extends DirectScalar implements ValueGroup.VText
 {
     final String string;
 
-    StringValue( String string )
+    DirectString( String string )
     {
         assert string != null;
         this.string = string;

community/values/src/main/java/org/neo4j/values/StringArrayValue.java → community/values/src/main/java/org/neo4j/values/DirectStringArray.java

@@ -23,11 +23,11 @@
 
 import static java.lang.String.format;
 
-class StringArrayValue extends ArrayValue
+final class DirectStringArray extends ArrayValue
 {
     final String[] value;
 
-    StringArrayValue( String[] value )
+    DirectStringArray( String[] value )
     {
         assert value != null;
         this.value = value;
@@ -128,7 +128,7 @@ public String toString()
         return format( "StringArray(%s)", Arrays.toString( value ) );
     }
 
-    public int compareTo( StringArrayValue other )
+    public int compareTo( DirectStringArray other )
     {
         int i = 0;
         int x = value.length - other.value.length;

community/values/src/main/java/org/neo4j/values/LazyArrayValue.java

@@ -238,7 +238,7 @@ void writeTo( Object value, ValueWriter writer )
             @Override
             int hashCode( Object array )
             {
-                return BooleanArrayValue.hash( (boolean[]) array );
+                return DirectBooleanArray.hash( (boolean[]) array );
             }
 
             @Override