Fix review comments

neo4j · Mar 6, 2018 · 5aa9567 · 5aa9567
1 parent 2a6eb84
commit 5aa9567
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 70 deletions.
diff --git a/community/csv/src/main/java/org/neo4j/csv/reader/Extractors.java b/community/csv/src/main/java/org/neo4j/csv/reader/Extractors.java
@@ -90,7 +90,7 @@ public class Extractors
     private final Extractor<long[]> longArray;
     private final Extractor<float[]> floatArray;
     private final Extractor<double[]> doubleArray;
-    private final PointExtractor point_;
+    private final PointExtractor point;
 
     public Extractors( char arrayDelimiter )
     {
@@ -141,7 +141,7 @@ public Extractors( char arrayDelimiter, boolean emptyStringsAsNull, boolean trim
             add( longArray = new LongArrayExtractor( arrayDelimiter ) );
             add( floatArray = new FloatArrayExtractor( arrayDelimiter ) );
             add( doubleArray = new DoubleArrayExtractor( arrayDelimiter ) );
-            add( point_ = new PointExtractor() );
+            add( point = new PointExtractor() );
         }
         catch ( IllegalAccessException e )
         {
@@ -249,9 +249,9 @@ public Extractor<double[]> doubleArray()
         return doubleArray;
     }
 
-    public PointExtractor point_()
+    public PointExtractor point()
     {
-        return point_;
+        return point;
     }
 
     private abstract static class AbstractExtractor<T> implements Extractor<T>

diff --git a/community/kernel/src/main/java/org/neo4j/kernel/impl/util/ValueUtils.java b/community/kernel/src/main/java/org/neo4j/kernel/impl/util/ValueUtils.java
@@ -278,7 +278,8 @@ public static RelationshipValue fromRelationshipProxy( Relationship relationship
     /**
      * Creates a {@link Value} from the given object, or if it is already a Value it is returned as it is.
      * <p>
-     * This is different from {@link Values#of} which explicitly fails if given a Value.
+     * This is different from {@link Values#of} which often explicitly fails or creates a new copy
+     * if given a Value.
      */
     public static Value asValue( Object value )
     {

diff --git a/community/values/src/main/java/org/neo4j/values/storable/PointValue.java b/community/values/src/main/java/org/neo4j/values/storable/PointValue.java
@@ -264,14 +264,11 @@ public boolean withinRange( PointValue lower, boolean includeLower, PointValue u
 
     public static PointValue fromMap( MapValue map )
     {
-        AnyValue[] fields = new Value[PointValueField.__MAX_VALUE__.ordinal()];
+        AnyValue[] fields = new Value[PointValueField.values().length];
         for ( PointValueField f : PointValueField.values() )
         {
-            if ( f != PointValueField.__MAX_VALUE__ )
+            AnyValue fieldValue = map.get( f.name().toLowerCase() );
-            {
+            fields[f.ordinal()] = fieldValue != Values.NO_VALUE ? fieldValue : null;
-                AnyValue fieldValue = map.get( f.name().toLowerCase() );
-                fields[f.ordinal()] = fieldValue != Values.NO_VALUE ? fieldValue : null;
-            }
         }
         return fromInputFields( fields );
     }
@@ -305,7 +302,7 @@ public static PointValue parse( CharSequence text )
             throw new IllegalArgumentException( errorMessage );
         }
 
-        Value[] fields = new Value[PointValueField.__MAX_VALUE__.ordinal()];
+        Value[] fields = new Value[PointValueField.values().length];
 
         do
         {
@@ -462,67 +459,24 @@ else if ( crs == CoordinateReferenceSystem.WGS84_3D )
 
     private enum PointValueField
     {
-        X
+        X( NUMBER ),
-                {
+        Y( NUMBER ),
-                    @Override
+        Z( NUMBER ),
-                    ValueGroup valueType()
+        LATITUDE( NUMBER ),
-                    {
+        LONGITUDE( NUMBER ),
-                        return NUMBER;
+        HEIGHT( NUMBER ),
-                    }
+        CRS( TEXT );
-                },
+
-        Y
+        PointValueField( ValueGroup valueType )
-                {
+        {
-                    @Override
+            this.valueType = valueType;
-                    ValueGroup valueType()
+        }
-                    {
-                        return NUMBER;
-                    }
-                },
-        Z
-                {
-                    @Override
-                    ValueGroup valueType()
-                    {
-                        return NUMBER;
-                    }
-                },
-        LATITUDE
-                {
-                    @Override
-                    ValueGroup valueType()
-                    {
-                        return NUMBER;
-                    }
-                },
-        LONGITUDE
-                {
-                    @Override
-                    ValueGroup valueType()
-                    {
-                        return NUMBER;
-                    }
-                },
-        HEIGHT
-                {
-                    @Override
-                    ValueGroup valueType()
-                    {
-                        return NUMBER;
-                    }
-                },
-        CRS
-                {
-                    @Override
-                    ValueGroup valueType()
-                    {
-                        return TEXT;
-                    }
-                },
-        __MAX_VALUE__; // This is just used to define array boundaries
 
         ValueGroup valueType()
         {
-            return ValueGroup.NO_VALUE;
+            return valueType;
         }
+
+        private ValueGroup valueType;
     }
 }