Skip to content

Commit

Permalink
Break out GBPTree read and write tests to separate test class
Browse files Browse the repository at this point in the history
  • Loading branch information
@burqen
burqen committed Jan 16, 2018
1 parent 2b82cad commit 64491ac
Show file tree
Hide file tree
Showing 2 changed files with 176 additions and 112 deletions.
176 changes: 176 additions & 0 deletions community/index/src/test/java/org/neo4j/index/internal/gbptree/GBPTreeReadWriteTest.java
View file
@@ -0,0 +1,176 @@
/*
* Copyright (c) 2002-2017 "Neo Technology,"
* Network Engine for Objects in Lund AB [http://neotechnology.com]
*
* This file is part of Neo4j.
*
* Neo4j is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package org.neo4j.index.internal.gbptree;

import org.apache.commons.lang3.mutable.MutableLong;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.RuleChain;

import java.io.File;
import java.io.IOException;
import java.util.Arrays;

import org.neo4j.collection.primitive.Primitive;
import org.neo4j.collection.primitive.PrimitiveLongCollections;
import org.neo4j.collection.primitive.PrimitiveLongSet;
import org.neo4j.cursor.RawCursor;
import org.neo4j.test.rule.PageCacheAndDependenciesRule;
import org.neo4j.test.rule.RandomRule;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

public class GBPTreeReadWriteTest
{
private RandomRule random = new RandomRule();
private PageCacheAndDependenciesRule deps = new PageCacheAndDependenciesRule();

@Rule
public RuleChain ruleChain = RuleChain.outerRule( random ).around( deps );

private Layout<MutableLong,MutableLong> layout;
private File indexFile;

@Before
public void setUp()
{
indexFile = deps.directory().file( "index" );
layout = getLayout();
}

private Layout<MutableLong,MutableLong> getLayout()
{
return new SimpleLongLayout();
}

@Test
public void shouldSeeSimpleInsertions() throws Exception
{
try ( GBPTree<MutableLong,MutableLong> index = index() )
{
int count = 1000;
try ( Writer<MutableLong,MutableLong> writer = index.writer() )
{
for ( int i = 0; i < count; i++ )
{
writer.put( new MutableLong( i ), new MutableLong( i ) );
}
}

try ( RawCursor<Hit<MutableLong,MutableLong>,IOException> cursor =
index.seek( new MutableLong( 0 ), new MutableLong( Long.MAX_VALUE ) ) )
{
for ( int i = 0; i < count; i++ )
{
assertTrue( cursor.next() );
assertEquals( i, cursor.get().key().longValue() );
}
assertFalse( cursor.next() );
}
}
}

@Test
public void shouldSeeSimpleInsertionsWithExactMatch() throws Exception
{
try ( GBPTree<MutableLong,MutableLong> index = index() )
{
int count = 1000;
try ( Writer<MutableLong,MutableLong> writer = index.writer() )
{
for ( int i = 0; i < count; i++ )
{
writer.put( new MutableLong( i ), new MutableLong( i ) );
}
}

for ( int i = 0; i < count; i++ )
{
try ( RawCursor<Hit<MutableLong,MutableLong>,IOException> cursor =
index.seek( new MutableLong( i ), new MutableLong( i ) ) )
{
assertTrue( cursor.next() );
assertEquals( i, cursor.get().key().longValue() );
assertFalse( cursor.next() );
}
}
}
}

/* Randomized tests */

@Test
public void shouldSplitCorrectly() throws Exception
{
// GIVEN
try ( GBPTree<MutableLong,MutableLong> index = index() )
{
// WHEN
int count = 1_000;
PrimitiveLongSet seen = Primitive.longSet( count );
try ( Writer<MutableLong,MutableLong> writer = index.writer() )
{
for ( int i = 0; i < count; i++ )
{
MutableLong key;
do
{
key = new MutableLong( random.nextInt( 100_000 ) );
}
while ( !seen.add( key.longValue() ) );
MutableLong value = new MutableLong( i );
writer.put( key, value );
seen.add( key.longValue() );
}
}

// THEN
try ( RawCursor<Hit<MutableLong,MutableLong>,IOException> cursor =
index.seek( new MutableLong( 0 ), new MutableLong( Long.MAX_VALUE ) ) )
{
long prev = -1;
while ( cursor.next() )
{
MutableLong hit = cursor.get().key();
if ( hit.longValue() < prev )
{
fail( hit + " smaller than prev " + prev );
}
prev = hit.longValue();
assertTrue( seen.remove( hit.longValue() ) );
}

if ( !seen.isEmpty() )
{
fail( "expected hits " + Arrays.toString( PrimitiveLongCollections.asArray( seen.iterator() ) ) );
}
}
}
}

private GBPTree<MutableLong,MutableLong> index() throws IOException
{
return new GBPTreeBuilder<>( deps.pageCache(), indexFile, layout ).build();
}
}
112 changes: 0 additions & 112 deletions community/index/src/test/java/org/neo4j/index/internal/gbptree/GBPTreeTest.java
View file
Expand Up @@ -50,9 +50,6 @@
import java.util.function.BiConsumer; import java.util.function.BiConsumer;
import java.util.function.Consumer; import java.util.function.Consumer;


import org.neo4j.collection.primitive.Primitive;
import org.neo4j.collection.primitive.PrimitiveLongCollections;
import org.neo4j.collection.primitive.PrimitiveLongSet;
import org.neo4j.cursor.RawCursor; import org.neo4j.cursor.RawCursor;
import org.neo4j.graphdb.mockfs.EphemeralFileSystemAbstraction; import org.neo4j.graphdb.mockfs.EphemeralFileSystemAbstraction;
import org.neo4j.index.internal.gbptree.GBPTree.Monitor; import org.neo4j.index.internal.gbptree.GBPTree.Monitor;
Expand Down Expand Up @@ -1120,115 +1117,6 @@ public void cleanupFinished( long numberOfPagesVisited, long numberOfCleanedCras
} }
} }


// todo checkpointMustRecognizeFailedCleaning

/* Insertion and read tests */

@Test
public void shouldSeeSimpleInsertions() throws Exception
{
try ( GBPTree<MutableLong,MutableLong> index = index().build() )
{
int count = 1000;
try ( Writer<MutableLong,MutableLong> writer = index.writer() )
{
for ( int i = 0; i < count; i++ )
{
writer.put( new MutableLong( i ), new MutableLong( i ) );
}
}

try ( RawCursor<Hit<MutableLong,MutableLong>,IOException> cursor =
index.seek( new MutableLong( 0 ), new MutableLong( Long.MAX_VALUE ) ) )
{
for ( int i = 0; i < count; i++ )
{
assertTrue( cursor.next() );
assertEquals( i, cursor.get().key().longValue() );
}
assertFalse( cursor.next() );
}
}
}

@Test
public void shouldSeeSimpleInsertionsWithExactMatch() throws Exception
{
try ( GBPTree<MutableLong,MutableLong> index = index().build() )
{
int count = 1000;
try ( Writer<MutableLong,MutableLong> writer = index.writer() )
{
for ( int i = 0; i < count; i++ )
{
writer.put( new MutableLong( i ), new MutableLong( i ) );
}
}

for ( int i = 0; i < count; i++ )
{
try ( RawCursor<Hit<MutableLong,MutableLong>,IOException> cursor =
index.seek( new MutableLong( i ), new MutableLong( i ) ) )
{
assertTrue( cursor.next() );
assertEquals( i, cursor.get().key().longValue() );
assertFalse( cursor.next() );
}
}
}
}

/* Randomized tests */

@Test
public void shouldSplitCorrectly() throws Exception
{
// GIVEN
try ( GBPTree<MutableLong,MutableLong> index = index().build() )
{
// WHEN
int count = 1_000;
PrimitiveLongSet seen = Primitive.longSet( count );
try ( Writer<MutableLong,MutableLong> writer = index.writer() )
{
for ( int i = 0; i < count; i++ )
{
MutableLong key;
do
{
key = new MutableLong( random.nextInt( 100_000 ) );
}
while ( !seen.add( key.longValue() ) );
MutableLong value = new MutableLong( i );
writer.put( key, value );
seen.add( key.longValue() );
}
}

// THEN
try ( RawCursor<Hit<MutableLong,MutableLong>,IOException> cursor =
index.seek( new MutableLong( 0 ), new MutableLong( Long.MAX_VALUE ) ) )
{
long prev = -1;
while ( cursor.next() )
{
MutableLong hit = cursor.get().key();
if ( hit.longValue() < prev )
{
fail( hit + " smaller than prev " + prev );
}
prev = hit.longValue();
assertTrue( seen.remove( hit.longValue() ) );
}

if ( !seen.isEmpty() )
{
fail( "expected hits " + Arrays.toString( PrimitiveLongCollections.asArray( seen.iterator() ) ) );
}
}
}
}

/* Checkpoint tests */ /* Checkpoint tests */


@Test @Test
Expand Down

0 comments on commit 64491ac

Please sign in to comment.