Checkstyle line length rule

Enable line length rule.
Set limit to be a bit higher then official code style (120 symbols)
because of too many violations, and editors that are not that strict
with reformatting lines that are over limit.

build/checkstyle.xml

@@ -88,6 +88,10 @@
     <module name="MultipleVariableDeclarations"/>
     <module name="GenericWhitespace"/>
     <module name="ExplicitInitialization"/>
+    <module name="LineLength">
+      <property name="max" value="140"/>
+      <property name="ignorePattern" value="a href|href|http://|https://"/>
+    </module>
   </module>
 
 </module>

community/bolt/src/main/java/org/neo4j/bolt/security/ssl/Certificates.java

@@ -65,7 +65,8 @@
 
 public class Certificates
 {
-    /** Generating SSL certificates takes a long time. This non-official setting allows us to use a fast source of randomness when running tests */
+    /* Generating SSL certificates takes a long time.
+     * This non-official setting allows us to use a fast source of randomness when running tests */
     private static final boolean useInsecureCertificateGeneration = Boolean.getBoolean( "org.neo4j.useInsecureCertificateGeneration" );
     private static final String CERTIFICATE_TYPE = "X.509";
     private static final String DEFAULT_ENCRYPTION = "RSA";

community/bolt/src/main/java/org/neo4j/bolt/transport/NettyServer.java

@@ -105,7 +105,6 @@ public void start() throws Throwable
                 // throw checked exceptions, but they actually do. The compiler won't let us catch them explicitly because in theory
                 // they shouldn't be possible, so we have to catch Throwable and do our own checks to grab them
 
-                // In any case, we do all this just in order to throw a more helpful bind exception, oh, and here's that part coming right now!
                 if ( e instanceof BindException )
                 {
                     throw new PortBindException( initializer.address(), (BindException) e );

community/bolt/src/main/java/org/neo4j/bolt/v1/messaging/infrastructure/ValueRelationship.java

@@ -65,7 +65,8 @@ public static ValueRelationship unpack( Neo4jPack.Unpacker unpacker )
         char signature = unpacker.unpackStructSignature();
         if ( signature != Neo4jPack.RELATIONSHIP )
         {
-            throw new BoltIOException( Status.Request.InvalidFormat, "Expected a relationship structure, recieved 0x" + Integer.toHexString( signature ) );
+            throw new BoltIOException( Status.Request.InvalidFormat,
+                    "Expected a relationship structure, recieved 0x" + Integer.toHexString( signature ) );
         }
         if ( numFields != STRUCT_FIELD_COUNT )
         {

community/bolt/src/main/java/org/neo4j/bolt/v1/runtime/TransactionStateMachine.java

@@ -295,7 +295,8 @@ private BoltResultHandle execute( MutableTransactionState ctx, SPI spi,
                     }
 
                     @Override
-                    void streamResult( MutableTransactionState ctx, ThrowingConsumer<BoltResult, Exception> resultConsumer ) throws Exception
+                    void streamResult( MutableTransactionState ctx,
+                            ThrowingConsumer<BoltResult,Exception> resultConsumer ) throws Exception
                     {
                         assert ctx.currentResult != null;
                         resultConsumer.accept( ctx.currentResult );

community/bolt/src/main/java/org/neo4j/bolt/v1/transport/BoltProtocolV1.java

@@ -110,23 +110,24 @@ private BoltV1Dechunker createDechunker( BoltResponseMessageWriter responseHandl
     }
 
     /*
-     * Ths methods below are used to track in-flight messages (messages the client has sent us that are waiting to be processed). We use this information
-     * to determine when to explicitly flush our output buffers - if there are no more pending messages when a message is done processing, we should flush
-     * the buffers for the session.
+     * Ths methods below are used to track in-flight messages (messages the client has sent us that are waiting
+     * to be processed). We use this information to determine when to explicitly flush our output buffers - if there
+     * are no more pending messages when a message is done processing, we should flush the buffers for the session.
      */
     private void onMessageStarted()
     {
         inFlight.incrementAndGet();
     }
 
-    // Note: This will get called from another thread; specifically, while most of the code in this class runs in an IO Thread, this method gets
-    //       called from a the session worker thread. This smells bad, and can likely be resolved by moving this whole "when to flush" logic to something
-    //       that hooks into ThreadedSessions somehow, since that class has a lot of knowledge about when there are no pending requests.
+    // Note: This will get called from another thread; specifically, while most of the code in this class runs in an
+    // IO Thread, this method gets called from a the session worker thread. This smells bad, and can likely be
+    // resolved by moving this whole "when to flush" logic to something that hooks into ThreadedSessions somehow,
+    // since that class has a lot of knowledge about when there are no pending requests.
     private void onMessageDone()
     {
         // If this is the last in-flight message, and we're not in the middle of reading another message over the wire
-        // If we are in the middle of a message, we assume there's no need for us to flush partial outbound buffers, we simply
-        // wait for more stuff to do to fill the buffers up in order to use network buffers maximally.
+        // If we are in the middle of a message, we assume there's no need for us to flush partial outbound buffers,
+        // we simply wait for more stuff to do to fill the buffers up in order to use network buffers maximally.
         if ( inFlight.decrementAndGet() == 0 && !dechunker.isInMiddleOfAMessage() )
         {
             try

community/bolt/src/main/java/org/neo4j/bolt/v1/transport/ChunkedOutput.java

@@ -123,8 +123,10 @@ public synchronized PackOutput writeDouble( double value ) throws IOException
     @Override
     public PackOutput writeBytes( ByteBuffer data ) throws IOException
     {
-        // TODO: If data is larger than our chunk size or so, we're very likely better off just passing this ByteBuffer on rather than doing the copy here
-        // TODO: *however* note that we need some way to find out when the data has been written (and thus the buffer can be re-used) if we take that approach
+        // TODO: If data is larger than our chunk size or so, we're very likely better off just passing this ByteBuffer
+        // on rather than doing the copy here
+        // TODO: *however* note that we need some way to find out when the data has been written (and thus the buffer
+        // can be re-used) if we take that approach
         // See the comment in #newBuffer for an approach that would allow that
         while ( data.remaining() > 0 )
         {
@@ -193,9 +195,11 @@ private synchronized void closeChunkIfOpen()
     private void newBuffer()
     {
         // Assumption: We're using nettys buffer pooling here
-        // If we wanted to, we can optimize this further and restrict memory usage by using our own ByteBuf impl. Each Output instance would have, say, 3
-        // buffers that it rotates. Fill one up, send it to be async flushed, fill the next one up, etc. When release is called by Netty, push buffer back
-        // onto our local stack. That way there are no global data structures for managing memory, no fragmentation and a fixed amount of RAM per session used.
+        // If we wanted to, we can optimize this further and restrict memory usage by using our own ByteBuf impl.
+        // Each Output instance would have, say, 3 buffers that it rotates. Fill one up, send it to be async flushed,
+        // fill the next one up, etc. When release is called by Netty, push buffer back onto our local stack. That
+        // way there are no global data structures for managing memory, no fragmentation and a fixed amount of
+        // RAM per session used.
         buffer = channel.alloc().buffer( bufferSize, bufferSize );
         chunkOpen = false;
     }

community/bolt/src/test/java/org/neo4j/bolt/v1/packstream/utf8/UTF8EncoderTest.java

@@ -35,7 +35,9 @@ public void shouldEncodeDecode() throws Throwable
         assertEncodes( "a" );
         assertEncodes( "ä" );
         assertEncodes( "äa" );
-        assertEncodes( "基本上，電腦只是處理數位。它們指定一個數位，來儲存字母或其他字元。在創造Unicode之前，有數百種指定這些數位的編碼系統。沒有一個編碼可以包含足夠的字元，例如：單單歐洲共同體就需要好幾種不同的編碼來包括所有的語言。即使是單一種語言，例如英語，也沒有哪一個編碼可以適用於所有的字母、標點符號，和常用的技術符號" );
+        assertEncodes( "基本上，電腦只是處理數位。它們指定一個數位，來儲存字母或其他字元。在創造Unicode之前，" +
+                "有數百種指定這些數位的編碼系統。沒有一個編碼可以包含足夠的字元，例如：單單歐洲共同體就需要好幾種不同的編碼來包括所有的語言。" +
+                "即使是單一種語言，例如英語，也沒有哪一個編碼可以適用於所有的字母、標點符號，和常用的技術符號" );
         assertEncodes( new String( new byte[(int) Math.pow( 2, 18 )] ) ); // bigger than default buffer size
     }
 

community/bolt/src/test/java/org/neo4j/bolt/v1/runtime/CypherAdapterStreamTest.java

@@ -125,7 +125,9 @@ public void shouldIncludePlanIfPresent() throws Throwable
         Map<String,Object> meta = metadataOf( stream );
 
         // Then
-        assertThat( meta.get( "plan" ).toString(), equalTo( "{args={arg1=1}, children=[{args={arg2=1}, children=[], identifiers=[id2], operatorType=Scan}], identifiers=[id1], operatorType=Join}" ) );
+        assertThat( meta.get( "plan" ).toString(),
+                equalTo( "{args={arg1=1}, children=[{args={arg2=1}, children=[], " +
+                        "identifiers=[id2], operatorType=Scan}], identifiers=[id1], operatorType=Join}" ) );
     }
 
     @Test
@@ -179,7 +181,12 @@ public void shouldIncludeNotificationsIfPresent() throws Throwable
 
         // Then
         assertThat( meta.get( "notifications" ).toString(), equalTo(
-         "[{severity=WARNING, description=The hinted index does not exist, please check the schema, code=Neo.ClientError.Schema.IndexNotFound, title=The request (directly or indirectly) referred to an index that does not exist.}, {severity=WARNING, description=Using COST planner is unsupported for this query, please use RULE planner instead, code=Neo.ClientNotification.Statement.PlannerUnsupportedWarning, position={offset=4, column=6, line=5}, title=This query is not supported by the COST planner.}]"
+         "[{severity=WARNING, description=The hinted index does not exist, please check the schema, " +
+                 "code=Neo.ClientError.Schema.IndexNotFound, title=The request (directly or indirectly) referred to an " +
+                 "index that does not exist.}, {severity=WARNING, description=Using COST planner is unsupported for " +
+                 "this query, please use RULE planner instead, " +
+                 "code=Neo.ClientNotification.Statement.PlannerUnsupportedWarning, position={offset=4, column=6, line=5}, " +
+                 "title=This query is not supported by the COST planner.}]"
         ) );
     }
 
@@ -235,13 +242,15 @@ public long getPageCacheMisses()
         }, children );
     }
 
-    private static ExecutionPlanDescription plan( final String name, final Map<String, Object> args, final List<String> identifiers, final ExecutionPlanDescription ... children )
+    private static ExecutionPlanDescription plan( final String name, final Map<String, Object> args,
+            final List<String> identifiers, final ExecutionPlanDescription ... children )
     {
         return plan( name, args, identifiers, null, children );
     }
 
-    private static ExecutionPlanDescription plan( final String name, final Map<String, Object> args, final List<String> identifiers, final
-                                                  ExecutionPlanDescription.ProfilerStatistics profile, final ExecutionPlanDescription ... children )
+    private static ExecutionPlanDescription plan( final String name, final Map<String, Object> args,
+            final List<String> identifiers, final ExecutionPlanDescription.ProfilerStatistics profile,
+            final ExecutionPlanDescription ... children )
     {
         return new ExecutionPlanDescription()
         {

community/bolt/src/test/java/org/neo4j/bolt/v1/runtime/MachineRoom.java

@@ -59,7 +59,8 @@ public static BoltStateMachine newMachine( BoltStateMachine.State state ) throws
         return machine;
     }
 
-    public static BoltStateMachine newMachineWithTransaction( BoltStateMachine.State state ) throws AuthenticationException, BoltConnectionFatality
+    public static BoltStateMachine newMachineWithTransaction( BoltStateMachine.State state )
+            throws AuthenticationException, BoltConnectionFatality
     {
         BoltStateMachine machine = newMachine();
         init( machine );

community/bolt/src/test/java/org/neo4j/bolt/v1/runtime/integration/BoltConnectionIT.java

@@ -19,17 +19,17 @@
  */
 package org.neo4j.bolt.v1.runtime.integration;
 
+import org.hamcrest.CoreMatchers;
+import org.junit.Rule;
+import org.junit.Test;
+
 import java.net.InetSocketAddress;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicReference;
 
-import org.hamcrest.CoreMatchers;
-import org.junit.Rule;
-import org.junit.Test;
-
 import org.neo4j.bolt.testing.BoltResponseRecorder;
 import org.neo4j.bolt.testing.RecordedBoltResponse;
 import org.neo4j.bolt.v1.runtime.BoltConnectionDescriptor;
@@ -469,7 +469,8 @@ public void shouldSupportUsingPeriodicCommitInSession() throws Exception
                 "USING PERIODIC COMMIT " + batch + "\n" +
                         "LOAD CSV WITH HEADERS FROM {csvFileUrl} AS l\n" +
                         "MATCH (c:Class {name: l.class_name})\n" +
-                        "CREATE (s:Sample {sepal_length: l.sepal_length, sepal_width: l.sepal_width, petal_length: l.petal_length, petal_width: l.petal_width})\n" +
+                        "CREATE (s:Sample {sepal_length: l.sepal_length, sepal_width: l.sepal_width, " +
+                        "petal_length: l.petal_length, petal_width: l.petal_width})\n" +
                         "CREATE (c)<-[:HAS_CLASS]-(s)\n" +
                         "RETURN count(*) AS c",
                 params

community/bolt/src/test/java/org/neo4j/bolt/v1/runtime/integration/SessionRule.java

@@ -70,7 +70,8 @@ public void evaluate() throws Throwable
                 config.put( GraphDatabaseSettings.auth_enabled, Boolean.toString( authEnabled ) );
                 gdb = (GraphDatabaseAPI) new TestGraphDatabaseFactory().newImpermanentDatabase( config );
                 DependencyResolver resolver = gdb.getDependencyResolver();
-                Authentication authentication = authentication( resolver.resolveDependency( AuthManager.class ), resolver.resolveDependency( UserManagerSupplier.class ) );
+                Authentication authentication = authentication( resolver.resolveDependency( AuthManager.class ),
+                        resolver.resolveDependency( UserManagerSupplier.class ) );
                 boltFactory = new BoltFactoryImpl(
                                         gdb,
                                         new UsageData( null ),

community/bolt/src/test/java/org/neo4j/bolt/v1/transport/BoltProtocolV1Test.java

@@ -68,7 +68,8 @@ public void shouldNotTalkToChannelDirectlyOnFatalError() throws Throwable
         // When
         protocol.handle( mock(ChannelHandlerContext.class), bomb );
 
-        // Then the protocol should not mess with the channel (because it runs on the IO thread, and only the worker thread should produce writes)
+        // Then the protocol should not mess with the channel (because it runs on the IO thread,
+        // and only the worker thread should produce writes)
         verifyNoMoreInteractions( outputChannel );
 
         // But instead make sure the state machine is shut down

community/codegen/src/main/java/org/neo4j/codegen/ByteCodeVisitor.java

@@ -150,7 +150,8 @@ public void visit(
         @Override
         public FieldVisitor visitField( int access, String name, String desc, String signature, Object value )
         {
-            printf( "  %s %s %s%s;%n", Modifier.toString( access ), getType( desc ).getClassName(), name, value == null ? "" : (" = " + value) );
+            printf( "  %s %s %s%s;%n", Modifier.toString( access ), getType( desc ).getClassName(), name,
+                    value == null ? "" : (" = " + value) );
             return super.visitField( access, name, desc, signature, value );
         }
 

community/codegen/src/main/java/org/neo4j/codegen/TypeReference.java

@@ -160,16 +160,26 @@ public static TypeReference[] typeReferences( Class<?>[] types )
     private final String declaringClassName;
     private final int modifiers;
 
-    public static final TypeReference VOID = new TypeReference( "", "void", true, false, false, "", void.class.getModifiers() );
-    public static final TypeReference OBJECT = new TypeReference( "java.lang", "Object", false, false, false, "", Object.class.getModifiers() );
-    public static final TypeReference BOOLEAN = new TypeReference( "", "boolean", true, false, false, "", boolean.class.getModifiers() );
-    public static final TypeReference INT = new TypeReference( "", "int", true, false, false, "", int.class.getModifiers() );
-    public static final TypeReference LONG = new TypeReference( "", "long", true, false, false, "", long.class.getModifiers() );
-    public static final TypeReference DOUBLE = new TypeReference( "", "double", true, false, false, "", double.class.getModifiers() );
-    public static final TypeReference BOOLEAN_ARRAY = new TypeReference( "", "boolean", false, true, false, "", boolean.class.getModifiers() );
-    public static final TypeReference INT_ARRAY = new TypeReference( "", "int", false, true, false, "", int.class.getModifiers() );
-    public static final TypeReference LONG_ARRAY = new TypeReference( "", "long", false, true, false, "", long.class.getModifiers() );
-    public static final TypeReference DOUBLE_ARRAY = new TypeReference( "", "double", false, true, false, "", double.class.getModifiers() );
+    public static final TypeReference VOID =
+            new TypeReference( "", "void", true, false, false, "", void.class.getModifiers() );
+    public static final TypeReference OBJECT =
+            new TypeReference( "java.lang", "Object", false, false, false, "", Object.class.getModifiers() );
+    public static final TypeReference BOOLEAN =
+            new TypeReference( "", "boolean", true, false, false, "", boolean.class.getModifiers() );
+    public static final TypeReference INT =
+            new TypeReference( "", "int", true, false, false, "", int.class.getModifiers() );
+    public static final TypeReference LONG =
+            new TypeReference( "", "long", true, false, false, "", long.class.getModifiers() );
+    public static final TypeReference DOUBLE =
+            new TypeReference( "", "double", true, false, false, "", double.class.getModifiers() );
+    public static final TypeReference BOOLEAN_ARRAY =
+            new TypeReference( "", "boolean", false, true, false, "", boolean.class.getModifiers() );
+    public static final TypeReference INT_ARRAY =
+            new TypeReference( "", "int", false, true, false, "", int.class.getModifiers() );
+    public static final TypeReference LONG_ARRAY =
+            new TypeReference( "", "long", false, true, false, "", long.class.getModifiers() );
+    public static final TypeReference DOUBLE_ARRAY =
+            new TypeReference( "", "double", false, true, false, "", double.class.getModifiers() );
     static final TypeReference[] NO_TYPES = new TypeReference[0];
 
     TypeReference( String packageName, String name, boolean isPrimitive, boolean isArray,

community/common/src/main/java/org/neo4j/function/ThrowingBinaryOperator.java

@@ -20,8 +20,9 @@
 package org.neo4j.function;
 
 /**
- * Represents an operation on a single operand that produces a result of the same type as its operand. This is a specialization of {@link ThrowingBiFunction}
- * for the case where the operand and result are of the same type.
+ * Represents an operation on a single operand that produces a result of the same type as its operand.
+ * This is a specialization of {@link ThrowingBiFunction} for the case where the operand and result are of the same
+ * type.
  *
  * @param <T> the type of the operand and result of the operator
  * @param <E> the type of exception that may be thrown from the operator

community/common/src/main/java/org/neo4j/function/ThrowingConsumer.java

@@ -20,8 +20,8 @@
 package org.neo4j.function;
 
 /**
- * Represents an operation that accepts a single input argument and returns no result. Unlike most other functional interfaces, ThrowingConsumer is expected to
- * operate via side-effects.
+ * Represents an operation that accepts a single input argument and returns no result.
+ * Unlike most other functional interfaces, ThrowingConsumer is expected to operate via side-effects.
  *
  * @param <T> the type of the input to the operation
  * @param <E> the type of exception that may be thrown from the function