Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Better error message when deleting a node with relationships.
It took.. a while. But here is a better error message whenever a node with relationships gets deleted. Resolves #1903
- Loading branch information
Showing
11 changed files
with
155 additions
and
99 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
community/kernel/src/test/java/org/neo4j/graphdb/DeleteNodeWithRelsIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Original file line | Diff line number | Diff line change |
---|---|---|---|
@@ -0,0 +1,64 @@ | |||
/* | |||
* Copyright (c) 2002-2015 "Neo Technology," | |||
* Network Engine for Objects in Lund AB [http://neotechnology.com] | |||
* | |||
* This file is part of Neo4j. | |||
* | |||
* Neo4j is free software: you can redistribute it and/or modify | |||
* it under the terms of the GNU General Public License as published by | |||
* the Free Software Foundation, either version 3 of the License, or | |||
* (at your option) any later version. | |||
* | |||
* This program is distributed in the hope that it will be useful, | |||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | |||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |||
* GNU General Public License for more details. | |||
* | |||
* You should have received a copy of the GNU General Public License | |||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
*/ | |||
package org.neo4j.graphdb; | |||
|
|||
import org.junit.Rule; | |||
import org.junit.Test; | |||
import org.junit.rules.ExpectedException; | |||
|
|||
import org.neo4j.test.ImpermanentDatabaseRule; | |||
|
|||
public class DeleteNodeWithRelsIT | |||
{ | |||
@Rule | |||
public ImpermanentDatabaseRule db = new ImpermanentDatabaseRule(); | |||
|
|||
@Rule | |||
public ExpectedException exception = ExpectedException.none(); | |||
|
|||
@Test | |||
public void shouldGiveHelpfulExceptionWhenDeletingNodeWithRels() throws Exception | |||
{ | |||
// Given | |||
GraphDatabaseService db = this.db.getGraphDatabaseService(); | |||
|
|||
Node node; | |||
try( Transaction tx = db.beginTx() ) | |||
{ | |||
node = db.createNode(); | |||
node.createRelationshipTo( db.createNode(), DynamicRelationshipType.withName( "MAYOR_OF" ) ); | |||
tx.success(); | |||
} | |||
|
|||
// And given a transaction deleting just the node | |||
Transaction tx = db.beginTx(); | |||
node.delete(); | |||
tx.success(); | |||
|
|||
// Expect | |||
exception.expect( ConstraintViolationException.class ); | |||
exception.expectMessage( "Cannot delete node<"+node.getId()+">, because it still has relationships. " + | |||
"To delete this node, you must first delete its relationships." ); | |||
|
|||
// When I commit | |||
tx.close(); | |||
} | |||
|
|||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.