Skip to content

Commit

Permalink
Make fields final and renaming.
Browse files Browse the repository at this point in the history
  • Loading branch information
MishaDemianenko committed Jun 26, 2017
1 parent 2674c8a commit 7d0ebef
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 18 deletions.
Expand Up @@ -52,7 +52,7 @@
import org.neo4j.helpers.ListenSocketAddress; import org.neo4j.helpers.ListenSocketAddress;
import org.neo4j.helpers.Service; import org.neo4j.helpers.Service;
import org.neo4j.kernel.api.bolt.BoltConnectionTracker; import org.neo4j.kernel.api.bolt.BoltConnectionTracker;
import org.neo4j.kernel.api.bolt.BoltConnectorRegister; import org.neo4j.kernel.api.bolt.BoltPortRegister;
import org.neo4j.kernel.api.security.AuthManager; import org.neo4j.kernel.api.security.AuthManager;
import org.neo4j.kernel.api.security.UserManagerSupplier; import org.neo4j.kernel.api.security.UserManagerSupplier;
import org.neo4j.kernel.configuration.BoltConnector; import org.neo4j.kernel.configuration.BoltConnector;
Expand Down Expand Up @@ -106,7 +106,7 @@ public interface Dependencies


BoltConnectionTracker sessionTracker(); BoltConnectionTracker sessionTracker();


BoltConnectorRegister connectionRegister(); BoltPortRegister connectionRegister();


Clock clock(); Clock clock();


Expand Down Expand Up @@ -144,7 +144,7 @@ public Lifecycle newInstance( KernelContext context, Dependencies dependencies )
BoltFactory boltFactory = life.add( new BoltFactoryImpl( api, dependencies.usageData(), BoltFactory boltFactory = life.add( new BoltFactoryImpl( api, dependencies.usageData(),
logService, dependencies.txBridge(), authentication, dependencies.sessionTracker(), config ) ); logService, dependencies.txBridge(), authentication, dependencies.sessionTracker(), config ) );
WorkerFactory workerFactory = createWorkerFactory( boltFactory, scheduler, dependencies, logService, clock ); WorkerFactory workerFactory = createWorkerFactory( boltFactory, scheduler, dependencies, logService, clock );
BoltConnectorRegister connectionRegister = dependencies.connectionRegister(); BoltPortRegister connectionRegister = dependencies.connectionRegister();


Map<BoltConnector, ProtocolInitializer> connectors = config.enabledBoltConnectors().stream() Map<BoltConnector, ProtocolInitializer> connectors = config.enabledBoltConnectors().stream()
.collect( Collectors.toMap( Function.identity(), connConfig -> .collect( Collectors.toMap( Function.identity(), connConfig ->
Expand Down
Expand Up @@ -35,7 +35,7 @@


import org.neo4j.helpers.ListenSocketAddress; import org.neo4j.helpers.ListenSocketAddress;
import org.neo4j.helpers.PortBindException; import org.neo4j.helpers.PortBindException;
import org.neo4j.kernel.api.bolt.BoltConnectorRegister; import org.neo4j.kernel.api.bolt.BoltPortRegister;
import org.neo4j.kernel.configuration.BoltConnector; import org.neo4j.kernel.configuration.BoltConnector;
import org.neo4j.kernel.lifecycle.LifecycleAdapter; import org.neo4j.kernel.lifecycle.LifecycleAdapter;


Expand All @@ -52,7 +52,7 @@ public class NettyServer extends LifecycleAdapter


private final Map<BoltConnector, ProtocolInitializer> bootstrappersMap; private final Map<BoltConnector, ProtocolInitializer> bootstrappersMap;
private final ThreadFactory tf; private final ThreadFactory tf;
private BoltConnectorRegister connectionRegister; private final BoltPortRegister connectionRegister;
private EventLoopGroup bossGroup; private EventLoopGroup bossGroup;
private EventLoopGroup selectorGroup; private EventLoopGroup selectorGroup;


Expand All @@ -71,7 +71,7 @@ public interface ProtocolInitializer
* @param connectorRegister register to keep local address information on all configured connectors * @param connectorRegister register to keep local address information on all configured connectors
*/ */
public NettyServer( ThreadFactory tf, Map<BoltConnector, ProtocolInitializer> initializersMap, public NettyServer( ThreadFactory tf, Map<BoltConnector, ProtocolInitializer> initializersMap,
BoltConnectorRegister connectorRegister ) BoltPortRegister connectorRegister )
{ {
this.bootstrappersMap = initializersMap; this.bootstrappersMap = initializersMap;
this.tf = tf; this.tf = tf;
Expand Down
Expand Up @@ -33,7 +33,7 @@
import org.neo4j.helpers.ListenSocketAddress; import org.neo4j.helpers.ListenSocketAddress;
import org.neo4j.helpers.NamedThreadFactory; import org.neo4j.helpers.NamedThreadFactory;
import org.neo4j.helpers.PortBindException; import org.neo4j.helpers.PortBindException;
import org.neo4j.kernel.api.bolt.BoltConnectorRegister; import org.neo4j.kernel.api.bolt.BoltPortRegister;
import org.neo4j.kernel.configuration.BoltConnector; import org.neo4j.kernel.configuration.BoltConnector;


import static org.neo4j.helpers.collection.MapUtil.genericMap; import static org.neo4j.helpers.collection.MapUtil.genericMap;
Expand All @@ -60,7 +60,7 @@ public void shouldGivePortConflictErrorWithPortNumberInIt() throws Throwable
Map<BoltConnector,NettyServer.ProtocolInitializer> initializersMap = Map<BoltConnector,NettyServer.ProtocolInitializer> initializersMap =
genericMap( new BoltConnector( "test" ), protocolOnAddress( address ) ); genericMap( new BoltConnector( "test" ), protocolOnAddress( address ) );
new NettyServer( new NamedThreadFactory( "mythreads" ), initializersMap, new NettyServer( new NamedThreadFactory( "mythreads" ), initializersMap,
new BoltConnectorRegister() ).start(); new BoltPortRegister() ).start();


} }
} }
Expand Down
Expand Up @@ -34,7 +34,7 @@
import org.neo4j.graphdb.mockfs.EphemeralFileSystemAbstraction; import org.neo4j.graphdb.mockfs.EphemeralFileSystemAbstraction;
import org.neo4j.helpers.HostnamePort; import org.neo4j.helpers.HostnamePort;
import org.neo4j.io.fs.FileSystemAbstraction; import org.neo4j.io.fs.FileSystemAbstraction;
import org.neo4j.kernel.api.bolt.BoltConnectorRegister; import org.neo4j.kernel.api.bolt.BoltPortRegister;
import org.neo4j.kernel.configuration.BoltConnector; import org.neo4j.kernel.configuration.BoltConnector;
import org.neo4j.kernel.internal.GraphDatabaseAPI; import org.neo4j.kernel.internal.GraphDatabaseAPI;
import org.neo4j.test.TestGraphDatabaseFactory; import org.neo4j.test.TestGraphDatabaseFactory;
Expand All @@ -52,7 +52,7 @@ public class Neo4jWithSocket extends ExternalResource
private TestGraphDatabaseFactory graphDatabaseFactory; private TestGraphDatabaseFactory graphDatabaseFactory;
private GraphDatabaseService gdb; private GraphDatabaseService gdb;
private File workingDirectory; private File workingDirectory;
private BoltConnectorRegister connectorRegister; private BoltPortRegister connectorRegister;


public Neo4jWithSocket( Class<?> testClass ) public Neo4jWithSocket( Class<?> testClass )
{ {
Expand Down Expand Up @@ -150,7 +150,7 @@ public void ensureDatabase( Consumer<Map<String,String>> overrideSettingsFunctio
gdb = graphDatabaseFactory.newImpermanentDatabaseBuilder( storeDir ). gdb = graphDatabaseFactory.newImpermanentDatabaseBuilder( storeDir ).
setConfig( settings ).newGraphDatabase(); setConfig( settings ).newGraphDatabase();
connectorRegister = connectorRegister =
((GraphDatabaseAPI) gdb).getDependencyResolver().resolveDependency( BoltConnectorRegister.class ); ((GraphDatabaseAPI) gdb).getDependencyResolver().resolveDependency( BoltPortRegister.class );
} }


private Map<String,String> configure( Consumer<Map<String,String>> overrideSettingsFunction ) throws IOException private Map<String,String> configure( Consumer<Map<String,String>> overrideSettingsFunction ) throws IOException
Expand Down
Expand Up @@ -27,10 +27,10 @@
/** /**
* Connector tracker that keeps information about local address that any configured connector get during bootstrapping. * Connector tracker that keeps information about local address that any configured connector get during bootstrapping.
*/ */
public class BoltConnectorRegister public class BoltPortRegister
{ {


private ConcurrentHashMap<String,HostnamePort> connectorsInfo = new ConcurrentHashMap<>(); private final ConcurrentHashMap<String,HostnamePort> connectorsInfo = new ConcurrentHashMap<>();


public void register( String connectorKey, InetSocketAddress localAddress ) public void register( String connectorKey, InetSocketAddress localAddress )
{ {
Expand Down
Expand Up @@ -32,7 +32,7 @@
import org.neo4j.io.fs.FileSystemLifecycleAdapter; import org.neo4j.io.fs.FileSystemLifecycleAdapter;
import org.neo4j.io.pagecache.PageCache; import org.neo4j.io.pagecache.PageCache;
import org.neo4j.kernel.AvailabilityGuard; import org.neo4j.kernel.AvailabilityGuard;
import org.neo4j.kernel.api.bolt.BoltConnectorRegister; import org.neo4j.kernel.api.bolt.BoltPortRegister;
import org.neo4j.kernel.configuration.Config; import org.neo4j.kernel.configuration.Config;
import org.neo4j.kernel.extension.KernelExtensions; import org.neo4j.kernel.extension.KernelExtensions;
import org.neo4j.kernel.extension.UnsatisfiedDependencyStrategies; import org.neo4j.kernel.extension.UnsatisfiedDependencyStrategies;
Expand Down Expand Up @@ -209,7 +209,7 @@ public PlatformModule( File providedStoreDir, Config config, DatabaseInfo databa
storeCopyCheckPointMutex = new StoreCopyCheckPointMutex(); storeCopyCheckPointMutex = new StoreCopyCheckPointMutex();
dependencies.satisfyDependency( storeCopyCheckPointMutex ); dependencies.satisfyDependency( storeCopyCheckPointMutex );


dependencies.satisfyDependency( new BoltConnectorRegister() ); dependencies.satisfyDependency( new BoltPortRegister() );


publishPlatformInfo( dependencies.resolveDependency( UsageData.class ) ); publishPlatformInfo( dependencies.resolveDependency( UsageData.class ) );
} }
Expand Down
Expand Up @@ -31,7 +31,7 @@
import org.neo4j.helpers.HostnamePort; import org.neo4j.helpers.HostnamePort;
import org.neo4j.io.fs.FileSystemAbstraction; import org.neo4j.io.fs.FileSystemAbstraction;
import org.neo4j.kernel.api.KernelTransaction; import org.neo4j.kernel.api.KernelTransaction;
import org.neo4j.kernel.api.bolt.BoltConnectorRegister; import org.neo4j.kernel.api.bolt.BoltPortRegister;
import org.neo4j.kernel.api.security.AuthenticationResult; import org.neo4j.kernel.api.security.AuthenticationResult;
import org.neo4j.kernel.configuration.BoltConnector; import org.neo4j.kernel.configuration.BoltConnector;
import org.neo4j.kernel.configuration.ssl.LegacySslPolicyConfig; import org.neo4j.kernel.configuration.ssl.LegacySslPolicyConfig;
Expand All @@ -51,7 +51,7 @@ public class EmbeddedInteraction implements NeoInteractionLevel<EnterpriseSecuri
private GraphDatabaseFacade db; private GraphDatabaseFacade db;
private EnterpriseAuthManager authManager; private EnterpriseAuthManager authManager;
private FileSystemAbstraction fileSystem; private FileSystemAbstraction fileSystem;
private BoltConnectorRegister connectorRegister; private BoltPortRegister connectorRegister;


EmbeddedInteraction( Map<String, String> config ) throws Throwable EmbeddedInteraction( Map<String, String> config ) throws Throwable
{ {
Expand Down Expand Up @@ -86,7 +86,7 @@ private void init( GraphDatabaseBuilder builder, Map<String, String> config ) th


db = (GraphDatabaseFacade) builder.newGraphDatabase(); db = (GraphDatabaseFacade) builder.newGraphDatabase();
authManager = db.getDependencyResolver().resolveDependency( EnterpriseAuthManager.class ); authManager = db.getDependencyResolver().resolveDependency( EnterpriseAuthManager.class );
connectorRegister = db.getDependencyResolver().resolveDependency( BoltConnectorRegister.class ); connectorRegister = db.getDependencyResolver().resolveDependency( BoltPortRegister.class );
} }


@Override @Override
Expand Down

0 comments on commit 7d0ebef

Please sign in to comment.