Restore helper method, fix new tests, switch helper method in Iterabl…

…es to use Iterable
neo4j · Jan 21, 2016 · 8974070 · 8974070
1 parent 5e70224
commit 8974070
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/community/collections/src/main/java/org/neo4j/helpers/collection/Iterables.java b/community/collections/src/main/java/org/neo4j/helpers/collection/Iterables.java
@@ -414,7 +414,7 @@ public static <T> Iterator<T> concat( Iterator<? extends T>... iterables )
         return concat( Arrays.asList( (Iterator<T>[]) iterables ).iterator() );
     }
 
-    public static <T> ResourceIterator<T> concatResourceIterators( List<ResourceIterator<T>> iteratorList )
+    public static <T> ResourceIterator<T> concatResourceIterators( Iterable<ResourceIterator<T>> iteratorList )
     {
         return concatResourceIterators( iteratorList.iterator() );
     }

diff --git a/community/kernel/src/main/java/org/neo4j/helpers/Exceptions.java b/community/kernel/src/main/java/org/neo4j/helpers/Exceptions.java
@@ -290,4 +290,23 @@ public static Predicate<StackTraceElement> forMethod( final String name )
     {
         return item -> item.getMethodName().equals( name );
     }
+
+    public static String briefOneLineStackTraceInformation( Predicate<StackTraceElement> toInclude )
+    {
+        StringBuilder builder = new StringBuilder();
+        for ( StackTraceElement element : Thread.currentThread().getStackTrace() )
+        {
+            if ( toInclude.test( element ) )
+            {
+                builder.append( builder.length() > 0 ? "," : "" )
+                        .append( simpleClassName( element.getClassName() ) + "#" + element.getMethodName() );
+            }
+        }
+        return builder.toString();
+    }
+
+    private static String simpleClassName( String className )
+    {
+        return className.substring( className.lastIndexOf( '.' ) );
+    }
 }
diff --git a/community/lucene-index/src/test/java/org/neo4j/graphdb/LuceneLabelScanStoreIT.java b/community/lucene-index/src/test/java/org/neo4j/graphdb/LuceneLabelScanStoreIT.java
@@ -50,7 +50,7 @@ public class LuceneLabelScanStoreIT extends LabelScanStoreIT
     public void scanStoreStartWithoutExistentIndex() throws IOException
     {
         NeoStoreDataSource dataSource = getDataSource();
-        LabelScanStore labelScanStore = dataSource.getLabelScanStore();
+        LabelScanStore labelScanStore = getLabelScanStore();
         labelScanStore.shutdown();
 
         File labelScanStoreDirectory = getLabelScanStoreDirectory( dataSource );
@@ -66,7 +66,7 @@ public void scanStoreStartWithoutExistentIndex() throws IOException
     public void scanStoreRecreateCorruptedIndexOnStartup() throws IOException
     {
         NeoStoreDataSource dataSource = getDataSource();
-        LabelScanStore labelScanStore = dataSource.getLabelScanStore();
+        LabelScanStore labelScanStore = getLabelScanStore();
 
         Node node = createTestNode();
         List<Long> labels = readNodeLabels( labelScanStore, node );
@@ -128,6 +128,12 @@ private NeoStoreDataSource getDataSource()
         return dataSourceManager.getDataSource();
     }
 
+    private LabelScanStore getLabelScanStore()
+    {
+        DependencyResolver dependencyResolver = dbRule.getDependencyResolver();
+        return dependencyResolver.resolveDependency( LabelScanStore.class );
+    }
+
     private void checkLabelScanStoreAccessible( LabelScanStore labelScanStore ) throws IOException
     {
         try ( LabelScanWriter labelScanWriter = labelScanStore.newWriter() )