Skip to content

Commit

Permalink
More code review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
pontusmelke committed Dec 4, 2017
1 parent e99b322 commit b96d856
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
Expand Up @@ -46,8 +46,8 @@ void nodeAddToExplicitIndex( String indexName, long node, String key, Object val
* *
* @param indexName The name of the index * @param indexName The name of the index
* @param node The id of the node to remove * @param node The id of the node to remove
* @param key The key to associate with the node * @param key The key associated with the node
* @param value The value to associate with the node and key * @param value The value associated with the node and key
* @throws ExplicitIndexNotFoundKernelException If there is no explicit index with the given name * @throws ExplicitIndexNotFoundKernelException If there is no explicit index with the given name
*/ */
void nodeRemoveFromExplicitIndex( String indexName, long node, String key, Object value ) void nodeRemoveFromExplicitIndex( String indexName, long node, String key, Object value )
Expand All @@ -58,7 +58,7 @@ void nodeRemoveFromExplicitIndex( String indexName, long node, String key, Objec
* *
* @param indexName The name of the index * @param indexName The name of the index
* @param node The id of the node to remove * @param node The id of the node to remove
* @param key The key to associate with the node * @param key The key associated with the node
* @throws ExplicitIndexNotFoundKernelException If there is no explicit index with the given name * @throws ExplicitIndexNotFoundKernelException If there is no explicit index with the given name
*/ */
void nodeRemoveFromExplicitIndex( String indexName, long node, String key ) throws void nodeRemoveFromExplicitIndex( String indexName, long node, String key ) throws
Expand Down Expand Up @@ -90,8 +90,8 @@ void relationshipAddToExplicitIndex( String indexName, long relationship, String
* *
* @param indexName The name of the index * @param indexName The name of the index
* @param relationship The id of the relationship to remove * @param relationship The id of the relationship to remove
* @param key The key to associate with the relationship * @param key The key associated with the relationship
* @param value The value to associate with the relationship and key * @param value The value associated with the relationship and key
* @throws ExplicitIndexNotFoundKernelException If there is no explicit index with the given name * @throws ExplicitIndexNotFoundKernelException If there is no explicit index with the given name
*/ */
void relationshipRemoveFromExplicitIndex( String indexName, long relationship, String key, Object value ) void relationshipRemoveFromExplicitIndex( String indexName, long relationship, String key, Object value )
Expand All @@ -102,7 +102,7 @@ void relationshipRemoveFromExplicitIndex( String indexName, long relationship, S
* *
* @param indexName The name of the index * @param indexName The name of the index
* @param relationship The id of the relationship to remove * @param relationship The id of the relationship to remove
* @param key The key to associate with the relationship * @param key The key associated with the relationship
* @throws ExplicitIndexNotFoundKernelException If there is no explicit index with the given name * @throws ExplicitIndexNotFoundKernelException If there is no explicit index with the given name
*/ */
void relationshipRemoveFromExplicitIndex( String indexName, long relationship, String key ) void relationshipRemoveFromExplicitIndex( String indexName, long relationship, String key )
Expand Down
Expand Up @@ -146,24 +146,24 @@ static boolean hasDirectFlag( long groupReference )
* *
* This allows us to encode a node reference as a property reference so that we can do lookups of changes in the * This allows us to encode a node reference as a property reference so that we can do lookups of changes in the
* transaction state. * transaction state.
* @param reference the reference to encode * @param nodeReference the reference to encode
* @return The encoded reference * @return The encoded reference
*/ */
static long setNodeFlag( long reference ) static long setNodeFlag( long nodeReference )
{ {
return reference | NODE_MARKER | FLAG_MARKER; return nodeReference | NODE_MARKER | FLAG_MARKER;
} }


/** /**
* Checks if the property reference really is a node reference * Checks if the property reference really is a node reference
* *
* @param nodeReference The reference to check * @param reference The reference to check
* @return <tt>true</tt>if the reference refers to a node otherwise <tt>false</tt> * @return <tt>true</tt>if the reference refers to a node otherwise <tt>false</tt>
*/ */
static boolean hasNodeFlag( long nodeReference ) static boolean hasNodeFlag( long reference )
{ {
assert nodeReference != NO_ID; assert reference != NO_ID;
return (nodeReference & NODE_MARKER) != 0L; return (reference & NODE_MARKER) != 0L;
} }


/** /**
Expand Down

0 comments on commit b96d856

Please sign in to comment.