Change error handler to be an executor. Keep throw on close logic

neo4j · Sep 10, 2018 · c560a45 · c560a45
1 parent 2cde460
commit c560a45
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 41 deletions.
diff --git a/...g/src/main/java/org/neo4j/causalclustering/core/state/machines/tx/ChunkedTransaction.java b/...g/src/main/java/org/neo4j/causalclustering/core/state/machines/tx/ChunkedTransaction.java
@@ -60,29 +60,9 @@ public void close()
         {
             if ( channel != null )
             {
-                try
+                errorHandler.execute( () -> channel.close() );
-                {
-                    channel.close();
-                }
-                catch ( Throwable t )
-                {
-                    errorHandler.add( t );
-                }
-            }
-            if ( !chunks.isEmpty() )
-            {
-                for ( ByteBuf byteBuf : chunks )
-                {
-                    try
-                    {
-                        ReferenceCountUtil.release( byteBuf );
-                    }
-                    catch ( Throwable t )
-                    {
-                        errorHandler.add( t );
-                    }
-                }
             }
+            chunks.forEach( byteBuf -> errorHandler.execute( () -> ReferenceCountUtil.release( byteBuf ) ) );
         }
     }
 

diff --git a/...prise/causal-clustering/src/main/java/org/neo4j/causalclustering/helper/ErrorHandler.java b/...prise/causal-clustering/src/main/java/org/neo4j/causalclustering/helper/ErrorHandler.java
@@ -44,14 +44,7 @@ public static void runAll( String description, ThrowingRunnable... actions ) thr
         {
             for ( ThrowingRunnable action : actions )
             {
-                try
+                errorHandler.execute( action );
-                {
-                    action.run();
-                }
-                catch ( Throwable e )
-                {
-                    errorHandler.add( e );
-                }
             }
         }
     }
@@ -61,6 +54,18 @@ public ErrorHandler( String message )
         this.message = message;
     }
 
+    public void execute( ThrowingRunnable throwingRunnable )
+    {
+        try
+        {
+            throwingRunnable.run();
+        }
+        catch ( Throwable e )
+        {
+            throwables.add( e );
+        }
+    }
+
     public void add( Throwable throwable )
     {
         throwables.add( throwable );

diff --git a/enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/discovery/Cluster.java b/enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/discovery/Cluster.java
@@ -264,18 +264,11 @@ public static void shutdownCoreMembers( Collection<CoreClusterMember> members )
     @SuppressWarnings( "unchecked" )
     private static void shutdownMembers( Collection<? extends ClusterMember> clusterMembers, ErrorHandler errorHandler )
     {
-        try
+        errorHandler.execute( () -> combine( invokeAll( "cluster-shutdown", clusterMembers, cm ->
         {
-            combine( invokeAll( "cluster-shutdown", clusterMembers, cm ->
+            cm.shutdown();
-            {
+            return null;
-                cm.shutdown();
+        } ) ).get() );
-                return null;
-            } ) ).get();
-        }
-        catch ( Exception e )
-        {
-            errorHandler.add( e );
-        }
     }
 
     private static <X extends GraphDatabaseAPI, T extends ClusterMember<X>, R> List<Future<R>> invokeAll( String threadName, Collection<T> members,