Cleanup based on review comments

community/bolt/src/test/java/org/neo4j/bolt/v1/runtime/CypherAdapterStreamTest.java

@@ -21,7 +21,6 @@
 
 import org.junit.Test;
 
-import org.neo4j.bolt.v1.runtime.CypherAdapterStream;
 import org.neo4j.bolt.v1.runtime.spi.Record;
 import org.neo4j.bolt.v1.runtime.spi.BoltResult;
 import org.neo4j.graphdb.ExecutionPlanDescription;

community/cypher/cypher/src/test/java/org/neo4j/cypher/internal/javacompat/ExecutionEngineTests.java

@@ -34,9 +34,9 @@
 import org.neo4j.kernel.impl.coreapi.InternalTransaction;
 import org.neo4j.kernel.impl.coreapi.PropertyContainerLocker;
 import org.neo4j.kernel.impl.query.Neo4jTransactionalContextFactory;
-import org.neo4j.kernel.impl.query.QueryEngineProvider;
 import org.neo4j.kernel.impl.query.TransactionalContext;
 import org.neo4j.kernel.impl.query.TransactionalContextFactory;
+import org.neo4j.kernel.impl.query.clientconnection.ClientConnectionInfo;
 import org.neo4j.logging.NullLogProvider;
 import org.neo4j.test.rule.DatabaseRule;
 import org.neo4j.test.rule.ImpermanentDatabaseRule;
@@ -79,6 +79,6 @@ private TransactionalContext createTransactionContext( GraphDatabaseQueryService
     {
         PropertyContainerLocker locker = new PropertyContainerLocker();
         TransactionalContextFactory contextFactory = Neo4jTransactionalContextFactory.create( graph, locker );
-        return contextFactory.newContext( QueryEngineProvider.describe(), tx, query, Collections.emptyMap() );
+        return contextFactory.newContext( ClientConnectionInfo.EMBEDDED_CONNECTION, tx, query, Collections.emptyMap() );
     }
 }

community/kernel/src/main/java/org/neo4j/kernel/impl/factory/GraphDatabaseFacade.java

@@ -92,9 +92,9 @@
 import org.neo4j.kernel.impl.coreapi.TopLevelTransaction;
 import org.neo4j.kernel.impl.coreapi.schema.SchemaImpl;
 import org.neo4j.kernel.impl.query.Neo4jTransactionalContextFactory;
-import org.neo4j.kernel.impl.query.QueryEngineProvider;
 import org.neo4j.kernel.impl.query.TransactionalContext;
 import org.neo4j.kernel.impl.query.TransactionalContextFactory;
+import org.neo4j.kernel.impl.query.clientconnection.ClientConnectionInfo;
 import org.neo4j.kernel.impl.store.StoreId;
 import org.neo4j.kernel.impl.traversal.BidirectionalTraversalDescriptionImpl;
 import org.neo4j.kernel.impl.traversal.MonoDirectionalTraversalDescription;
@@ -422,7 +422,7 @@ public Result execute( InternalTransaction transaction, String query, Map<String
             throws QueryExecutionException
     {
         TransactionalContext context =
-                contextFactory.newContext( QueryEngineProvider.describe(), transaction, query, parameters );
+                contextFactory.newContext( ClientConnectionInfo.EMBEDDED_CONNECTION, transaction, query, parameters );
         return spi.executeQuery( query, parameters, context );
     }
 

community/kernel/src/main/java/org/neo4j/kernel/impl/query/QueryEngineProvider.java

@@ -20,7 +20,6 @@
 package org.neo4j.kernel.impl.query;
 
 import org.neo4j.helpers.Service;
-import org.neo4j.kernel.impl.query.clientconnection.ClientConnectionInfo;
 import org.neo4j.kernel.impl.util.Dependencies;
 import org.neo4j.kernel.internal.GraphDatabaseAPI;
 
@@ -60,9 +59,4 @@ public static QueryExecutionEngine noEngine()
     {
         return NoQueryEngine.INSTANCE;
     }
-
-    public static ClientConnectionInfo describe()
-    {
-        return ClientConnectionInfo.EMBEDDED_CONNECTION;
-    }
 }

community/kernel/src/main/java/org/neo4j/kernel/impl/query/clientconnection/BoltConnectionInfo.java

@@ -22,6 +22,9 @@
 import java.net.InetSocketAddress;
 import java.net.SocketAddress;
 
+/**
+ * @see ClientConnectionInfo Parent class for documentation and tests.
+ */
 public class BoltConnectionInfo extends ClientConnectionInfo
 {
     private final String principalName;

community/kernel/src/main/java/org/neo4j/kernel/impl/query/clientconnection/ClientConnectionInfo.java

@@ -19,6 +19,11 @@
  */
 package org.neo4j.kernel.impl.query.clientconnection;
 
+/**
+ * This is implemented as an abstract class in order to support different formatting for {@link #asConnectionDetails()},
+ * when this method is no longer needed, and we move to a standardized format across all types of connections, we can
+ * turn this class into a simpler value type that just holds the fields that are actually used.
+ */
 public abstract class ClientConnectionInfo
 {
     /**
@@ -31,19 +36,42 @@ public ClientConnectionInfo withUsername( String username )
         return new ConnectionInfoWithUsername( this, username );
     }
 
+    /**
+     * This method provides the custom format for each type of connection.
+     * <p>
+     * Preferably we would not need to have a custom format for each type of connection, but this is provided for
+     * backwards compatibility reasons.
+     *
+     * @return a custom log-line format describing this type of connection.
+     */
     @Deprecated
     public abstract String asConnectionDetails();
 
+    /**
+     * This method is overridden in the subclasses where this information is available.
+     *
+     * @return the scheme used for connecting to the server, or {@code null} if no scheme is available.
+     */
     public String requestScheme()
     {
         return null;
     }
 
+    /**
+     * This method is overridden in the subclasses where this information is available.
+     *
+     * @return the address of the client. or {@code null} if the address is not available.
+     */
     public String clientAddress()
     {
         return null;
     }
 
+    /**
+     * This method is overridden in the subclasses where this information is available.
+     *
+     * @return the URI of this server that the client connected to, or {@code null} if the URI is not available.
+     */
     public String requestURI()
     {
         return null;
@@ -58,6 +86,9 @@ public String asConnectionDetails()
         }
     };
 
+    /**
+     * Should be removed along with {@link #withUsername(String)} and {@link #asConnectionDetails()}.
+     */
     @Deprecated
     private static class ConnectionInfoWithUsername extends ClientConnectionInfo
     {

community/kernel/src/main/java/org/neo4j/kernel/impl/query/clientconnection/HttpConnectionInfo.java

@@ -21,6 +21,9 @@
 
 import java.net.InetSocketAddress;
 
+/**
+ * @see ClientConnectionInfo Parent class for documentation and tests.
+ */
 public class HttpConnectionInfo extends ClientConnectionInfo
 {
     private final String scheme;

community/kernel/src/main/java/org/neo4j/kernel/impl/query/clientconnection/ShellConnectionInfo.java

@@ -21,6 +21,9 @@
 
 import java.io.Serializable;
 
+/**
+ * @see ClientConnectionInfo Parent class for documentation and tests.
+ */
 public class ShellConnectionInfo extends ClientConnectionInfo
 {
     private final Serializable id;

community/server/src/main/java/org/neo4j/server/database/CypherExecutor.java

@@ -36,7 +36,7 @@
 import org.neo4j.kernel.impl.query.TransactionalContextFactory;
 import org.neo4j.kernel.lifecycle.LifecycleAdapter;
 import org.neo4j.logging.LogProvider;
-import org.neo4j.server.rest.web.ServerQuerySession;
+import org.neo4j.server.rest.web.HttpConnectionInfoFactory;
 
 import org.neo4j.logging.Log;
 
@@ -84,7 +84,7 @@ public TransactionalContext createTransactionContext( String query, Map<String,
             HttpServletRequest request )
     {
         InternalTransaction tx = getInternalTransaction( request );
-        return contextFactory.newContext( ServerQuerySession.describe( request ), tx, query, parameters );
+        return contextFactory.newContext( HttpConnectionInfoFactory.create( request ), tx, query, parameters );
     }
 
     private InternalTransaction getInternalTransaction( HttpServletRequest request )

community/server/src/main/java/org/neo4j/server/rest/transactional/TransitionalPeriodTransactionMessContainer.java

@@ -33,7 +33,7 @@
 import org.neo4j.kernel.impl.query.clientconnection.ClientConnectionInfo;
 import org.neo4j.kernel.impl.query.TransactionalContext;
 import org.neo4j.kernel.impl.query.TransactionalContextFactory;
-import org.neo4j.server.rest.web.ServerQuerySession;
+import org.neo4j.server.rest.web.HttpConnectionInfoFactory;
 
 public class TransitionalPeriodTransactionMessContainer
 {
@@ -68,7 +68,7 @@ public TransactionalContext create(
             Map<String, Object> queryParameters)
     {
         TransactionalContextFactory contextFactory = Neo4jTransactionalContextFactory.create( service, locker );
-        ClientConnectionInfo clientConnection = ServerQuerySession.describe( request );
+        ClientConnectionInfo clientConnection = HttpConnectionInfoFactory.create( request );
         InternalTransaction transaction = service.beginTransaction( type, securityContext );
         return contextFactory.newContext( clientConnection, transaction, query, queryParameters );
     }

community/server/src/main/java/org/neo4j/server/rest/web/ServerQuerySession.java → community/server/src/main/java/org/neo4j/server/rest/web/HttpConnectionInfoFactory.java

@@ -27,9 +27,9 @@
 
 import static javax.ws.rs.core.HttpHeaders.USER_AGENT;
 
-public class ServerQuerySession
+public class HttpConnectionInfoFactory
 {
-    public static ClientConnectionInfo describe( HttpServletRequest request )
+    public static ClientConnectionInfo create( HttpServletRequest request )
     {
         return new HttpConnectionInfo(
                 request.getScheme(),

community/shell/src/main/java/org/neo4j/shell/kernel/apps/cypher/Start.java

@@ -35,7 +35,6 @@
 import org.neo4j.kernel.impl.query.Neo4jTransactionalContextFactory;
 import org.neo4j.kernel.impl.query.QueryExecutionEngine;
 import org.neo4j.kernel.impl.query.QueryExecutionKernelException;
-import org.neo4j.kernel.impl.query.clientconnection.ClientConnectionInfo;
 import org.neo4j.kernel.impl.query.TransactionalContext;
 import org.neo4j.kernel.impl.query.TransactionalContextFactory;
 import org.neo4j.kernel.impl.query.clientconnection.ShellConnectionInfo;
@@ -200,18 +199,10 @@ private TransactionalContext createTransactionContext( String queryText, Map<Str
         InternalTransaction transaction =
             graph.beginTransaction( KernelTransaction.Type.implicit, SecurityContext.AUTH_DISABLED );
         return contextFactory.newContext(
-            ShellQuerySession.describe( session ),
+            new ShellConnectionInfo( session.getId() ),
             transaction,
             queryText,
             queryParameters
         );
     }
-
-    private static class ShellQuerySession
-    {
-        public static ClientConnectionInfo describe( Session session )
-        {
-            return new ShellConnectionInfo( session.getId() );
-        }
-    }
 }

enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/ListQueriesProcedureTest.java

@@ -144,7 +144,7 @@ public void shouldContainSpecificConnectionDetails() throws Exception
         // then
         assertThat( data, hasKey( "requestScheme" ) );
         assertThat( data, hasKey( "clientAddress" ) );
-        assertThat( data, hasKey( "requestURI" ) );
+        assertThat( data, hasKey( "requestUri" ) );
     }
 
     private Map<String,Object> getQueryListing( String query )

enterprise/query-logging/src/test/java/org/neo4j/kernel/impl/query/QueryLoggerIT.java

@@ -49,6 +49,7 @@
 import org.neo4j.kernel.enterprise.api.security.EnterpriseSecurityContext;
 import org.neo4j.kernel.impl.coreapi.InternalTransaction;
 import org.neo4j.kernel.impl.factory.GraphDatabaseFacade;
+import org.neo4j.kernel.impl.query.clientconnection.ClientConnectionInfo;
 import org.neo4j.logging.AssertableLogProvider;
 import org.neo4j.server.security.enterprise.auth.EmbeddedInteraction;
 import org.neo4j.test.TestEnterpriseGraphDatabaseFactory;
@@ -226,7 +227,7 @@ public void shouldLogParametersWhenNestedMap() throws Exception
 
     private String clientConnectionInfo()
     {
-        return QueryEngineProvider.describe().withUsername( AUTH_DISABLED.username() ).asConnectionDetails();
+        return ClientConnectionInfo.EMBEDDED_CONNECTION.withUsername( AUTH_DISABLED.username() ).asConnectionDetails();
     }
 
     @Test