minor review fixes

neo4j · Dec 28, 2018 · e66f25a · e66f25a
1 parent c73e3a7
commit e66f25a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...nity-it/cypher-it/src/test/scala/org/neo4j/internal/collector/DataCollectorMatchers.scala b/...nity-it/cypher-it/src/test/scala/org/neo4j/internal/collector/DataCollectorMatchers.scala
@@ -244,7 +244,7 @@ object DataCollectorMatchers {
           case _ => false
         },
         rawFailureMessage = s"'$left' is not the same Cypher as '$expected'",
-        rawNegatedFailureMessage = "")
+        rawNegatedFailureMessage = s"'$left' is unexpectedly the same Cypher as '$expected'")
 
     override def toString(): String = s"cypher string `$expected`"
   }

diff --git a/community/data-collector/src/main/java/org/neo4j/internal/collector/QueryCollector.java b/community/data-collector/src/main/java/org/neo4j/internal/collector/QueryCollector.java
@@ -39,12 +39,12 @@
  */
 class QueryCollector extends CollectorStateMachine<Iterator<QuerySnapshot>> implements QueryExecutionMonitor
 {
-    private volatile boolean on;
+    private volatile boolean isCollecting;
     private final ConcurrentLinkedQueue<QuerySnapshot> queries;
 
     QueryCollector()
     {
-        on = false;
+        isCollecting = false;
         queries = new ConcurrentLinkedQueue<>();
     }
 
@@ -53,14 +53,14 @@ class QueryCollector extends CollectorStateMachine<Iterator<QuerySnapshot>> impl
     @Override
     Result doCollect()
     {
-        on = true;
+        isCollecting = true;
         return success( "Collection started." );
     }
 
     @Override
     Result doStop()
     {
-        on = false;
+        isCollecting = false;
         return success( "Collection stopped." );
     }
 
@@ -87,7 +87,7 @@ public void endFailure( ExecutingQuery query, Throwable failure )
     @Override
     public void endSuccess( ExecutingQuery query )
     {
-        if ( on )
+        if ( isCollecting )
         {
             queries.add( query.snapshot() );
         }