Review comments: renaming, private constructor.

neo4j · Aug 30, 2018 · efcdebd · efcdebd
1 parent 90ce5a4
commit efcdebd
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 8 deletions.
diff --git a/community/community-it/kernel-it/src/test/java/org/neo4j/graphdb/LabelsAcceptanceTest.java b/community/community-it/kernel-it/src/test/java/org/neo4j/graphdb/LabelsAcceptanceTest.java
@@ -750,7 +750,7 @@ protected void create(
                                     GraphDatabaseFacadeFactory.Dependencies dependencies )
                             {
                                 Function<PlatformModule,EditionModule> factory =
-                                        platformModule -> new CommunityEditionModuleWithCustomIdModule( platformModule, idFactory );
+                                        platformModule -> new CommunityEditionModuleWithCustomIdContextFactory( platformModule, idFactory );
                                 new GraphDatabaseFacadeFactory( DatabaseInfo.COMMUNITY, factory )
                                 {
 
@@ -780,9 +780,9 @@ private Node createNode( GraphDatabaseService db, Label... labels )
         }
     }
 
-    private static class CommunityEditionModuleWithCustomIdModule extends CommunityEditionModule
+    private static class CommunityEditionModuleWithCustomIdContextFactory extends CommunityEditionModule
     {
-        CommunityEditionModuleWithCustomIdModule( PlatformModule platformModule, EphemeralIdGenerator.Factory idFactory )
+        CommunityEditionModuleWithCustomIdContextFactory( PlatformModule platformModule, EphemeralIdGenerator.Factory idFactory )
         {
             super( platformModule );
             idContextFactory = IdContextFactoryBuilder.of( platformModule.fileSystem, platformModule.jobScheduler )

diff --git a/community/neo4j/src/main/java/org/neo4j/graphdb/factory/module/CommunityEditionModule.java b/community/neo4j/src/main/java/org/neo4j/graphdb/factory/module/CommunityEditionModule.java
@@ -101,7 +101,7 @@ public CommunityEditionModule( PlatformModule platformModule )
         threadToTransactionBridge = dependencies.satisfyDependency(
                 new ThreadToStatementContextBridge( getGlobalAvailabilityGuard( platformModule.clock, logging, platformModule.config ) ) );
 
-        idContextFactory = createIdModule( platformModule, fileSystem );
+        idContextFactory = createIdContextFactory( platformModule, fileSystem );
 
         tokenHoldersSupplier = () -> new TokenHolders(
                 new DelegatingTokenHolder( createPropertyKeyCreator( config, dataSourceManager ), TokenHolder.TYPE_PROPERTY_KEY ),
@@ -128,7 +128,7 @@ public CommunityEditionModule( PlatformModule platformModule )
         publishEditionInfo( dependencies.resolveDependency( UsageData.class ), platformModule.databaseInfo, config );
     }
 
-    protected IdContextFactory createIdModule( PlatformModule platformModule, FileSystemAbstraction fileSystem )
+    protected IdContextFactory createIdContextFactory( PlatformModule platformModule, FileSystemAbstraction fileSystem )
     {
         return IdContextFactoryBuilder.of( fileSystem, platformModule.jobScheduler ).build();
     }

diff --git a/...nity/neo4j/src/main/java/org/neo4j/graphdb/factory/module/id/IdContextFactoryBuilder.java b/...nity/neo4j/src/main/java/org/neo4j/graphdb/factory/module/id/IdContextFactoryBuilder.java
@@ -41,6 +41,10 @@ public class IdContextFactoryBuilder
     private IdTypeConfigurationProvider idTypeConfigurationProvider;
     private Function<IdGeneratorFactory,IdGeneratorFactory> factoryWrapper;
 
+    private IdContextFactoryBuilder()
+    {
+    }
+
     public static IdContextFactoryBuilder of( IdTypeConfigurationProvider configurationProvider, JobScheduler jobScheduler )
     {
         IdContextFactoryBuilder builder = new IdContextFactoryBuilder();

diff --git a/...clustering/src/main/java/org/neo4j/causalclustering/core/EnterpriseCoreEditionModule.java b/...clustering/src/main/java/org/neo4j/causalclustering/core/EnterpriseCoreEditionModule.java
@@ -305,7 +305,7 @@ public EnterpriseCoreEditionModule( final PlatformModule platformModule,
                 consensusModule.raftMachine(), dependencies, localDatabase );
 
         idContextFactory = IdContextFactoryBuilder.of( coreStateMachinesModule.idTypeConfigurationProvider, platformModule.jobScheduler )
-                .withIdGenerationFactoryProvider( databaseName -> coreStateMachinesModule.idGeneratorFactory )
+                .withIdGenerationFactoryProvider( ignored -> coreStateMachinesModule.idGeneratorFactory )
                 .withFactoryWrapper( generator -> new FreeIdFilteredIdGeneratorFactory( generator, coreStateMachinesModule.freeIdCondition ) ).build();
 
         // TODO: this is broken, coreStateMachinesModule.tokenHolders should be supplier, somehow...

diff --git a/...rprise/kernel/src/main/java/org/neo4j/kernel/impl/enterprise/EnterpriseEditionModule.java b/...rprise/kernel/src/main/java/org/neo4j/kernel/impl/enterprise/EnterpriseEditionModule.java
@@ -74,7 +74,7 @@ public EnterpriseEditionModule( PlatformModule platformModule )
     }
 
     @Override
-    protected IdContextFactory createIdModule( PlatformModule platformModule, FileSystemAbstraction fileSystem )
+    protected IdContextFactory createIdContextFactory( PlatformModule platformModule, FileSystemAbstraction fileSystem )
     {
         return IdContextFactoryBuilder.of( new EnterpriseIdTypeConfigurationProvider( platformModule.config ), platformModule.jobScheduler )
                 .withFileSystem( fileSystem )

diff --git a/integrationtests/src/test/java/org/neo4j/TransactionGuardIT.java b/integrationtests/src/test/java/org/neo4j/TransactionGuardIT.java
@@ -724,7 +724,7 @@ private class TransactionGuardTerminationEditionModule extends EnterpriseEdition
         }
 
         @Override
-        protected IdContextFactory createIdModule( PlatformModule platformModule, FileSystemAbstraction fileSystem )
+        protected IdContextFactory createIdContextFactory( PlatformModule platformModule, FileSystemAbstraction fileSystem )
         {
             return IdContextFactoryBuilder.of( new EnterpriseIdTypeConfigurationProvider( platformModule.config ),
                     platformModule.jobScheduler )