Skip to content

Commit

Permalink
Rename BotKernelExtension to BoltServer
Browse files Browse the repository at this point in the history
  • Loading branch information
lutovich committed Jun 18, 2018
1 parent a13b8a6 commit f83790d
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 19 deletions.
Expand Up @@ -74,7 +74,7 @@
import static org.neo4j.kernel.configuration.ssl.LegacySslPolicyConfig.LEGACY_POLICY_NAME; import static org.neo4j.kernel.configuration.ssl.LegacySslPolicyConfig.LEGACY_POLICY_NAME;
import static org.neo4j.scheduler.JobScheduler.Groups.boltNetworkIO; import static org.neo4j.scheduler.JobScheduler.Groups.boltNetworkIO;


public class BoltKernelExtension extends LifecycleAdapter public class BoltServer extends LifecycleAdapter
{ {
// platform dependencies // platform dependencies
private final GraphDatabaseAPI db; private final GraphDatabaseAPI db;
Expand All @@ -99,7 +99,7 @@ public static class Settings implements LoadableConfig
public static final Setting<String> ssl_policy = setting( "bolt.ssl_policy", STRING, LEGACY_POLICY_NAME ); public static final Setting<String> ssl_policy = setting( "bolt.ssl_policy", STRING, LEGACY_POLICY_NAME );
} }


public BoltKernelExtension( GraphDatabaseAPI db, FileSystemAbstraction fs, JobScheduler jobScheduler, AvailabilityGuard availabilityGuard, public BoltServer( GraphDatabaseAPI db, FileSystemAbstraction fs, JobScheduler jobScheduler, AvailabilityGuard availabilityGuard,
ConnectorPortRegister connectorPortRegister, UsageData usageData, Config config, Clock clock, Monitors monitors, ConnectorPortRegister connectorPortRegister, UsageData usageData, Config config, Clock clock, Monitors monitors,
LogService logService, DependencyResolver dependencyResolver ) LogService logService, DependencyResolver dependencyResolver )
{ {
Expand All @@ -119,8 +119,8 @@ public BoltKernelExtension( GraphDatabaseAPI db, FileSystemAbstraction fs, JobSc
@Override @Override
public void start() throws Throwable public void start() throws Throwable
{ {
Log log = logService.getInternalLog( BoltKernelExtension.class ); Log log = logService.getInternalLog( BoltServer.class );
Log userLog = logService.getUserLog( BoltKernelExtension.class ); Log userLog = logService.getUserLog( BoltServer.class );


InternalLoggerFactory.setDefaultFactory( new Netty4LoggerFactory( logService.getInternalLogProvider() ) ); InternalLoggerFactory.setDefaultFactory( new Netty4LoggerFactory( logService.getInternalLogProvider() ) );
BoltMessageLogging boltLogging = BoltMessageLogging.create( fs, jobScheduler, config, log ); BoltMessageLogging boltLogging = BoltMessageLogging.create( fs, jobScheduler, config, log );
Expand Down
Expand Up @@ -30,7 +30,7 @@
import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicBoolean;


import org.neo4j.bolt.BoltChannel; import org.neo4j.bolt.BoltChannel;
import org.neo4j.bolt.BoltKernelExtension; import org.neo4j.bolt.BoltServer;
import org.neo4j.bolt.v1.packstream.PackOutput; import org.neo4j.bolt.v1.packstream.PackOutput;
import org.neo4j.bolt.v1.runtime.BoltConnectionAuthFatality; import org.neo4j.bolt.v1.runtime.BoltConnectionAuthFatality;
import org.neo4j.bolt.v1.runtime.BoltProtocolBreachFatality; import org.neo4j.bolt.v1.runtime.BoltProtocolBreachFatality;
Expand All @@ -46,7 +46,7 @@


public class DefaultBoltConnection implements BoltConnection public class DefaultBoltConnection implements BoltConnection
{ {
protected static final int DEFAULT_MAX_BATCH_SIZE = FeatureToggles.getInteger( BoltKernelExtension.class, "max_batch_size", 100 ); protected static final int DEFAULT_MAX_BATCH_SIZE = FeatureToggles.getInteger( BoltServer.class, "max_batch_size", 100 );


private final String id; private final String id;


Expand Down
@@ -1 +1 @@
org.neo4j.bolt.BoltKernelExtension$Settings org.neo4j.bolt.BoltServer$Settings
Expand Up @@ -30,7 +30,7 @@
import java.util.concurrent.Future; import java.util.concurrent.Future;


import org.neo4j.bolt.BoltChannel; import org.neo4j.bolt.BoltChannel;
import org.neo4j.bolt.BoltKernelExtension; import org.neo4j.bolt.BoltServer;
import org.neo4j.bolt.logging.BoltMessageLogger; import org.neo4j.bolt.logging.BoltMessageLogger;
import org.neo4j.bolt.logging.NullBoltMessageLogger; import org.neo4j.bolt.logging.NullBoltMessageLogger;
import org.neo4j.bolt.testing.Jobs; import org.neo4j.bolt.testing.Jobs;
Expand Down Expand Up @@ -278,7 +278,7 @@ public void processNextBatchShouldCloseConnectionOnFatalAuthenticationError()
connection.processNextBatch(); connection.processNextBatch();


verify( stateMachine ).close(); verify( stateMachine ).close();
logProvider.assertNone( AssertableLogProvider.inLog( containsString( BoltKernelExtension.class.getPackage().getName() ) ).error( any( String.class ), logProvider.assertNone( AssertableLogProvider.inLog( containsString( BoltServer.class.getPackage().getName() ) ).error( any( String.class ),
any( Throwable.class ) ) ); any( Throwable.class ) ) );
} }


Expand All @@ -296,7 +296,7 @@ public void processNextBatchShouldCloseConnectionAndLogOnFatalBoltError()
connection.processNextBatch(); connection.processNextBatch();


verify( stateMachine ).close(); verify( stateMachine ).close();
logProvider.assertExactly( AssertableLogProvider.inLog( containsString( BoltKernelExtension.class.getPackage().getName() ) ).error( logProvider.assertExactly( AssertableLogProvider.inLog( containsString( BoltServer.class.getPackage().getName() ) ).error(
containsString( "Protocol breach detected in bolt session" ), is( exception ) ) ); containsString( "Protocol breach detected in bolt session" ), is( exception ) ) );
} }


Expand All @@ -314,7 +314,7 @@ public void processNextBatchShouldCloseConnectionAndLogOnUnexpectedException()
connection.processNextBatch(); connection.processNextBatch();


verify( stateMachine ).close(); verify( stateMachine ).close();
logProvider.assertExactly( AssertableLogProvider.inLog( containsString( BoltKernelExtension.class.getPackage().getName() ) ).error( logProvider.assertExactly( AssertableLogProvider.inLog( containsString( BoltServer.class.getPackage().getName() ) ).error(
containsString( "Unexpected error detected in bolt session" ), is( exception ) ) ); containsString( "Unexpected error detected in bolt session" ), is( exception ) ) );
} }


Expand Down
Expand Up @@ -34,7 +34,7 @@
import java.util.concurrent.atomic.AtomicInteger; import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference; import java.util.concurrent.atomic.AtomicReference;


import org.neo4j.bolt.BoltKernelExtension; import org.neo4j.bolt.BoltServer;
import org.neo4j.bolt.testing.Jobs; import org.neo4j.bolt.testing.Jobs;
import org.neo4j.function.Predicates; import org.neo4j.function.Predicates;
import org.neo4j.kernel.configuration.Config; import org.neo4j.kernel.configuration.Config;
Expand Down Expand Up @@ -203,7 +203,7 @@ public void failingJobShouldLogAndStopConnection() throws Throwable
verify( connection ).processNextBatch(); verify( connection ).processNextBatch();
verify( connection ).stop(); verify( connection ).stop();


logProvider.assertExactly( AssertableLogProvider.inLog( containsString( BoltKernelExtension.class.getPackage().getName() ) ).error( logProvider.assertExactly( AssertableLogProvider.inLog( containsString( BoltServer.class.getPackage().getName() ) ).error(
containsString( "Unexpected error during job scheduling for session" ), containsString( "Unexpected error during job scheduling for session" ),
matchesExceptionMessage( containsString( "some unexpected error" ) ) ) ); matchesExceptionMessage( containsString( "some unexpected error" ) ) ) );
} }
Expand Down
Expand Up @@ -25,7 +25,7 @@
import java.util.function.Function; import java.util.function.Function;
import java.util.function.Supplier; import java.util.function.Supplier;


import org.neo4j.bolt.BoltKernelExtension; import org.neo4j.bolt.BoltServer;
import org.neo4j.graphdb.DependencyResolver; import org.neo4j.graphdb.DependencyResolver;
import org.neo4j.graphdb.Node; import org.neo4j.graphdb.Node;
import org.neo4j.graphdb.Path; import org.neo4j.graphdb.Path;
Expand Down Expand Up @@ -349,9 +349,9 @@ private static Procedures setupProcedures( PlatformModule platform, EditionModul
return procedures; return procedures;
} }


private static BoltKernelExtension createBoltServer( PlatformModule platform ) private static BoltServer createBoltServer( PlatformModule platform )
{ {
return new BoltKernelExtension( platform.graphDatabaseFacade, platform.fileSystem, platform.jobScheduler, platform.availabilityGuard, return new BoltServer( platform.graphDatabaseFacade, platform.fileSystem, platform.jobScheduler, platform.availabilityGuard,
platform.connectorPortRegister, platform.usageData, platform.config, platform.clock, platform.monitors, platform.logging, platform.connectorPortRegister, platform.usageData, platform.config, platform.clock, platform.monitors, platform.logging,
platform.dependencies ); platform.dependencies );
} }
Expand Down
Expand Up @@ -33,7 +33,7 @@
import java.io.Serializable; import java.io.Serializable;
import java.rmi.RemoteException; import java.rmi.RemoteException;


import org.neo4j.bolt.BoltKernelExtension; import org.neo4j.bolt.BoltServer;
import org.neo4j.graphdb.Result; import org.neo4j.graphdb.Result;
import org.neo4j.graphdb.Transaction; import org.neo4j.graphdb.Transaction;
import org.neo4j.logging.AssertableLogProvider; import org.neo4j.logging.AssertableLogProvider;
Expand Down Expand Up @@ -216,7 +216,7 @@ protected GraphDatabaseShellServer getGraphDatabaseShellServer( File path, boole
getClass().getResource( "/config-with-bolt-connector.conf" ).getFile()}, mock( CtrlCHandler.class ) ); getClass().getResource( "/config-with-bolt-connector.conf" ).getFile()}, mock( CtrlCHandler.class ) );
try try
{ {
log.assertNone( inLog( startsWith( BoltKernelExtension.class.getPackage().getName() ) ).any() ); log.assertNone( inLog( startsWith( BoltServer.class.getPackage().getName() ) ).any() );
} }
finally finally
{ {
Expand Down
Expand Up @@ -125,7 +125,7 @@ private void createAndStartDb()
.newImpermanentDatabaseBuilder( testDirectory.graphDbDir() ) .newImpermanentDatabaseBuilder( testDirectory.graphDbDir() )
.setConfig( bolt.enabled, "true" ) .setConfig( bolt.enabled, "true" )
.setConfig( bolt.listen_address, ":" + PortAuthority.allocatePort() ) .setConfig( bolt.listen_address, ":" + PortAuthority.allocatePort() )
.setConfig( BoltKernelExtension.Settings.ssl_policy, "bolt" ) .setConfig( BoltServer.Settings.ssl_policy, "bolt" )
.setConfig( sslPolicy.allow_key_generation, "true" ) .setConfig( sslPolicy.allow_key_generation, "true" )
.setConfig( sslPolicy.base_directory, "certificates" ) .setConfig( sslPolicy.base_directory, "certificates" )
.setConfig( sslPolicy.tls_versions, setup.boltTlsVersions ) .setConfig( sslPolicy.tls_versions, setup.boltTlsVersions )
Expand Down

0 comments on commit f83790d

Please sign in to comment.