neo4j.conf config line without newline has no effect

[amorgner]

A configuration line without newline character at the end of neo4j.conf seems to be ignored.

Neo4j Version: 3.4.7
Operating System: Ubuntu 18.04

Steps to reproduce

1. Add a configuration line to neo4j.conf and omit newline at the end (just an example, the type or content of the configuration option doesn't matter):

   dbms.jvm.additional=-Dfoo=bar

2. Start Neo4j

3. Process command line doesn't contain the configured option:

   7340 pts/1 Sl 0:08 /usr/lib/jvm/java-8-oracle/bin/java -cp /home/axel/Downloads/neo4j-enterprise-3.4.7/plugins:/home/axel/Downloads/neo4j-enterprise-3.4.7/conf:/home/axel/Downloads/neo4j-enterprise-3.4.7/lib/*:/home/axel/Downloads/neo4j-enterprise-3.4.7/plugins/*:/usr/lib/jvm/java-8-oracle/lib/tools.jar -server -Xms1g -Xmx4g -XX:+UseG1GC -XX:-OmitStackTraceInFastThrow -XX:+AlwaysPreTouch -XX:+UnlockExperimentalVMOptions -XX:+TrustFinalNonStaticFields -XX:+DisableExplicitGC -Djdk.tls.ephemeralDHKeySize=2048 -Djdk.tls.rejectClientInitiatedRenegotiation=true -Dunsupported.dbms.udc.source=tarball -Dfile.encoding=UTF-8 com.neo4j.server.enterprise.CommercialEntryPoint --home-dir=/home/axel/Downloads/neo4j-enterprise-3.4.7 --config-dir=/home/axel/Downloads/neo4j-enterprise-3.4.7/conf

4. Add newline at the end of neo4j.conf (after the line inserted in 1.)

5. Restart Neo4j

6. Process command line now does contain the option:

   7548 pts/1 Sl 0:09 /usr/lib/jvm/java-8-oracle/bin/java -cp /home/axel/Downloads/neo4j-enterprise-3.4.7/plugins:/home/axel/Downloads/neo4j-enterprise-3.4.7/conf:/home/axel/Downloads/neo4j-enterprise-3.4.7/lib/*:/home/axel/Downloads/neo4j-enterprise-3.4.7/plugins/*:/usr/lib/jvm/java-8-oracle/lib/tools.jar -server -Xms1g -Xmx4g -XX:+UseG1GC -XX:-OmitStackTraceInFastThrow -XX:+AlwaysPreTouch -XX:+UnlockExperimentalVMOptions -XX:+TrustFinalNonStaticFields -XX:+DisableExplicitGC -Djdk.tls.ephemeralDHKeySize=2048 -Djdk.tls.rejectClientInitiatedRenegotiation=true -Dunsupported.dbms.udc.source=tarball -Dfoo=bar -Dfile.encoding=UTF-8 com.neo4j.server.enterprise.CommercialEntryPoint --home-dir=/home/axel/Downloads/neo4j-enterprise-3.4.7 --config-dir=/home/axel/Downloads/neo4j-enterprise-3.4.7/conf

Expected behavior

Configuration option is not ignored even if line is not followed by newline character

Actual behavior

Configuration option is ignored if line is not followed by newline character

[craigtaverner]

Since the mistake seems to be occurring before java is even being called, this is presumably a mistake in the bash script running neo4j. I would suspect lines 208-210 of the neo4j script which reads the neo4j.conf.