New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support neo4j temporal types #1539
Comments
I should be able to spare some time to work on this, but don't know enough about the neo4j API or the ruby gems to drive it. |
All those types will be supported in neo4j-ruby-driver. They already are in the jruby version. There is work remaining to make the neo4j gem fully leverage the driver. That will probably happen along with discontinuing support for any adaptor except the the (bolt) driver. |
Not sure if this helps or hurts, and I know this issue is old and is currently being worked on (via I wanted to use
Unfortunately, there's no documentation for Bolt v2, v3, or v4, so that's why I went off the java driver implementation. I also discovered this developer site, but it's still lacking. https://neo4j-drivers.github.io The implementation is minimal, pretty hacky, and definitely breaks support for existing projects (that use As with everyone, my time is limited, but I'm curious to hear if it's worth cleaning up the implementation and submitting a PR. I'd most likely need a lot of direction, and I think it'd be a lot of work, specifically:
Either way, just wanted to share and try to give back a little. Thanks again for all the work! |
Ah, also just seeing #1575 , not sure if that invalidates anything above. |
@ashie1287 thanks for that. The temporal types are implemented here: https://github.com/neo4jrb/neo4j-ruby-driver/tree/master/lib/neo4j/driver/types and the conversion here https://github.com/neo4jrb/neo4j-ruby-driver/tree/master/ffi/neo4j/driver/internal/value. The type mapping might be not ideal https://github.com/neo4jrb/neo4j-ruby-driver/blob/master/docs/dev_manual_examples.rb#L265-L287. I would very much appreciate any feedback. |
Neo4j 3.4 introduced temporal types, including
datetime
andlocal_datetime
. Theneo4j
gem does not yet support these: it converts Ruby Date, Time, DateTime types into an integer, and duration types are not utilised. Please add support for these temporal types.The text was updated successfully, but these errors were encountered: