1330 fix #1331
Merged
1330 fix #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ActiveRel get wrapped (cherry picked from commit 618246b)
Codecov Report@@ Coverage Diff @@
## master #1331 +/- ##
==========================================
- Coverage 97.06% 96.59% -0.47%
==========================================
Files 203 205 +2
Lines 12337 12704 +367
==========================================
+ Hits 11975 12272 +297
- Misses 362 432 +70
Continue to review full report at Codecov.
|
phreakocious
reviewed
Feb 4, 2017
lib/neo4j/tasks/migration.rake
Outdated
| neo4j_url = ENV['NEO4J_URL'] || 'http://localhost:7474' | ||
| $:.unshift File.dirname('./') | ||
| Neo4j::ActiveBase.on_establish_session do | ||
| type = neo4j_url.match(/^bolt/) ? :bolt : http |
There was a problem hiding this comment.
I think http here should be :http ..
This commit resolves my issues if I set that environment variable to a bolt:// URL in the Rakefile but fails with this otherwise:
'NameError: undefined local variable or method `http' for main:Object'
There was a problem hiding this comment.
Great catch, thanks! Since you can confirm this I'll go ahead and get it in and release a patch version
|
Fixes #1353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1330
This pull introduces/changes:
neo4jgem (not just rails apps)Railtiefor loading an environment for non-Rails apps (I'd still like this to be able to look for theneo4j.yml, but this should work for now)Pings:
@subvertallchris
@ProGM