Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making #columns return an array of objects instead of symbols #205

Merged
merged 1 commit into from Jul 14, 2012

Conversation

cfitz
Copy link
Contributor

@cfitz cfitz commented Jul 12, 2012

hey Andreas,

I've been using twitter-bootstrap-rails to generate view for my applications. However, it seems to want #columns method to return an array of objects rather than just symbols (like how active record does it). I added some code to wrap the _decl_props into a Column object. Does this look alright or might this cause problems?

thanks! b,chris.

@andreasronge
Copy link
Member

Great ! I will have a look at it in the next few days.

sent from my phone
On Jul 12, 2012 11:49 PM, "cfitz" <
reply@reply.github.com>
wrote:

hey Andreas,

I've been using twitter-bootstrap-rails to generate view for my
applications. However, it seems to want #columns method to return an array
of objects rather than just symbols (like how active record does it). I
added some code to wrap the _decl_props into a Column object. Does this
look alright or might this cause problems?

thanks! b,chris.

You can merge this Pull Request by running:

git pull https://github.com/cfitz/neo4j master

Or you can view, comment on it, or merge it online at:

#205

-- Commit Summary --

  • making #columns return array of column objects

-- File Changes --

M lib/neo4j/rails/attributes.rb (8)
A lib/neo4j/rails/column.rb (26)
M lib/neo4j/rails/rails.rb (3)
M spec/integration/model_spec.rb (11)
A spec/unit/column_spec.rb (32)

-- Patch Links --

https://github.com/andreasronge/neo4j/pull/205.patch
https://github.com/andreasronge/neo4j/pull/205.diff


Reply to this email directly or view it on GitHub:
#205

andreasronge added a commit that referenced this pull request Jul 14, 2012
making #columns return an array of objects instead of symbols
@andreasronge andreasronge merged commit ba4e57f into neo4jrb:master Jul 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants