Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScreenEvent.BackgroundRendered not called for AbstractContainerScreen #1182

Closed
JaisDK opened this issue Jun 25, 2024 · 4 comments
Closed

ScreenEvent.BackgroundRendered not called for AbstractContainerScreen #1182

JaisDK opened this issue Jun 25, 2024 · 4 comments
Labels
1.21 Targeted at Minecraft 1.21 bug A bug or error regression Worked previously but doesn't anymore

Comments

@JaisDK
Copy link
Contributor

JaisDK commented Jun 25, 2024

Minecraft Version: 1.21

NeoForge Version: 21.0.37-beta

Logs:

Steps to Reproduce:

  1. Extend AbstractContainerScreen and call this.renderBackground
  2. Subscribe to ScreenEvent.BackgroundRendered
  3. event does not fire

Description of issue:
AbstractContainerScreen now has a renderBackground method preventing Screen.renderBackground, where the event is fired, from being called
@JaisDK JaisDK added the triage Needs triaging and confirmation label Jun 25, 2024
@Spinoscythe
Copy link
Contributor

@JaisDK correct me if I'm wrong, but the event for container screens is ContainerScreenEvent.Render.Background?

@JaisDK
Copy link
Contributor Author

JaisDK commented Jun 25, 2024

That would probably work. I guess in 1.20.1 they were both fired.

@JaisDK JaisDK closed this as completed Jun 25, 2024
@ChampionAsh5357 ChampionAsh5357 added bug A bug or error regression Worked previously but doesn't anymore 1.21 Targeted at Minecraft 1.21 and removed triage Needs triaging and confirmation labels Jun 25, 2024
@ChampionAsh5357
Copy link
Contributor

Reopening this as it is an actual bug.

@Spinoscythe Spinoscythe mentioned this issue Jun 25, 2024
Closed
@ChampionAsh5357
Copy link
Contributor

And now I'm closing again since it's a duplicate of #1077! Should really pay attention more. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.21 Targeted at Minecraft 1.21 bug A bug or error regression Worked previously but doesn't anymore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JaisDK @ChampionAsh5357 @Spinoscythe