IngredientType and FluidIngredientType's streamCodec only allow registry codecs

[LatvianModder]

Minecraft Version: 1.21

NeoForge Version: 21.0.37-beta

Example class:

public record NamespaceIngredient(String namespace) implements ICustomIngredient {
	public static final MapCodec<NamespaceIngredient> CODEC = RecordCodecBuilder.mapCodec(instance -> instance.group(
		Codec.STRING.fieldOf("namespace").forGetter(NamespaceIngredient::namespace)
	).apply(instance, NamespaceIngredient::new));

	public static final StreamCodec<ByteBuf, NamespaceIngredient> STREAM_CODEC = ByteBufCodecs.STRING_UTF8.map(NamespaceIngredient::new, NamespaceIngredient::namespace);

Description of issue:

StreamCodec<ByteBuf, ... should be allowed in constructors of IngredientType and FluidIngredientType, but only specifically StreamCodec<RegistryFriendlyByteBuf is.

Using this

new IngredientType<>(NamespaceIngredient.CODEC, NamespaceIngredient.STREAM_CODEC)

will fail to compile with

The way to fix this is change StreamCodec<RegistryFriendlyByteBuf to StreamCodec<? super RegistryFriendlyByteBuf like most other places in Minecraft for both ingredient types.

Temp fix:

Casting the stream codec to diamond-less (StreamCodec) works. Example:

new IngredientType<>(NamespaceIngredient.CODEC, (StreamCodec) NamespaceIngredient.STREAM_CODEC)