Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of DistExecutor #16

Closed
tmvkrpxl0 opened this issue Oct 4, 2023 · 3 comments · Fixed by #48
Closed

Remove mention of DistExecutor #16

tmvkrpxl0 opened this issue Oct 4, 2023 · 3 comments · Fixed by #48

Comments

@tmvkrpxl0
Copy link
Contributor

In FancyModLoader DistExecutor is marked deprecated and will be removed. so we should now stop directing users to it.
https://github.com/neoforged/Documentation/blob/main/docs/concepts/sides.md?plain=1#L31-L66
This section should be rewritten to demonstrate other ways of checking physical sides without class loading issue.
@Shadows-of-Fire
Copy link

Yeah, we need to resurrect MinecraftForge/MergeTool#8 in some form

@Shadows-of-Fire
Copy link

neoforged/MergeTool#1

@IchHabeHunger54
Copy link
Member

Will be fixed by #48 .

@IchHabeHunger54 IchHabeHunger54 linked a pull request Feb 23, 2024 that will close this issue
Rework the Concepts chapter #48
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework the Concepts chapter IchHabeHunger54/NeoForgedDocumentation
3 participants
@Shadows-of-Fire @tmvkrpxl0 @IchHabeHunger54