Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save commit message #23

Closed
hkupty opened this issue Oct 1, 2020 · 1 comment · Fixed by #46
Closed

Save commit message #23

hkupty opened this issue Oct 1, 2020 · 1 comment · Fixed by #46
Labels
enhancement New feature or request

Comments

@hkupty
Copy link
Contributor

hkupty commented Oct 1, 2020

When in a repo that uses git hooks, commit might not go through. Saving the commit message and reopening it if the last command didn't go through would be good. If it's stored in a file, not overriding the content of the file if it exists (only replacing the commented lines) would solve the issue.
@TimUntersberger TimUntersberger added the enhancement New feature or request label Oct 4, 2020
@hadronized
Copy link

Agreed, it’s useful for people signing commits and failing the GPG secret prompt. 😆

RianFuro added a commit to RianFuro/neogit that referenced this issue Feb 28, 2021
@RianFuro
fix(NeogitOrg#23): keep commit message around if commit fails
00e4472 
Since the commit can fail for various reasons, we keep the commit
message file after the user closes the buffer and only remove it after
the commit was successful. Upon opening the commit buffer, we read the
commit file's contents, if it exists, and present it as the suggested
commit message
RianFuro added a commit to RianFuro/neogit that referenced this issue Feb 28, 2021
@RianFuro
fix(NeogitOrg#23): keep commit message around if commit fails
d5a230d 
Since the commit can fail for various reasons, we keep the commit
message file after the user closes the buffer and only remove it after
the commit was successful. Upon opening the commit buffer, we read the
commit file's contents, if it exists, and present it as the suggested
commit message
RianFuro added a commit to RianFuro/neogit that referenced this issue Feb 28, 2021
@RianFuro
fix(NeogitOrg#23): keep commit message around if commit fails
cc8a371 
Since the commit can fail for various reasons, we keep the commit
message file after the user closes the buffer and only remove it after
the commit was successful. Upon opening the commit buffer, we read the
commit file's contents, if it exists, and present it as the suggested
commit message
RianFuro added a commit to RianFuro/neogit that referenced this issue Feb 28, 2021
@RianFuro
fix(NeogitOrg#23): keep commit message around if commit fails
9f5e5d6 
Since the commit can fail for various reasons, we keep the commit
message file after the user closes the buffer and only remove it after
the commit was successful. Upon opening the commit buffer, we read the
commit file's contents, if it exists, and present it as the suggested
commit message
RianFuro added a commit to RianFuro/neogit that referenced this issue Feb 28, 2021
@RianFuro
fix(NeogitOrg#23): keep commit message around if commit fails
40e3a31 
Since the commit can fail for various reasons, we keep the commit
message file after the user closes the buffer and only remove it after
the commit was successful. Upon opening the commit buffer, we read the
commit file's contents, if it exists, and present it as the suggested
commit message
@RianFuro RianFuro mentioned this issue Mar 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep commit message on commit failure and more RianFuro/neogit
3 participants
@hadronized @hkupty @TimUntersberger