gcc maker's errorformat should catch fatal errors for missing includes

[NickeZ]

I feel very stupid but I can't enable gcc maker. I've tried multiple ways. I have installed neomake with https://github.com/junegunn/vim-plug if that matters.

Expected behavior

gcc maker should be enabled

Steps to reproduce

Put one of the following lines in the vim config:

let g:neomake_cpp_enabled_makers = ['gcc']
let g:neomake_enabled_makers = ['gcc']

Output of the ":verb NeomakeInfo" command

Neomake debug information

Async support: 1
Current filetype: cpp

Enabled makers

For the current filetype (with :Neomake):

• gcc
  errorformat: '%-G%f:%s:,%-G%f:%l: %#error: %#(Each undeclared identifier is reported only%.%#,%-G%f:%l: %#error: %#for each function it appears%.%#,%-GIn file included%.%#,%-G %#from %f:%l,,%f:%l:%c: %trror: %m,%f:%l:%c: %tarning: %m,%I%f:%l:%c: note: %m,%f:%l:%c: %m,%f:%l: %trror: %m,%f:%l: %tarning: %m,%I%f:%l:
  note: %m,%f:%l: %m'
  args: ['-fsyntax-only', '-Wall', '-Wextra']
  get_argv: function('2', {'get_argv': function('2')})
  exe: 'g++'
  NOTE: you can define g:neomake_cpp_enabled_makers to configure it (or b:neomake_cpp_enabled_makers).

For the project (with :Neomake!): None.
NOTE: you can define g:neomake_enabled_makers to configure it.

Default maker settings:

• remove_invalid_entries: 0
• buffer_output: 1

Settings

g:neomake_place_signs = 1                                                                                                                                                                                                                                                                                                     
g:neomake_c_enabled_makers = ['gcc']                                                                                                                                                                                                                                                                                          
g:neomake_cpp_enabled_makers = ['gcc']                                                                                                                                                                                                                                                                                        
                                                                                                                                                                                                                                                                                                                              
shell: /bin/bash                                                                                                                                                                                                                                                                                                              
shellcmdflag: -c                                                                                                                                                                                                                                                                                                              
Windows: 0                                                                                                                                                                                                                                                                                                                    

:version

NVIM 0.2.0-dev                                                                                                                                                                                                                                                                                                                
Build type: RelWithDebInfo                                                                                                                                                                                                                                                                                                    
Compilation: /usr/bin/cc -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -D_GNU_SOURCE -I/builddir/build/BUILD/neovim-0
.1.7-2a366b6/build/config -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/src -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/.deps/usr/include -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/.deps/usr/include -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/.deps/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/in
clude -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/build/src/nvim/auto -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/build/include                                                                                                                                                                                             
Compiled by mockbuild                                                                                                                                                                                                                                                                                                         
                                                                                                                                                                                                                                                                                                                              
Optional features included (+) or not (-): +acl   +iconv    +jemalloc +tui                                                                                                                                                                                                                                                    
For differences from Vim, see :help vim-differences                                                                                                                                                                                                                                                                           
                                                                                                                                                                                                                                                                                                                              
   system vimrc file: "$VIM/sysinit.vim"                                                                                                                                                                                                                                                                                      
  fall-back for $VIM: "/usr/share/nvim"                                                                                                                                                                                                                                                                                       

:messages

"git/epics-modules/m-epics-ifcfastint/src/IFCFastIntDIChannel.cpp" 465L, 17791C                                                                                                                                                                                                                                               
NVIM 0.2.0-dev                                                                                                                                                                                                                                                                                                                
Build type: RelWithDebInfo                                                                                                                                                                                                                                                                                                    
Compilation: /usr/bin/cc -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -D_GNU_SOURCE -I/builddir/build/BUILD/neovim-0
.1.7-2a366b6/build/config -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/src -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/.deps/usr/include -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/.deps/usr/include -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/.deps/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/in
clude -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/build/src/nvim/auto -I/builddir/build/BUILD/neovim-0.1.7-2a366b6/build/include                                                                                                                                                                                             

[NickeZ]

Related question: How do I add arguments to gcc so that it finds my includes?

[NickeZ]

It seems that it was enabled all along, but it probably didn't parse the error. I got a fatal error because gcc couldn't find a header file.

Then I used let g:neomake_cpp_gcc_args = [... to add my include directories.

[blueyed]

I got a fatal error because gcc couldn't find a header file.

The default error format should have matched this, so it can be considered a bug I think.

[blueyed]

@NickeZ
Can you post the output from when not using the proper args, i.e. the fatal error, please?

[NickeZ]

@blueyed Sorry, I was probably just confused. By default neomake doesn't open the list of issues and I remember that I looked for some marker in the gutter but I couldn't see one. I can't reproduce the issue any more...

[NickeZ]

It would have been nice if the readme mentions g:neomake_open_list and that some documentation about the C maker mentions how to set include paths: let g:neomake_c_gcc_args = ['-fsyntax-only', '-Wall', '-Wextra', '-I/arg/to/include']. I looked everywhere and found the solution in some issue..