Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and fix issue with not running on Windows-latest triggered via GitHub actions #21

Closed
neomatrix369 opened this issue Oct 15, 2020 · 1 comment · Fixed by #19 or #48
Closed

Investigate and fix issue with not running on Windows-latest triggered via GitHub actions #21

neomatrix369 opened this issue Oct 15, 2020 · 1 comment · Fixed by #19 or #48
Assignees
@neomatrix369
Labels
2. medium-priority Good if it can be attended to be soon, but not urgent enough bug Something isn't working build/setup/installation ci/cd github-action help wanted Extra attention is needed limitations

Comments

@neomatrix369
Copy link
Owner

neomatrix369 commented Oct 15, 2020 •
edited
Loading

Currently, the test-coverage.sh script does not seem to run or produce test coverage reports on the Windows instances when run via the GitHub instance, this isn't desired.

It would be good to do one of the following:

  • investigate why this does not work on Windows on Github actions
  • convert shell script into tox (using tox conventions) to make it uniform and consistent all across

Discovered when inspecting outcome of PR #19
@neomatrix369 neomatrix369 added bug Something isn't working 2. medium-priority Good if it can be attended to be soon, but not urgent enough github-action ci/cd build/setup/installation labels Oct 15, 2020
@neomatrix369 neomatrix369 mentioned this issue Oct 15, 2020
Merged
@neomatrix369 neomatrix369 linked a pull request Oct 16, 2020 that will close this issue
Creating ci/cd github action #19
Merged
@neomatrix369 neomatrix369 added the help wanted Extra attention is needed label Oct 16, 2020
@neomatrix369 neomatrix369 mentioned this issue Oct 24, 2020
Merged
@neomatrix369 neomatrix369 linked a pull request Oct 24, 2020 that will close this issue
Fix GitHub action to build on Windows instances #48
Merged
@neomatrix369
Copy link
Owner Author

Fixed via PR #48

@neomatrix369 neomatrix369 self-assigned this Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neomatrix369 neomatrix369

Labels
2. medium-priority Good if it can be attended to be soon, but not urgent enough bug Something isn't working build/setup/installation ci/cd github-action help wanted Extra attention is needed limitations
Projects
None yet
Milestone
No milestone
1 participant
@neomatrix369