Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging for Origin part #24

Closed
neomerx opened this issue Sep 3, 2017 · 0 comments
Closed

Improve logging for Origin part #24

neomerx opened this issue Sep 3, 2017 · 0 comments
Assignees
@neomerx
Labels
enhancement

Comments

@neomerx
Copy link
Owner

neomerx commented Sep 3, 2017

Currently when a request without origin or origin not matching the server's one incomes the component logs at debug level

Request is not CORS (request origin is empty or equals to server one).  Check config settings for Server Origin.

There are two issues here:

  • From the log it's not clear is it a problem with the request (no origin) or there is no match for the origin. It should be 2 distinct messages depending on the situation.
  • debug level should be bumped to info because if a developer activates logging it more likely to expect the request to be CORS so this issue should be more visible.

That's the corresponding code.
@neomerx neomerx self-assigned this Sep 3, 2017
@neomerx neomerx closed this as completed in 24944f3 Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neomerx neomerx

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neomerx