Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UB on comparison #755

Closed
lordnn opened this issue Sep 22, 2022 · 3 comments · Fixed by #822
Closed

UB on comparison #755

lordnn opened this issue Sep 22, 2022 · 3 comments · Fixed by #822

Comments

@lordnn
Copy link
Contributor

lordnn commented Sep 22, 2022

Comparison by relation < is undefined for boolean data type:

neoml/NeoML/src/TraditionalML/GradientBoostQSEnsemble.cpp

Lines 662 to 665 in 5f0e892

const bool firstIsInverted = HasFlag( first.PropertiesMask, PM_Inverted );
const bool secondIsInverted = HasFlag( second.PropertiesMask, PM_Inverted );
if( firstIsInverted != secondIsInverted ) {
return ( firstIsInverted < secondIsInverted );

@ZigRazor
Copy link
Contributor

Can i Solve this?

@FedyuninV
Copy link
Contributor

Can i Solve this?

Be my guest)

@ZigRazor
Copy link
Contributor

do you have to assign to me?

This was referenced Mar 29, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@FedyuninV @lordnn @ZigRazor