Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async API #26

Closed
kjvalencik opened this issue Dec 26, 2015 · 12 comments
Closed

Async API #26

kjvalencik opened this issue Dec 26, 2015 · 12 comments

Comments

@kjvalencik
Copy link
Member

Any plans for an async API? Any road blocks that you would anticipate?

Great module! Cheers.

@jonathanmarvens
Copy link

@kjvalencik Can you please clarify what you mean by “an async API”?

@kjvalencik
Copy link
Member Author

Maybe I'm missing something (I'm a noob at Rust), but there doesn't appear to be a way to safely accept a callback, grab a libuv thread for execution and stop blocking the event loop.

https://github.com/nodejs/nan#nancallback

If it is possible, an example would be excellent! Thanks.

@dherman
Copy link
Collaborator

dherman commented Dec 30, 2015

Yep, we'll definitely need something like that. One of my near-term plans is to sketch up an API road map.

@dherman dherman added the API label Jan 6, 2016
@Drakulix
Copy link

Whats the current Status on this and how would you like to see this implemented?
This is the biggest blocker for using Neon for me, so if I can help you with, I am happy to do so.

It mostly comes down to, how you would like to see Callback and AsyncWorker to be interfaced by Rust. Especially AsyncWorker is really tricky.

@dherman
Copy link
Collaborator

dherman commented Mar 28, 2016

@Drakulix I'm getting ready to start looking into this, but I haven't used Nan's AsyncWorker etc. Can you help get me up to speed? Where should I go to learn more about them (other than the API docs, of course)?

@bnoordhuis
Copy link

@dherman If you have questions, I should be able to answer them.

@kamicut
Copy link

kamicut commented Apr 8, 2016

@dherman dherman mentioned this issue Apr 21, 2016
@netgusto
Copy link

netgusto commented May 7, 2016

Maybe would it be possible by chaining scopes like this:

nodejs -> Nan[dispatch-async-stuff] -> neon[process-sync-stuff] ?

@loyd
Copy link

loyd commented Apr 29, 2017

What is the current status on this?

@dherman
Copy link
Collaborator

dherman commented May 1, 2017

@loyd It's working its way up my priority queue but not at the top just yet—I've been focused on Electron support first. I haven't dropped this but can't give an ETA just yet, I'm afraid…

@kjvalencik
Copy link
Member Author

I think this is implemented by #214 and can be closed.

@dherman
Copy link
Collaborator

dherman commented Oct 11, 2017

@kjvalencik Agreed! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants