Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require compute restart to change pageserver connection string #4578

Closed
LizardWizzard opened this issue Jun 27, 2023 · 6 comments
Closed
Assignees
Labels
c/compute Component: compute, excluding postgres itself c/storage/pageserver Component: storage: pageserver

Comments

@LizardWizzard
Copy link
Contributor

LizardWizzard commented Jun 27, 2023

Most of the relocation time is spent to stop/start compute endpoints. Lets avoid that.

We can still detach tenant from pageserver compute is being connected to. (I think this is fine, need to discuss it).

At this point reconnections on smgr side should hide the disconnects from user.

When attach is completed we change the connection string and restart compute.

For that we need to add support in postgres to allow changing this config variable with SIGHUP.

Context: https://neondb.slack.com/archives/C03H1K0PGKH/p1687866020116189

@LizardWizzard LizardWizzard added the c/storage/pageserver Component: storage: pageserver label Jun 27, 2023
@vadim2404 vadim2404 added the c/compute Component: compute, excluding postgres itself label Aug 18, 2023
@jcsp jcsp removed their assignment Oct 2, 2023
@jcsp
Copy link
Contributor

jcsp commented Oct 2, 2023

Unassigning self: we think it makes sense for the compute team to do this work, pending @vadim2404 confirming.

@knizhnik
Copy link
Contributor

knizhnik commented Oct 2, 2023

Pageserver connection string is defined now as PGC_POSTMASTER GUC "neon.pageserver_connstring".
To be able to change it with alter system pg_reload_conf it is necessary to change it to PGC_SIGHUP.
Is it the only thing which should be done in this ticket?
If so, why it was not addressed in 3 month?
I can create online PR...

@stepashka
Copy link
Member

notes from Nov 6th 2023:
this is worked by Sasha in compute team, but for visibility putting 'in progress' in Storage team project too.

@vadim2404
Copy link
Contributor

@save-buffer has already merged these changes

@jcsp
Copy link
Contributor

jcsp commented Nov 6, 2023

A change landed, but it doesn't fully work yet -- keeping this ticket open to track that.

#5693

@jcsp
Copy link
Contributor

jcsp commented Nov 8, 2023

completed in #5693

@jcsp jcsp closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/compute Component: compute, excluding postgres itself c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

No branches or pull requests

6 participants