Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make page diff in test_vm_bits more robust and nicer to read #8021

Open
hlinnaka opened this issue Jun 11, 2024 · 0 comments
Open

Make page diff in test_vm_bits more robust and nicer to read #8021

hlinnaka opened this issue Jun 11, 2024 · 0 comments
Labels
a/test Area: related to testing

Comments

@hlinnaka
Copy link
Contributor

Suggestion from @koivunej:

I am increasingly confused about the 8:100 ... If that is not 8: because of assertion messages, shouldn't we just chunk the 8: to be 16 or 32 bytes and check those individually? Chunking & asserting would cause us to lose if the pages differ in two chunks.. Maybe doing a diff -u <(hexdump -Cv --skip 8 page_from_cache) <(hexdump -Cv --skip 8 page_from_ps) would be easiest and cleanest for the assertion message, and assert on the diff exit code?

Unsure if mac has compatible hexdump.

Originally posted by @koivunej in #7989 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/test Area: related to testing
Projects
None yet
Development

No branches or pull requests

1 participant