Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label font + color customization + many fixes #46

Merged
merged 18 commits into from Oct 17, 2019

Conversation

bradleymackey
Copy link
Contributor

@bradleymackey bradleymackey commented Oct 15, 2019

Just adds a bit more label customisation to the built in FormItems to prevent the need for jumping out to CustomFormItem all the time (#19). Ideally this would be refactored to allow any property on a given form item to be customized without have all the code duplication, but this personally meets my requirements for now!

(Also fixed issues with iPhone X layout (#36) and bug where TextViewFormItem would size incorrectly)

@bradleymackey
Copy link
Contributor Author

Fixes #19

@bradleymackey
Copy link
Contributor Author

Fixes #36

@bradleymackey bradleymackey changed the title Label font + color customization for most default items, small fixes Label font + color customization, safe area layout fix, small fixes Oct 15, 2019
@bradleymackey bradleymackey changed the title Label font + color customization, safe area layout fix, small fixes Label font + color customization + many fixes Oct 15, 2019
@neoneye
Copy link
Owner

neoneye commented Oct 17, 2019

Neat improvement with the CustomizableTitleLabel extension.

@neoneye neoneye merged commit 9a9b3e9 into neoneye:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants