Extract the full beta version, add prerelease spec for 20160705 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, LGTM except for the one rubocop thing: https://travis-ci.org/neonichu/xcode-install/builds/142574405#L206 |
|
Yeah, sorry about that! This next one should fix that. |
|
Let me know if you prefer that I just squash these two. |
|
Squashing is unnecessary, thanks :) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was a tiny regex fix to include the extra 'beta 2' here. It could probably be optimized in terms of instead extracting out a matched group, but I opted to keep the same scan/sub logic instead. This should address #143. Thanks for your consideration!