support passing custom file path or HTTP URL for Xcode DMG #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps addresses #54. |
|
@neonichu what do you think? |
| def install_version(version, switch = true, clean = true, install = true, progress = true) | ||
| return if version.nil? | ||
| dmg_path = get_dmg(version, progress) | ||
| def install_version(version, switch = true, clean = true, install = true, progress = true, url) |
There was a problem hiding this comment.
shouldn't url default to nil
There was a problem hiding this comment.
it could, although the only place it's used in this codebase provides a value for it
|
@segiddins thanks for the feedback. Nudge nudge @neonichu? |
|
Let's merge this, thanks! |
neonichu
added a commit
that referenced
this pull request
Nov 1, 2015
support passing custom file path or HTTP URL for Xcode DMG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's possible that parts of this aren't wrong...